From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55407) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjYg6-0006to-AZ for qemu-devel@nongnu.org; Mon, 12 Sep 2016 17:22:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bjYg2-0004hM-6i for qemu-devel@nongnu.org; Mon, 12 Sep 2016 17:22:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:52678) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bjYg1-0004hB-Uy for qemu-devel@nongnu.org; Mon, 12 Sep 2016 17:22:06 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6074E89C30 for ; Mon, 12 Sep 2016 21:22:05 +0000 (UTC) References: <20160912091913.15831-1-marcandre.lureau@redhat.com> <20160912091913.15831-19-marcandre.lureau@redhat.com> From: Eric Blake Message-ID: <0211fca4-22a5-2c6f-ded5-377bb41f2aba@redhat.com> Date: Mon, 12 Sep 2016 16:22:04 -0500 MIME-Version: 1.0 In-Reply-To: <20160912091913.15831-19-marcandre.lureau@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="2cDoPEjDnWFmJkLXpIAdAUUDti3NKdSV8" Subject: Re: [Qemu-devel] [PATCH v6 18/18] Replace qmp-commands.hx by docs/qmp-commands.txt List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , qemu-devel@nongnu.org Cc: armbru@redhat.com This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --2cDoPEjDnWFmJkLXpIAdAUUDti3NKdSV8 From: Eric Blake To: =?UTF-8?Q?Marc-Andr=c3=a9_Lureau?= , qemu-devel@nongnu.org Cc: armbru@redhat.com Message-ID: <0211fca4-22a5-2c6f-ded5-377bb41f2aba@redhat.com> Subject: Re: [PATCH v6 18/18] Replace qmp-commands.hx by docs/qmp-commands.txt References: <20160912091913.15831-1-marcandre.lureau@redhat.com> <20160912091913.15831-19-marcandre.lureau@redhat.com> In-Reply-To: <20160912091913.15831-19-marcandre.lureau@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 09/12/2016 04:19 AM, Marc-Andr=C3=A9 Lureau wrote: > The only remaining function of qmp-commands.hx is to let us generate > qmp-commands.txt from it. Replace qmp-commands.hx by qmp-commands.txt.= >=20 > We intend to move the documentation into the QAPI schema and generate > qapi-commands.txt from it, but not right now. >=20 > Signed-off-by: Marc-Andr=C3=A9 Lureau > --- > Makefile | 6 +- > .gitignore | 1 - > MAINTAINERS | 1 - > docs/qapi-code-gen.txt | 6 +- > qmp-commands.hx =3D> docs/qmp-commands.txt | 1127 --------------------= ---------- > docs/writing-qmp-commands.txt | 38 - > 6 files changed, 4 insertions(+), 1175 deletions(-) > rename qmp-commands.hx =3D> docs/qmp-commands.txt (87%) >=20 > +++ b/MAINTAINERS > @@ -1237,7 +1237,6 @@ M: Markus Armbruster > S: Supported > F: qmp.c > F: monitor.c > -F: qmp-commands.hx > F: docs/*qmp-* > F: scripts/qmp/ > T: git git://repo.or.cz/qemu/armbru.git qapi-next Shouldn't we be adding F: qmp-commands.txt somewhere to the file in the interim, at least until the promised later patch lands that once again generates documentation (this time from .json files)? --=20 Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org --2cDoPEjDnWFmJkLXpIAdAUUDti3NKdSV8 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Public key at http://people.redhat.com/eblake/eblake.gpg Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBCAAGBQJX1xx8AAoJEKeha0olJ0NqmSIH/0gi230QDYaYSe3ebcfHvQjc ho6Yzsq+Op8RjoU5DkxKw2JpMjes2nHSwFbvMlARKTDtCjtuENof8NMpIvoAcaE2 fIKl1xLyzH3jJPSrtwubOn/aXrGiiEzv5dNBQ/GM6vmezCZoRNOTddgzGhRgiJ+T BgG4UMUgp3NqQGbIMy5enj971Hap1icWF5Nb2PYStpurMRUa3T0nOtUahFcM9Yuo wg03JPxJR3i5cyQELyvkL3bdIXeydGvRJkKku5dMa/jaEGs2SZZu6KlfGZn2A1PD yaHBgHQ+TqvOWtAnVL3/7L89oKEhbgNpAvI5oChKiWCroLjF0pO7FMhP1hqSe7s= =O1TQ -----END PGP SIGNATURE----- --2cDoPEjDnWFmJkLXpIAdAUUDti3NKdSV8--