From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Steve Wise" Subject: RE: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg() Date: Wed, 27 Feb 2019 14:23:45 -0600 Message-ID: <021201d4ceda$56d9e560$048db020$@opengridcomputing.com> References: <20190223092615.GM23561@mtr-leonro.mtl.com> <11ec7e04-1bff-e3b2-1b89-db134cd537ba@opengridcomputing.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <11ec7e04-1bff-e3b2-1b89-db134cd537ba@opengridcomputing.com> Content-Language: en-us Sender: netdev-owner@vger.kernel.org To: 'Leon Romanovsky' Cc: dsahern@gmail.com, stephen@networkplumber.org, netdev@vger.kernel.org, linux-rdma@vger.kernel.org List-Id: linux-rdma@vger.kernel.org > -----Original Message----- > From: Steve Wise > Sent: Tuesday, February 26, 2019 11:14 AM > To: Leon Romanovsky > Cc: dsahern@gmail.com; stephen@networkplumber.org; > netdev@vger.kernel.org; linux-rdma@vger.kernel.org > Subject: Re: [PATCH v1 iproute2-next 1/4] rdma: add helper > rd_sendrecv_msg() > > > On 2/23/2019 3:26 AM, Leon Romanovsky wrote: > > On Thu, Feb 21, 2019 at 08:19:03AM -0800, Steve Wise wrote: > >> This function sends the constructed netlink message and then > >> receives the response, displaying any error text. > >> > >> Change 'rdma dev set' to use it. > >> > >> Signed-off-by: Steve Wise > >> --- > >> rdma/dev.c | 2 +- > >> rdma/rdma.h | 1 + > >> rdma/utils.c | 21 +++++++++++++++++++++ > >> 3 files changed, 23 insertions(+), 1 deletion(-) > >> > >> diff --git a/rdma/dev.c b/rdma/dev.c > >> index 60ff4b31e320..d2949c378f08 100644 > >> --- a/rdma/dev.c > >> +++ b/rdma/dev.c > >> @@ -273,7 +273,7 @@ static int dev_set_name(struct rd *rd) > >> mnl_attr_put_u32(rd->nlh, RDMA_NLDEV_ATTR_DEV_INDEX, rd- > >dev_idx); > >> mnl_attr_put_strz(rd->nlh, RDMA_NLDEV_ATTR_DEV_NAME, > rd_argv(rd)); > >> > >> - return rd_send_msg(rd); > >> + return rd_sendrecv_msg(rd, seq); > >> } > >> > >> static int dev_one_set(struct rd *rd) > >> diff --git a/rdma/rdma.h b/rdma/rdma.h > >> index 547bb5749a39..20be2f12c4f8 100644 > >> --- a/rdma/rdma.h > >> +++ b/rdma/rdma.h > >> @@ -115,6 +115,7 @@ bool rd_check_is_key_exist(struct rd *rd, const > char *key); > >> */ > >> int rd_send_msg(struct rd *rd); > >> int rd_recv_msg(struct rd *rd, mnl_cb_t callback, void *data, uint32_t > seq); > >> +int rd_sendrecv_msg(struct rd *rd, unsigned int seq); > >> void rd_prepare_msg(struct rd *rd, uint32_t cmd, uint32_t *seq, uint16_t > flags); > >> int rd_dev_init_cb(const struct nlmsghdr *nlh, void *data); > >> int rd_attr_cb(const struct nlattr *attr, void *data); > >> diff --git a/rdma/utils.c b/rdma/utils.c > >> index 069d44fece10..a6f2826c9605 100644 > >> --- a/rdma/utils.c > >> +++ b/rdma/utils.c > >> @@ -664,6 +664,27 @@ int rd_recv_msg(struct rd *rd, mnl_cb_t callback, > void *data, unsigned int seq) > >> return ret; > >> } > >> > >> +static int null_cb(const struct nlmsghdr *nlh, void *data) > >> +{ > >> + return MNL_CB_OK; > >> +} > >> + > >> +int rd_sendrecv_msg(struct rd *rd, unsigned int seq) > >> +{ > >> + int ret; > >> + > >> + ret = rd_send_msg(rd); > >> + if (ret) { > >> + perror(NULL); > > This is more or less already done in rd_send_msg() and that function > > prints something in case of execution error. So the missing piece > > is to update rd_recv_msg(), so all places will "magically" print errors > > and not only dev_set_name(). > > Yea ok. > dev_set_name() doesn't call rd_recv_msg(). So you're suggesting I fix up rd_recv_msg() to display errors and make dev_set_name() call rd_recv_msg() with the null_cb function? You sure that's the way to go? From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26C32C43381 for ; Wed, 27 Feb 2019 20:23:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F0CAD213A2 for ; Wed, 27 Feb 2019 20:23:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730360AbfB0UXs (ORCPT ); Wed, 27 Feb 2019 15:23:48 -0500 Received: from linode.aoot.com ([69.164.194.13]:48952 "EHLO linode.aoot.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727240AbfB0UXs (ORCPT ); Wed, 27 Feb 2019 15:23:48 -0500 Received: from stevoacer (47-221-137-213.gtwncmta03.res.dyn.suddenlink.net [47.221.137.213]) by linode.aoot.com (Postfix) with ESMTP id C8813821C; Wed, 27 Feb 2019 14:23:46 -0600 (CST) From: "Steve Wise" To: "'Leon Romanovsky'" Cc: , , , References: <20190223092615.GM23561@mtr-leonro.mtl.com> <11ec7e04-1bff-e3b2-1b89-db134cd537ba@opengridcomputing.com> In-Reply-To: <11ec7e04-1bff-e3b2-1b89-db134cd537ba@opengridcomputing.com> Subject: RE: [PATCH v1 iproute2-next 1/4] rdma: add helper rd_sendrecv_msg() Date: Wed, 27 Feb 2019 14:23:45 -0600 Message-ID: <021201d4ceda$56d9e560$048db020$@opengridcomputing.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQII7r6I2VyJPIdQNc8sid040CTlwAFsLOA+AOqaRHQBcdiyB6VtkZyQ Content-Language: en-us Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org > -----Original Message----- > From: Steve Wise > Sent: Tuesday, February 26, 2019 11:14 AM > To: Leon Romanovsky > Cc: dsahern@gmail.com; stephen@networkplumber.org; > netdev@vger.kernel.org; linux-rdma@vger.kernel.org > Subject: Re: [PATCH v1 iproute2-next 1/4] rdma: add helper > rd_sendrecv_msg() > > > On 2/23/2019 3:26 AM, Leon Romanovsky wrote: > > On Thu, Feb 21, 2019 at 08:19:03AM -0800, Steve Wise wrote: > >> This function sends the constructed netlink message and then > >> receives the response, displaying any error text. > >> > >> Change 'rdma dev set' to use it. > >> > >> Signed-off-by: Steve Wise > >> --- > >> rdma/dev.c | 2 +- > >> rdma/rdma.h | 1 + > >> rdma/utils.c | 21 +++++++++++++++++++++ > >> 3 files changed, 23 insertions(+), 1 deletion(-) > >> > >> diff --git a/rdma/dev.c b/rdma/dev.c > >> index 60ff4b31e320..d2949c378f08 100644 > >> --- a/rdma/dev.c > >> +++ b/rdma/dev.c > >> @@ -273,7 +273,7 @@ static int dev_set_name(struct rd *rd) > >> mnl_attr_put_u32(rd->nlh, RDMA_NLDEV_ATTR_DEV_INDEX, rd- > >dev_idx); > >> mnl_attr_put_strz(rd->nlh, RDMA_NLDEV_ATTR_DEV_NAME, > rd_argv(rd)); > >> > >> - return rd_send_msg(rd); > >> + return rd_sendrecv_msg(rd, seq); > >> } > >> > >> static int dev_one_set(struct rd *rd) > >> diff --git a/rdma/rdma.h b/rdma/rdma.h > >> index 547bb5749a39..20be2f12c4f8 100644 > >> --- a/rdma/rdma.h > >> +++ b/rdma/rdma.h > >> @@ -115,6 +115,7 @@ bool rd_check_is_key_exist(struct rd *rd, const > char *key); > >> */ > >> int rd_send_msg(struct rd *rd); > >> int rd_recv_msg(struct rd *rd, mnl_cb_t callback, void *data, uint32_t > seq); > >> +int rd_sendrecv_msg(struct rd *rd, unsigned int seq); > >> void rd_prepare_msg(struct rd *rd, uint32_t cmd, uint32_t *seq, uint16_t > flags); > >> int rd_dev_init_cb(const struct nlmsghdr *nlh, void *data); > >> int rd_attr_cb(const struct nlattr *attr, void *data); > >> diff --git a/rdma/utils.c b/rdma/utils.c > >> index 069d44fece10..a6f2826c9605 100644 > >> --- a/rdma/utils.c > >> +++ b/rdma/utils.c > >> @@ -664,6 +664,27 @@ int rd_recv_msg(struct rd *rd, mnl_cb_t callback, > void *data, unsigned int seq) > >> return ret; > >> } > >> > >> +static int null_cb(const struct nlmsghdr *nlh, void *data) > >> +{ > >> + return MNL_CB_OK; > >> +} > >> + > >> +int rd_sendrecv_msg(struct rd *rd, unsigned int seq) > >> +{ > >> + int ret; > >> + > >> + ret = rd_send_msg(rd); > >> + if (ret) { > >> + perror(NULL); > > This is more or less already done in rd_send_msg() and that function > > prints something in case of execution error. So the missing piece > > is to update rd_recv_msg(), so all places will "magically" print errors > > and not only dev_set_name(). > > Yea ok. > dev_set_name() doesn't call rd_recv_msg(). So you're suggesting I fix up rd_recv_msg() to display errors and make dev_set_name() call rd_recv_msg() with the null_cb function? You sure that's the way to go?