From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shreyansh Jain <shreyansh.jain@nxp.com>
Subject: Re: [PATCH 38/38] net/dpaa: add packet dump for debugging
Date: Fri, 30 Jun 2017 17:17:41 +0530
Message-ID: <021b71a3-f295-e429-57c7-2319d4bb7006@nxp.com>
References: <1497591668-3320-1-git-send-email-shreyansh.jain@nxp.com>
 <1497591668-3320-39-git-send-email-shreyansh.jain@nxp.com>
 <880c1d09-bb6f-bca4-13c7-cde1ccd28ac7@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Cc: <dev@dpdk.org>, <hemant.agrawal@nxp.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from NAM03-DM3-obe.outbound.protection.outlook.com
 (mail-dm3nam03on0062.outbound.protection.outlook.com [104.47.41.62])
 by dpdk.org (Postfix) with ESMTP id A64A337A0
 for <dev@dpdk.org>; Fri, 30 Jun 2017 13:38:36 +0200 (CEST)
In-Reply-To: <880c1d09-bb6f-bca4-13c7-cde1ccd28ac7@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wednesday 28 June 2017 09:21 PM, Ferruh Yigit wrote:
> On 6/16/2017 6:41 AM, Shreyansh Jain wrote:
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> Signed-off-by: Shreyansh Jain <shreyansh.jain@nxp.com>
> 
> Is there a driver documentation, I haven't see any in net/dpaa patches?
> 
> <...>
>> +CONFIG_RTE_LIBRTE_DPAA_DEBUG_DRIVER_DISPLAY=n
>> +CONFIG_RTE_LIBRTE_DPAA_CHECKING=n
> 
> This config option is not used at all, can be removed.

This is being used in the QMAN and BMAN driver in the bus.

> 
> <...>
>> +#ifdef RTE_LIBRTE_DPAA_DEBUG_DRIVER
>> +	dpaa_debug_queue_init(&dpaa_intf->debug_queues[
>> +		DPAA_DEBUG_FQ_RX_ERROR], fman_intf->fqid_rx_err);
> 
> Out of curiosity, what exactly done here. Is this a special queue, what
> is does? It can be useful if documented more in commit log.
> 
>> +	dpaa_intf->debug_queues[DPAA_DEBUG_FQ_RX_ERROR].dpaa_intf = dpaa_intf;
>> +	dpaa_debug_queue_init(&dpaa_intf->debug_queues[
>> +		DPAA_DEBUG_FQ_TX_ERROR], fman_intf->fqid_tx_err);

Besides the normal Rx and Tx queues, for valid Rx/Tx, there are error queues which receive packet which have errors (like checksum).
This set enables those queues in for debugging purpose. For normal case (non debug), there is not much utility to check these, especially in our polling model.

>> +	dpaa_intf->debug_queues[DPAA_DEBUG_FQ_TX_ERROR].dpaa_intf = dpaa_intf;
>> +#endif
>> +
> <...>
> 
>