From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753987AbdDMXrX (ORCPT ); Thu, 13 Apr 2017 19:47:23 -0400 Received: from ec2-52-27-115-49.us-west-2.compute.amazonaws.com ([52.27.115.49]:42619 "EHLO osg.samsung.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753400AbdDMXrQ (ORCPT ); Thu, 13 Apr 2017 19:47:16 -0400 Subject: Re: [PATCH v2 05/22] ARM: dts: at91: Add generic compatible string for I2C EEPROM To: Alexandre Belloni References: <20170413182839.25381-1-javier@osg.samsung.com> <20170413182839.25381-6-javier@osg.samsung.com> <869a0f44-6c97-2109-776b-6da9b86c732a@axentia.se> <20170413212059.unh2mfo2w4oc4t33@piout.net> Cc: Peter Rosin , linux-kernel@vger.kernel.org, Wolfram Sang , devicetree@vger.kernel.org, Russell King , Rob Herring , Nicolas Ferre , Mark Rutland , linux-arm-kernel@lists.infradead.org, Geert Uytterhoeven From: Javier Martinez Canillas Message-ID: <021d8065-9d7a-f9ef-a497-f9c467d1e6d8@osg.samsung.com> Date: Thu, 13 Apr 2017 20:46:55 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170413212059.unh2mfo2w4oc4t33@piout.net> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Alexandre, On 04/13/2017 06:20 PM, Alexandre Belloni wrote: > On 13/04/2017 at 18:09:56 -0300, Javier Martinez Canillas wrote: >> Hello Peter, >> >> On 04/13/2017 05:43 PM, Peter Rosin wrote: >>> On 2017-04-13 20:28, Javier Martinez Canillas wrote: >> >> [snip] >> >>>> >>>> eeprom@50 { >>>> - compatible = "nxp,24c02"; >>>> + compatible = "nxp,24c02","atmel,24c02"; >>>> reg = <0x50>; >>>> pagesize = <16>; >>>> }; >>>> >>> >>> Sure, in principle. But not having a space after the commas is a real OCD >>> trigger for me. My spine is rotating... :-) >>> >> >> Right, Geert already pointed out. It's something I missed in my sed script >> so I got it wrong in all the DTS :( >> >> I'll fix my script and send a v2. >> > > That would be v3, right? ;) > err, right :) >>> Anyway, with those whitespace fixes (and without them too, but please): >>> Acked-by: Peter Rosin >>> >> >> Thanks for the review! >> > > I'd like to be copied on the first patches to ensure they are applied > before applying that one. (Also, it is probably too late for 4.12 anyway Ok, I'll copy you on the whole patch-set. But keep in mind that there is no strict order since $SUBJECT without the at24 OF table is a no-op (the match happens between first device in compatible string and I2C table). > because we are past rc6). > Yes, there's no rush on applying these. I'm just posting all the patches needed to finally have a proper OF modalias reporting in the I2C core. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America From mboxrd@z Thu Jan 1 00:00:00 1970 From: javier@osg.samsung.com (Javier Martinez Canillas) Date: Thu, 13 Apr 2017 20:46:55 -0300 Subject: [PATCH v2 05/22] ARM: dts: at91: Add generic compatible string for I2C EEPROM In-Reply-To: <20170413212059.unh2mfo2w4oc4t33@piout.net> References: <20170413182839.25381-1-javier@osg.samsung.com> <20170413182839.25381-6-javier@osg.samsung.com> <869a0f44-6c97-2109-776b-6da9b86c732a@axentia.se> <20170413212059.unh2mfo2w4oc4t33@piout.net> Message-ID: <021d8065-9d7a-f9ef-a497-f9c467d1e6d8@osg.samsung.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello Alexandre, On 04/13/2017 06:20 PM, Alexandre Belloni wrote: > On 13/04/2017 at 18:09:56 -0300, Javier Martinez Canillas wrote: >> Hello Peter, >> >> On 04/13/2017 05:43 PM, Peter Rosin wrote: >>> On 2017-04-13 20:28, Javier Martinez Canillas wrote: >> >> [snip] >> >>>> >>>> eeprom at 50 { >>>> - compatible = "nxp,24c02"; >>>> + compatible = "nxp,24c02","atmel,24c02"; >>>> reg = <0x50>; >>>> pagesize = <16>; >>>> }; >>>> >>> >>> Sure, in principle. But not having a space after the commas is a real OCD >>> trigger for me. My spine is rotating... :-) >>> >> >> Right, Geert already pointed out. It's something I missed in my sed script >> so I got it wrong in all the DTS :( >> >> I'll fix my script and send a v2. >> > > That would be v3, right? ;) > err, right :) >>> Anyway, with those whitespace fixes (and without them too, but please): >>> Acked-by: Peter Rosin >>> >> >> Thanks for the review! >> > > I'd like to be copied on the first patches to ensure they are applied > before applying that one. (Also, it is probably too late for 4.12 anyway Ok, I'll copy you on the whole patch-set. But keep in mind that there is no strict order since $SUBJECT without the at24 OF table is a no-op (the match happens between first device in compatible string and I2C table). > because we are past rc6). > Yes, there's no rush on applying these. I'm just posting all the patches needed to finally have a proper OF modalias reporting in the I2C core. Best regards, -- Javier Martinez Canillas Open Source Group Samsung Research America