From: Shuah Khan <skhan@linuxfoundation.org>
To: CGEL <cgel.zte@gmail.com>, Shuah Khan <shuah@kernel.org>
Cc: linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org,
jing yangyang <jing.yangyang@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>,
Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH linux-next] tools:mount: Remove unnecessary conversion to bool
Date: Tue, 24 Aug 2021 08:41:07 -0600 [thread overview]
Message-ID: <02237efa-5159-f95d-43c9-389a95803a50@linuxfoundation.org> (raw)
In-Reply-To: <20210820033241.13136-1-jing.yangyang@zte.com.cn>
On 8/19/21 9:32 PM, CGEL wrote:
> From: jing yangyang <jing.yangyang@zte.com.cn>
>
> Suppress following warning from coccinelle:
>
> ./tools/testing/selftests/mount/unprivileged-remount-test.c:285:54-59: WARNING conversion to bool not needed here
> ./tools/testing/selftests/mount/unprivileged-remount-test.c:207:54-59: WARNING conversion to bool not needed here
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: jing yangyang <jing.yangyang@zte.com.cn>
> ---
> tools/testing/selftests/mount/unprivileged-remount-test.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/tools/testing/selftests/mount/unprivileged-remount-test.c b/tools/testing/selftests/mount/unprivileged-remount-test.c
> index 584dc6b..bc802f6 100644
> --- a/tools/testing/selftests/mount/unprivileged-remount-test.c
> +++ b/tools/testing/selftests/mount/unprivileged-remount-test.c
> @@ -204,7 +204,7 @@ bool test_unpriv_remount(const char *fstype, const char *mount_options,
> if (!WIFEXITED(status)) {
> die("child did not terminate cleanly\n");
> }
> - return WEXITSTATUS(status) == EXIT_SUCCESS ? true : false;
> + return WEXITSTATUS(status) == EXIT_SUCCESS;
> }
>
> create_and_enter_userns();
> @@ -282,7 +282,7 @@ static bool test_priv_mount_unpriv_remount(void)
> if (!WIFEXITED(status)) {
> die("child did not terminate cleanly\n");
> }
> - return WEXITSTATUS(status) == EXIT_SUCCESS ? true : false;
> + return WEXITSTATUS(status) == EXIT_SUCCESS;
> }
>
> orig_mnt_flags = read_mnt_flags(orig_path);
>
We can't accept this patch. The from and Signed-off-by don't match.
thanks,
-- Shuah
prev parent reply other threads:[~2021-08-24 14:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-20 3:32 [PATCH linux-next] tools:mount: Remove unnecessary conversion to bool CGEL
2021-08-24 14:41 ` Shuah Khan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02237efa-5159-f95d-43c9-389a95803a50@linuxfoundation.org \
--to=skhan@linuxfoundation.org \
--cc=cgel.zte@gmail.com \
--cc=jing.yangyang@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=shuah@kernel.org \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.