From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 36692C5479D for ; Mon, 9 Jan 2023 11:42:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4579310E3E7; Mon, 9 Jan 2023 11:42:07 +0000 (UTC) Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by gabe.freedesktop.org (Postfix) with ESMTPS id 29B7E10E3E6 for ; Mon, 9 Jan 2023 11:42:04 +0000 (UTC) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id D04006602D66; Mon, 9 Jan 2023 11:42:00 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1673264523; bh=NbTiE9y32f/cs2nHXOmy1PoOgdwoRflnOn15GZ4u/iw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Z0X0qcckEa6SfOYaI3kGzfc3IcKXqxNE5NMoYT135HVUsXZUbg7CzPlnMcAWCz2pP jZSPsmdYn/fEWg5jL4hxLLtZ7FwljfLNPK936Og/rMJurniFrUwoEP/w2i3nznEmXg BpfI6CPwILoq7iT6nSu4NuZq1XScbtmAfAuSIYe9MCgbVJKp4CvCuniBRYVGhADOtd GUmbh6hI8AiCyQ35YX6mOgHi5Kn5Fe0gzJjowdclrGKpbtlRUTozvabnqVTIJ/NcYi NpUN9RhS47uNNrpF7aD+y6UoQCcY+DQVXhgZwRD8C6tjv2B1QytBDdw+8RC3Tu2ZBh 1dGp4yMyORxUQ== Message-ID: <023519eb-0adb-3b08-71b9-afb92a6cceaf@collabora.com> Date: Mon, 9 Jan 2023 12:41:58 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v9 3/9] drm/display: Add Type-C switch helpers Content-Language: en-US To: Pin-yen Lin , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J . Wysocki" , Prashant Malani , Benson Leung , Guenter Roeck References: <20230109084101.265664-1-treapking@chromium.org> <20230109084101.265664-4-treapking@chromium.org> From: AngeloGioacchino Del Regno In-Reply-To: <20230109084101.265664-4-treapking@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Marek Vasut , devicetree@vger.kernel.org, Douglas Anderson , =?UTF-8?Q?N=c3=adcolas_F_=2e_R_=2e_A_=2e_Prado?= , chrome-platform@lists.linux.dev, Jani Nikula , Allen Chen , Javier Martinez Canillas , dri-devel@lists.freedesktop.org, Stephen Boyd , linux-acpi@vger.kernel.org, Thomas Zimmermann , Hsin-Yi Wang , Xin Ji , linux-kernel@vger.kernel.org, Kees Cook Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Il 09/01/23 09:40, Pin-yen Lin ha scritto: > Add helpers to register and unregister Type-C "switches" for bridges > capable of switching their output between two downstream devices. > > The helper registers USB Type-C mode switches when the "mode-switch" > and the "data-lanes" properties are available in Device Tree. > > Signed-off-by: Pin-yen Lin > > --- > > (no changes since v8) > > Changes in v8: > - Fixed the build issue when CONFIG_TYPEC=m > - Fixed some style issues > > Changes in v7: > - Extracted the common codes to a helper function > - New in v7 > > drivers/gpu/drm/display/drm_dp_helper.c | 132 ++++++++++++++++++++++++ > include/drm/display/drm_dp_helper.h | 16 +++ > 2 files changed, 148 insertions(+) > > diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c > index 16565a0a5da6..fb9e23744c08 100644 > --- a/drivers/gpu/drm/display/drm_dp_helper.c > +++ b/drivers/gpu/drm/display/drm_dp_helper.c > @@ -30,11 +30,13 @@ > #include > #include > #include > +#include > #include > > #include > #include > #include > +#include > #include > #include > #include > @@ -3891,3 +3893,133 @@ int drm_panel_dp_aux_backlight(struct drm_panel *panel, struct drm_dp_aux *aux) > EXPORT_SYMBOL(drm_panel_dp_aux_backlight); > > #endif > + > +#if IS_REACHABLE(CONFIG_TYPEC) > +static int drm_dp_register_mode_switch(struct device *dev, struct device_node *node, > + struct drm_dp_typec_switch_desc *switch_desc, > + void *data, void *mux_set) > +{ > + struct drm_dp_typec_port_data *port_data; > + struct typec_mux_desc mux_desc = {}; > + char name[32]; > + u32 dp_lanes[2]; > + int ret, num_lanes, port_num = -1; > + > + num_lanes = drm_of_get_data_lanes_count(node, 0, 2); > + if (num_lanes <= 0) { > + dev_err(dev, "Error on getting data lanes count: %d\n", > + num_lanes); > + return num_lanes; > + } > + > + ret = of_property_read_u32_array(node, "data-lanes", dp_lanes, num_lanes); > + if (ret) { > + dev_err(dev, "Failed to read the data-lanes variable: %d\n", > + ret); > + return ret; > + } > + > + port_num = dp_lanes[0] / 2; > + > + port_data = &switch_desc->typec_ports[port_num]; > + port_data->data = data; > + mux_desc.fwnode = &node->fwnode; > + mux_desc.drvdata = port_data; > + snprintf(name, sizeof(name), "%s-%u", node->name, port_num); > + mux_desc.name = name; > + mux_desc.set = mux_set; > + > + port_data->typec_mux = typec_mux_register(dev, &mux_desc); > + if (IS_ERR(port_data->typec_mux)) { I would propose, instead... > + ret = PTR_ERR(port_data->typec_mux); > + dev_err(dev, "Mode switch register for port %d failed: %d\n", > + port_num, ret); return ret; > + } > + > + return ret; return 0; > +} > + ...but I don't have strong opinions, so regardless of that: Reviewed-by: AngeloGioacchino Del Regno From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F6A42CA6 for ; Mon, 9 Jan 2023 11:42:04 +0000 (UTC) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id D04006602D66; Mon, 9 Jan 2023 11:42:00 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1673264523; bh=NbTiE9y32f/cs2nHXOmy1PoOgdwoRflnOn15GZ4u/iw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=Z0X0qcckEa6SfOYaI3kGzfc3IcKXqxNE5NMoYT135HVUsXZUbg7CzPlnMcAWCz2pP jZSPsmdYn/fEWg5jL4hxLLtZ7FwljfLNPK936Og/rMJurniFrUwoEP/w2i3nznEmXg BpfI6CPwILoq7iT6nSu4NuZq1XScbtmAfAuSIYe9MCgbVJKp4CvCuniBRYVGhADOtd GUmbh6hI8AiCyQ35YX6mOgHi5Kn5Fe0gzJjowdclrGKpbtlRUTozvabnqVTIJ/NcYi NpUN9RhS47uNNrpF7aD+y6UoQCcY+DQVXhgZwRD8C6tjv2B1QytBDdw+8RC3Tu2ZBh 1dGp4yMyORxUQ== Message-ID: <023519eb-0adb-3b08-71b9-afb92a6cceaf@collabora.com> Date: Mon, 9 Jan 2023 12:41:58 +0100 Precedence: bulk X-Mailing-List: chrome-platform@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [PATCH v9 3/9] drm/display: Add Type-C switch helpers Content-Language: en-US To: Pin-yen Lin , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , David Airlie , Daniel Vetter , Rob Herring , Krzysztof Kozlowski , Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J . Wysocki" , Prashant Malani , Benson Leung , Guenter Roeck Cc: Hsin-Yi Wang , dri-devel@lists.freedesktop.org, Marek Vasut , Stephen Boyd , Xin Ji , linux-acpi@vger.kernel.org, devicetree@vger.kernel.org, chrome-platform@lists.linux.dev, Thomas Zimmermann , Allen Chen , Javier Martinez Canillas , Lyude Paul , =?UTF-8?Q?N=c3=adcolas_F_=2e_R_=2e_A_=2e_Prado?= , linux-kernel@vger.kernel.org, Douglas Anderson , Imre Deak , Jani Nikula , Jim Cromie , Kees Cook , =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= References: <20230109084101.265664-1-treapking@chromium.org> <20230109084101.265664-4-treapking@chromium.org> From: AngeloGioacchino Del Regno In-Reply-To: <20230109084101.265664-4-treapking@chromium.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Il 09/01/23 09:40, Pin-yen Lin ha scritto: > Add helpers to register and unregister Type-C "switches" for bridges > capable of switching their output between two downstream devices. > > The helper registers USB Type-C mode switches when the "mode-switch" > and the "data-lanes" properties are available in Device Tree. > > Signed-off-by: Pin-yen Lin > > --- > > (no changes since v8) > > Changes in v8: > - Fixed the build issue when CONFIG_TYPEC=m > - Fixed some style issues > > Changes in v7: > - Extracted the common codes to a helper function > - New in v7 > > drivers/gpu/drm/display/drm_dp_helper.c | 132 ++++++++++++++++++++++++ > include/drm/display/drm_dp_helper.h | 16 +++ > 2 files changed, 148 insertions(+) > > diff --git a/drivers/gpu/drm/display/drm_dp_helper.c b/drivers/gpu/drm/display/drm_dp_helper.c > index 16565a0a5da6..fb9e23744c08 100644 > --- a/drivers/gpu/drm/display/drm_dp_helper.c > +++ b/drivers/gpu/drm/display/drm_dp_helper.c > @@ -30,11 +30,13 @@ > #include > #include > #include > +#include > #include > > #include > #include > #include > +#include > #include > #include > #include > @@ -3891,3 +3893,133 @@ int drm_panel_dp_aux_backlight(struct drm_panel *panel, struct drm_dp_aux *aux) > EXPORT_SYMBOL(drm_panel_dp_aux_backlight); > > #endif > + > +#if IS_REACHABLE(CONFIG_TYPEC) > +static int drm_dp_register_mode_switch(struct device *dev, struct device_node *node, > + struct drm_dp_typec_switch_desc *switch_desc, > + void *data, void *mux_set) > +{ > + struct drm_dp_typec_port_data *port_data; > + struct typec_mux_desc mux_desc = {}; > + char name[32]; > + u32 dp_lanes[2]; > + int ret, num_lanes, port_num = -1; > + > + num_lanes = drm_of_get_data_lanes_count(node, 0, 2); > + if (num_lanes <= 0) { > + dev_err(dev, "Error on getting data lanes count: %d\n", > + num_lanes); > + return num_lanes; > + } > + > + ret = of_property_read_u32_array(node, "data-lanes", dp_lanes, num_lanes); > + if (ret) { > + dev_err(dev, "Failed to read the data-lanes variable: %d\n", > + ret); > + return ret; > + } > + > + port_num = dp_lanes[0] / 2; > + > + port_data = &switch_desc->typec_ports[port_num]; > + port_data->data = data; > + mux_desc.fwnode = &node->fwnode; > + mux_desc.drvdata = port_data; > + snprintf(name, sizeof(name), "%s-%u", node->name, port_num); > + mux_desc.name = name; > + mux_desc.set = mux_set; > + > + port_data->typec_mux = typec_mux_register(dev, &mux_desc); > + if (IS_ERR(port_data->typec_mux)) { I would propose, instead... > + ret = PTR_ERR(port_data->typec_mux); > + dev_err(dev, "Mode switch register for port %d failed: %d\n", > + port_num, ret); return ret; > + } > + > + return ret; return 0; > +} > + ...but I don't have strong opinions, so regardless of that: Reviewed-by: AngeloGioacchino Del Regno