From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9DEF7C47DDC for ; Wed, 24 Jan 2024 01:15:24 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B118587A24; Wed, 24 Jan 2024 02:15:19 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=fail (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=rock-chips.com header.i=@rock-chips.com header.b="hW56UJFb"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B78BD8795B; Wed, 24 Jan 2024 02:15:16 +0100 (CET) Received: from mail-m12777.qiye.163.com (mail-m12777.qiye.163.com [115.236.127.77]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 30E9687A00 for ; Wed, 24 Jan 2024 02:15:12 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=rock-chips.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=kever.yang@rock-chips.com DKIM-Signature: a=rsa-sha256; b=hW56UJFbHkyR960HQ2pKQRy/Rf/OFsIcd853m5cjA8akUfO1U8Q34IsxgiZL19Zp3oj5iqK7E0NXFRBv/fl/03OZErItGt1hs1MkmxXhowdNHvNbv96OB8BlM05JlfO4qNVLDEs2q2E5m3kXgFeRhfUghiyIHmKuWi9fWJZSmzE=; s=default; c=relaxed/relaxed; d=rock-chips.com; v=1; bh=CCdADryrb4Z2tiBr1x29wpeSEk5glYfguaggOPTjUgc=; h=date:mime-version:subject:message-id:from; Received: from [172.16.12.93] (unknown [58.22.7.114]) by mail-m11877.qiye.163.com (Hmail) with ESMTPA id EC9DD400118; Wed, 24 Jan 2024 09:15:07 +0800 (CST) Message-ID: <028260b9-255d-4630-b793-1f065ffb1e7f@rock-chips.com> Date: Wed, 24 Jan 2024 09:15:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 01/20] Convert CONFIG_SPL_STACK to Kconfig Content-Language: en-US To: Tom Rini Cc: u-boot@lists.denx.de References: <20220529165521.912054-1-trini@konsulko.com> <20240123175847.GT3652023@bill-the-cat> From: Kever Yang In-Reply-To: <20240123175847.GT3652023@bill-the-cat> X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFDSUNOT01LS0k3V1ktWUFJV1kPCRoVCBIfWUFZQkNCT1YZHU5JSkIZTBoZQkJVEwETFh oSFyQUDg9ZV1kYEgtZQVlOQ1VJSVVMVUpKT1lXWRYaDxIVHRRZQVlPS0hVSk1PSU5IVUpLS1VKQk tLWQY+ X-HM-Tid: 0a8d390901692eb3kusnec9dd400118 X-HM-MType: 1 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6NTo6ISo4NDwfKgMvCQk4DE8S ExdPFFZVSlVKTEtNS05DQktDSENCVTMWGhIXVRAeDR4JVQIaFRw7CRQYEFYYExILCFUYFBZFWVdZ EgtZQVlOQ1VJSVVMVUpKT1lXWQgBWUFOTExONwY+ Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Content-Filtered-By: Mailman/MimeDel 2.1.39 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean Hi Tom, On 2024/1/24 01:58, Tom Rini wrote: > On Tue, Jan 23, 2024 at 11:53:18AM +0800, Kever Yang wrote: > >> Hi Tom, >> >> rk3036 only has small size internal sram, so it can only use very >> simple SPL which only including dram init, and no SPL_FRAMEWORK >> support. >> In this convert, the CONFIG_SPL_STACK is lost for this SoC, any >> suggestions on this kind of issue? > Does this work? > > diff --git a/common/spl/Kconfig b/common/spl/Kconfig > index e7b84fc1fa68..9deee0fdbea8 100644 > --- a/common/spl/Kconfig > +++ b/common/spl/Kconfig > @@ -372,7 +372,8 @@ config SPL_SHARES_INIT_SP_ADDR > > config SPL_STACK > hex "Initial stack pointer location" > - depends on (ARM || ARCH_JZ47XX || MICROBLAZE || RISCV) && SPL_FRAMEWORK > + depends on (ARM || ARCH_JZ47XX || MICROBLAZE || RISCV) && \ > + SPL_FRAMEWORK || ROCKCHIP_RK3036 This works with adding CONFIG_SPL_STACK in rk3036 board defconfig. > depends on !SPL_SHARES_INIT_SP_ADDR > default 0x946bb8 if ARCH_MX7 > default 0x93ffb8 if ARCH_MX6 && MX6_OCRAM_256KB > > You will have to update the ROCKCHIP_RK3036 platforms otherwise the > build will hang now. What do you mean to update the platform? The rk3036 case should be one of the available option for those "small"/low end SoCs has very limit size of internal dram, only need minimal SPL+ U-Boot,  and no requirement for ATF/OPTEEwhich will have to use TPL+SPL+U-Boot. The CONFIG_SPL_STACK is used in assemble init code, it doesn't need to depends on SPL_FRAMEWORK, isn't it? Thanks, - Kever >