From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752148AbdB1VJ6 (ORCPT ); Tue, 28 Feb 2017 16:09:58 -0500 Received: from mga06.intel.com ([134.134.136.31]:25495 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752100AbdB1VJq (ORCPT ); Tue, 28 Feb 2017 16:09:46 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,221,1484035200"; d="scan'208";a="1116756243" From: "Keller, Jacob E" To: "Neftin, Sasha" , Bernd Faust , "Kirsher, Jeffrey T" , "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [Intel-wired-lan] [PATCH] e1000e: fix timing for 82579 Gigabit Ethernet controller Thread-Topic: [Intel-wired-lan] [PATCH] e1000e: fix timing for 82579 Gigabit Ethernet controller Thread-Index: AQHSiIR+OONJKvpIn0yTGOsFp43K/qFw09wAgArA6ACAAYpWgIAB3ZAg Date: Tue, 28 Feb 2017 21:09:35 +0000 Message-ID: <02874ECE860811409154E81DA85FBB5857D7F361@ORSMSX115.amr.corp.intel.com> References: <1487270527-4549-1-git-send-email-berndfaust@gmail.com> <923e61cf-5f95-1662-2f4c-fc146359ab48@intel.com> <0a95307e-6683-b9fe-1957-be2b0a3c441e@intel.com> <3a432931-8b94-4808-78e0-bc459f510ab9@intel.com> In-Reply-To: <3a432931-8b94-4808-78e0-bc459f510ab9@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiZGIwMjFmM2UtOWYxZC00OGE2LWE0ZTgtNjExYjEwOGRlN2U3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IjFhOUFiVDJ4ano3ang4ZTFtQnhMU2xwbitha0loUURUTHRJaXIrRGlqWk09In0= x-ctpclassification: CTP_IC x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v1SLA3Pn016751 > -----Original Message----- > From: Intel-wired-lan [mailto:intel-wired-lan-bounces@lists.osuosl.org] On > Behalf Of Neftin, Sasha > Sent: Monday, February 27, 2017 12:40 AM > To: Bernd Faust ; Kirsher, Jeffrey T > ; intel-wired-lan@lists.osuosl.org; > netdev@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [Intel-wired-lan] [PATCH] e1000e: fix timing for 82579 Gigabit > Ethernet controller > > On 2/26/2017 11:08, Neftin, Sasha wrote: > > On 2/19/2017 14:55, Neftin, Sasha wrote: > >> On 2/16/2017 20:42, Bernd Faust wrote: > >>> After an upgrade to Linux kernel v4.x the hardware timestamps of the > >>> 82579 Gigabit Ethernet Controller are different than expected. > >>> The values that are being read are almost four times as big as before > >>> the kernel upgrade. > >>> > >>> The difference is that after the upgrade the driver sets the clock > >>> frequency to 25MHz, where before the upgrade it was set to 96MHz. Intel > >>> confirmed that the correct frequency for this network adapter is 96MHz. > >>> > >>> Signed-off-by: Bernd Faust > >>> --- > >>> drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++ > >>> 1 file changed, 6 insertions(+) > >>> > >>> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c > >>> b/drivers/net/ethernet/intel/e1000e/netdev.c > >>> index 7017281..8b7113d 100644 > >>> --- a/drivers/net/ethernet/intel/e1000e/netdev.c > >>> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c > >>> @@ -3511,6 +3511,12 @@ s32 e1000e_get_base_timinca(struct > >>> e1000_adapter *adapter, u32 *timinca) > >>> > >>> switch (hw->mac.type) { > >>> case e1000_pch2lan: > >>> + /* Stable 96MHz frequency */ > >>> + incperiod = INCPERIOD_96MHz; > >>> + incvalue = INCVALUE_96MHz; > >>> + shift = INCVALUE_SHIFT_96MHz; > >>> + adapter->cc.shift = shift + INCPERIOD_SHIFT_96MHz; > >>> + break; > >>> case e1000_pch_lpt: > >>> if (er32(TSYNCRXCTL) & E1000_TSYNCRXCTL_SYSCFI) { > >>> /* Stable 96MHz frequency */ > >>> -- > >>> 2.7.4 > >>> _______________________________________________ > >>> Intel-wired-lan mailing list > >>> Intel-wired-lan@lists.osuosl.org > >>> http://lists.osuosl.org/mailman/listinfo/intel-wired-lan > >> > >> Hello, > >> > >> e1000_pch2lan mac type corresponds to 82579LM and 82579V network > >> adapters. System clock frequency indication (SYSCFI) for these > >> devices supports both 25MHz and 96MHz frequency. By default > >> TSYNCRXCTL.SYSCFI is set to 1 and that means 96MHz frequency is picked. > >> > >> It is better to keep the current implementation as it covers all > >> options. > >> > >> Thanks, > >> > >> Sasha > >> > > Hello, > > > > During last couple of weeks I saw few complaints from community on > > same timing problem with 82579. I will double check clock definition > > with HW architecture. > > > > Sasha > > > I've double checked - 82579 support 96MHz frequency only. So, let's > accept this suggestion to upstream. > > Ack. > This resolves also a complaint from someone on the LinuxPTP development mailing list. ACK. Thanks, Jake From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keller, Jacob E Date: Tue, 28 Feb 2017 21:09:35 +0000 Subject: [Intel-wired-lan] [PATCH] e1000e: fix timing for 82579 Gigabit Ethernet controller In-Reply-To: <3a432931-8b94-4808-78e0-bc459f510ab9@intel.com> References: <1487270527-4549-1-git-send-email-berndfaust@gmail.com> <923e61cf-5f95-1662-2f4c-fc146359ab48@intel.com> <0a95307e-6683-b9fe-1957-be2b0a3c441e@intel.com> <3a432931-8b94-4808-78e0-bc459f510ab9@intel.com> Message-ID: <02874ECE860811409154E81DA85FBB5857D7F361@ORSMSX115.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: > -----Original Message----- > From: Intel-wired-lan [mailto:intel-wired-lan-bounces at lists.osuosl.org] On > Behalf Of Neftin, Sasha > Sent: Monday, February 27, 2017 12:40 AM > To: Bernd Faust ; Kirsher, Jeffrey T > ; intel-wired-lan at lists.osuosl.org; > netdev at vger.kernel.org; linux-kernel at vger.kernel.org > Subject: Re: [Intel-wired-lan] [PATCH] e1000e: fix timing for 82579 Gigabit > Ethernet controller > > On 2/26/2017 11:08, Neftin, Sasha wrote: > > On 2/19/2017 14:55, Neftin, Sasha wrote: > >> On 2/16/2017 20:42, Bernd Faust wrote: > >>> After an upgrade to Linux kernel v4.x the hardware timestamps of the > >>> 82579 Gigabit Ethernet Controller are different than expected. > >>> The values that are being read are almost four times as big as before > >>> the kernel upgrade. > >>> > >>> The difference is that after the upgrade the driver sets the clock > >>> frequency to 25MHz, where before the upgrade it was set to 96MHz. Intel > >>> confirmed that the correct frequency for this network adapter is 96MHz. > >>> > >>> Signed-off-by: Bernd Faust > >>> --- > >>> drivers/net/ethernet/intel/e1000e/netdev.c | 6 ++++++ > >>> 1 file changed, 6 insertions(+) > >>> > >>> diff --git a/drivers/net/ethernet/intel/e1000e/netdev.c > >>> b/drivers/net/ethernet/intel/e1000e/netdev.c > >>> index 7017281..8b7113d 100644 > >>> --- a/drivers/net/ethernet/intel/e1000e/netdev.c > >>> +++ b/drivers/net/ethernet/intel/e1000e/netdev.c > >>> @@ -3511,6 +3511,12 @@ s32 e1000e_get_base_timinca(struct > >>> e1000_adapter *adapter, u32 *timinca) > >>> > >>> switch (hw->mac.type) { > >>> case e1000_pch2lan: > >>> + /* Stable 96MHz frequency */ > >>> + incperiod = INCPERIOD_96MHz; > >>> + incvalue = INCVALUE_96MHz; > >>> + shift = INCVALUE_SHIFT_96MHz; > >>> + adapter->cc.shift = shift + INCPERIOD_SHIFT_96MHz; > >>> + break; > >>> case e1000_pch_lpt: > >>> if (er32(TSYNCRXCTL) & E1000_TSYNCRXCTL_SYSCFI) { > >>> /* Stable 96MHz frequency */ > >>> -- > >>> 2.7.4 > >>> _______________________________________________ > >>> Intel-wired-lan mailing list > >>> Intel-wired-lan at lists.osuosl.org > >>> http://lists.osuosl.org/mailman/listinfo/intel-wired-lan > >> > >> Hello, > >> > >> e1000_pch2lan mac type corresponds to 82579LM and 82579V network > >> adapters. System clock frequency indication (SYSCFI) for these > >> devices supports both 25MHz and 96MHz frequency. By default > >> TSYNCRXCTL.SYSCFI is set to 1 and that means 96MHz frequency is picked. > >> > >> It is better to keep the current implementation as it covers all > >> options. > >> > >> Thanks, > >> > >> Sasha > >> > > Hello, > > > > During last couple of weeks I saw few complaints from community on > > same timing problem with 82579. I will double check clock definition > > with HW architecture. > > > > Sasha > > > I've double checked - 82579 support 96MHz frequency only. So, let's > accept this suggestion to upstream. > > Ack. > This resolves also a complaint from someone on the LinuxPTP development mailing list. ACK. Thanks, Jake