From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Keller, Jacob E" Subject: RE: [Intel-wired-lan] Issue with driver i40e stat strings count mismatch Date: Tue, 31 Jul 2018 18:29:32 +0000 Message-ID: <02874ECE860811409154E81DA85FBB5884C2A217@ORSMSX115.amr.corp.intel.com> References: <20180710131721.657e55a5@redhat.com> <64be8e6a-c285-2864-fd91-356eba645acd@kpanic.de> <20180731162835.628ebb62@redhat.com> <9BBC4E0CF881AA4299206E2E1412B6267C5C1128@ORSMSX102.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "netdev@vger.kernel.org" , intel-wired-lan , "Topel, Bjorn" To: "Wyborny, Carolyn" , Jesper Dangaard Brouer , Stefan Assmann Return-path: Received: from mga14.intel.com ([192.55.52.115]:16139 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729680AbeGaULH (ORCPT ); Tue, 31 Jul 2018 16:11:07 -0400 In-Reply-To: <9BBC4E0CF881AA4299206E2E1412B6267C5C1128@ORSMSX102.amr.corp.intel.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: DQoNCj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogV3lib3JueSwgQ2Fyb2x5 bg0KPiBTZW50OiBUdWVzZGF5LCBKdWx5IDMxLCAyMDE4IDg6NTMgQU0NCj4gVG86IEplc3BlciBE YW5nYWFyZCBCcm91ZXIgPGJyb3VlckByZWRoYXQuY29tPjsgU3RlZmFuIEFzc21hbm4NCj4gPHNh c3NtYW5uQGtwYW5pYy5kZT47IEtlbGxlciwgSmFjb2IgRSA8amFjb2IuZS5rZWxsZXJAaW50ZWwu Y29tPg0KPiBDYzogbmV0ZGV2QHZnZXIua2VybmVsLm9yZzsgaW50ZWwtd2lyZWQtbGFuIDxpbnRl bC13aXJlZC1sYW5AbGlzdHMub3N1b3NsLm9yZz47DQo+IFRvcGVsLCBCam9ybiA8Ympvcm4udG9w ZWxAaW50ZWwuY29tPjsgS2VsbGVyLCBKYWNvYiBFDQo+IDxqYWNvYi5lLmtlbGxlckBpbnRlbC5j b20+DQo+IFN1YmplY3Q6IFJFOiBbSW50ZWwtd2lyZWQtbGFuXSBJc3N1ZSB3aXRoIGRyaXZlciBp NDBlIHN0YXQgc3RyaW5ncyBjb3VudCBtaXNtYXRjaA0KPiANCj4gPiAtLS0tLU9yaWdpbmFsIE1l c3NhZ2UtLS0tLQ0KPiA+IEZyb206IEludGVsLXdpcmVkLWxhbiBbbWFpbHRvOmludGVsLXdpcmVk LWxhbi1ib3VuY2VzQG9zdW9zbC5vcmddIE9uDQo+ID4gQmVoYWxmIE9mIEplc3BlciBEYW5nYWFy ZCBCcm91ZXINCj4gPiBTZW50OiBUdWVzZGF5LCBKdWx5IDMxLCAyMDE4IDc6MjkgQU0NCj4gPiBU bzogU3RlZmFuIEFzc21hbm4gPHNhc3NtYW5uQGtwYW5pYy5kZT47IEtlbGxlciwgSmFjb2IgRQ0K PiA+IDxqYWNvYi5lLmtlbGxlckBpbnRlbC5jb20+DQo+ID4gQ2M6IG5ldGRldkB2Z2VyLmtlcm5l bC5vcmc7IGludGVsLXdpcmVkLWxhbiA8aW50ZWwtd2lyZWQtDQo+ID4gbGFuQGxpc3RzLm9zdW9z bC5vcmc+OyBicm91ZXJAcmVkaGF0LmNvbTsgVG9wZWwsIEJqb3JuDQo+ID4gPGJqb3JuLnRvcGVs QGludGVsLmNvbT4NCj4gPiBTdWJqZWN0OiBSZTogW0ludGVsLXdpcmVkLWxhbl0gSXNzdWUgd2l0 aCBkcml2ZXIgaTQwZSBzdGF0IHN0cmluZ3MgY291bnQNCj4gPiBtaXNtYXRjaA0KPiA+DQo+ID4N Cj4gPiBPbiBUdWUsIDMxIEp1bCAyMDE4IDA5OjA1OjQwICswMjAwIFN0ZWZhbiBBc3NtYW5uDQo+ ID4gPHNhc3NtYW5uQGtwYW5pYy5kZT4gd3JvdGU6DQo+ID4NCj4gPiA+IEZyb206IFN0ZWZhbiBB c3NtYW5uIDxzYXNzbWFubkBrcGFuaWMuZGU+DQo+ID4gPiBUbzogSmVzcGVyIERhbmdhYXJkIEJy b3VlciA8YnJvdWVyQHJlZGhhdC5jb20+LCAgSmVmZiBLaXJzaGVyDQo+ID4gPGplZmZyZXkudC5r aXJzaGVyQGludGVsLmNvbT4NCj4gPiA+IENjOiBCasO2cm4gVMO2cGVsIDxiam9ybi50b3BlbEBp bnRlbC5jb20+LA0KPiA+ICJhbGV4YW5kZXIuaC5kdXlja0BpbnRlbC5jb20iIDxhbGV4YW5kZXIu aC5kdXlja0BpbnRlbC5jb20+LCAgaW50ZWwtDQo+ID4gd2lyZWQtbGFuIDxpbnRlbC13aXJlZC1s YW5AbGlzdHMub3N1b3NsLm9yZz4sICAibmV0ZGV2QHZnZXIua2VybmVsLm9yZyINCj4gPiA8bmV0 ZGV2QHZnZXIua2VybmVsLm9yZz4NCj4gPiA+IFN1YmplY3Q6IFJlOiBJc3N1ZSB3aXRoIGRyaXZl ciBpNDBlIHN0YXQgc3RyaW5ncyBjb3VudCBtaXNtYXRjaA0KPiA+ID4gRGF0ZTogVHVlLCAzMSBK dWwgMjAxOCAwOTowNTo0MCArMDIwMA0KPiA+ID4gVXNlci1BZ2VudDogTW96aWxsYS81LjAgKFgx MTsgTGludXggeDg2XzY0OyBydjo1Mi4wKSBHZWNrby8yMDEwMDEwMQ0KPiA+ID4gIFRodW5kZXJi aXJkLzUyLjkuMQ0KPiA+ID4gTWVzc2FnZS1JRDogPDY0YmU4ZTZhLWMyODUtMjg2NC1mZDkxLTM1 NmViYTY0NWFjZEBrcGFuaWMuZGU+DQo+ID4gPg0KPiA+ID4gT24gMTAuMDcuMjAxOCAxMzoxNywg SmVzcGVyIERhbmdhYXJkIEJyb3VlciB3cm90ZToNCj4gPiA+ID4gSGkgSW50ZWwtZm9rZXMsDQo+ ID4gPiA+DQo+ID4gPiA+IFlvdXIgaTQwZSBkcml2ZXIgaGF2ZSBpc3N1ZXMgd2l0aCBpdCdzIGV0 aHRvb2wgc3RhdHMuICBBIHdhcm5pbmcNCj4gPiA+ID4gdHJpZ2dlcnMgYXQgZHJpdmVycy9uZXQv ZXRoZXJuZXQvaW50ZWwvaTQwZS9pNDBlX2V0aHRvb2wuYyBsaW5lIDE5MDcNCj4gPiA+ID4gKHNl ZSBzcGxhc2ggYmVsb3cpIGluIGZ1bmMgaTQwZV9nZXRfc3RhdF9zdHJpbmdzKCkuDQo+ID4gPg0K PiA+ID4gSGkgSmVzcGVyLA0KPiA+ID4NCj4gPiA+IEkgcmFuIGludG8gdGhlIHNhbWUgaXNzdWUu IEhlcmUncyBteSBwcm9wb3NlZCBmaXguDQo+ID4NCj4gPiBUaGFua3MgZm9yIGZvbGxvd2luZyB1 cCBTdGVmYW4gOi0pDQo+ID4NCj4gPiBJJ20gaG9waW5nIHNvbWUgSW50ZWwgcGVvcGxlIHdpbGwg bG9vayBhdCBldmFsdWF0aW5nIHRoaXMgZml4PyAuLi4NCj4gPg0KPiBUaGFua3MsIHdlIGhhdmUg YSBwYXRjaCBpbiBwcm9jZXNzIGZvciB0aGlzIGZpeCBhbmQgb3RoZXIgcmVsYXRlZCBvbmVzIGZy b20gSmFrZQ0KPiBLZWxsZXIuICBXZSdsbCBleHBlZGl0ZSBpdC4NCj4gDQo+IENhcm9seW4NCj4g DQo+IENhcm9seW4gV3lib3JueQ0KPiBMaW51eCBEZXZlbG9wbWVudA0KPiBOZXR3b3JraW5nIERp dmlzaW9uDQo+IEludGVsIENvcnBvcmF0aW9uDQo+IA0KPiANCg0KWWVhIEkgZm91bmQgdGlocyBp c3N1ZSBhIHdoaWxlIGFnbyBhbmQgd2UgaGFkIGEgcGF0Y2ggaW50ZXJuYWxseS4gSSBzdXNwZWN0 IGl0IGp1c3QgZ290IGxvc3QgaW4gYSBzaHVmZmxlIGVhcmxpZXINCg0KSSB0aGluayB3ZSBoYXZl IGFuIGVxdWl2YWxlbnQgcGF0Y2gsIGJ1dCBJIGRvbid0IGNhcmUgd2hpY2ggZ2V0cyBhcHBsaWVk Lg0KDQpUaGFua3MsDQpKYWtlDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: Keller, Jacob E Date: Tue, 31 Jul 2018 18:29:32 +0000 Subject: [Intel-wired-lan] Issue with driver i40e stat strings count mismatch In-Reply-To: <9BBC4E0CF881AA4299206E2E1412B6267C5C1128@ORSMSX102.amr.corp.intel.com> References: <20180710131721.657e55a5@redhat.com> <64be8e6a-c285-2864-fd91-356eba645acd@kpanic.de> <20180731162835.628ebb62@redhat.com> <9BBC4E0CF881AA4299206E2E1412B6267C5C1128@ORSMSX102.amr.corp.intel.com> Message-ID: <02874ECE860811409154E81DA85FBB5884C2A217@ORSMSX115.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: intel-wired-lan@osuosl.org List-ID: > -----Original Message----- > From: Wyborny, Carolyn > Sent: Tuesday, July 31, 2018 8:53 AM > To: Jesper Dangaard Brouer ; Stefan Assmann > ; Keller, Jacob E > Cc: netdev at vger.kernel.org; intel-wired-lan ; > Topel, Bjorn ; Keller, Jacob E > > Subject: RE: [Intel-wired-lan] Issue with driver i40e stat strings count mismatch > > > -----Original Message----- > > From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On > > Behalf Of Jesper Dangaard Brouer > > Sent: Tuesday, July 31, 2018 7:29 AM > > To: Stefan Assmann ; Keller, Jacob E > > > > Cc: netdev at vger.kernel.org; intel-wired-lan > lan at lists.osuosl.org>; brouer at redhat.com; Topel, Bjorn > > > > Subject: Re: [Intel-wired-lan] Issue with driver i40e stat strings count > > mismatch > > > > > > On Tue, 31 Jul 2018 09:05:40 +0200 Stefan Assmann > > wrote: > > > > > From: Stefan Assmann > > > To: Jesper Dangaard Brouer , Jeff Kirsher > > > > > Cc: Bj?rn T?pel , > > "alexander.h.duyck at intel.com" , intel- > > wired-lan , "netdev at vger.kernel.org" > > > > > Subject: Re: Issue with driver i40e stat strings count mismatch > > > Date: Tue, 31 Jul 2018 09:05:40 +0200 > > > User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 > > > Thunderbird/52.9.1 > > > Message-ID: <64be8e6a-c285-2864-fd91-356eba645acd@kpanic.de> > > > > > > On 10.07.2018 13:17, Jesper Dangaard Brouer wrote: > > > > Hi Intel-fokes, > > > > > > > > Your i40e driver have issues with it's ethtool stats. A warning > > > > triggers at drivers/net/ethernet/intel/i40e/i40e_ethtool.c line 1907 > > > > (see splash below) in func i40e_get_stat_strings(). > > > > > > Hi Jesper, > > > > > > I ran into the same issue. Here's my proposed fix. > > > > Thanks for following up Stefan :-) > > > > I'm hoping some Intel people will look at evaluating this fix? ... > > > Thanks, we have a patch in process for this fix and other related ones from Jake > Keller. We'll expedite it. > > Carolyn > > Carolyn Wyborny > Linux Development > Networking Division > Intel Corporation > > Yea I found tihs issue a while ago and we had a patch internally. I suspect it just got lost in a shuffle earlier I think we have an equivalent patch, but I don't care which gets applied. Thanks, Jake