From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F94DC432C1 for ; Tue, 24 Sep 2019 19:23:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E3447207FD for ; Tue, 24 Sep 2019 19:23:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2501951AbfIXTX2 convert rfc822-to-8bit (ORCPT ); Tue, 24 Sep 2019 15:23:28 -0400 Received: from mga12.intel.com ([192.55.52.136]:11584 "EHLO mga12.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2407325AbfIXTX1 (ORCPT ); Tue, 24 Sep 2019 15:23:27 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Sep 2019 12:23:27 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,545,1559545200"; d="scan'208";a="201006599" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by orsmga002.jf.intel.com with ESMTP; 24 Sep 2019 12:23:26 -0700 Received: from orsmsx121.amr.corp.intel.com ([169.254.10.190]) by ORSMSX102.amr.corp.intel.com ([169.254.3.63]) with mapi id 14.03.0439.000; Tue, 24 Sep 2019 12:23:26 -0700 From: "Keller, Jacob E" To: Felipe Balbi , Richard Cochran CC: "Hall, Christopher S" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v4 2/2] PTP: add support for one-shot output Thread-Topic: [PATCH v4 2/2] PTP: add support for one-shot output Thread-Index: AQHVaGiJVAygg13ZgEaRBcEK9JTjfKc7SaLQ Date: Tue, 24 Sep 2019 19:23:26 +0000 Message-ID: <02874ECE860811409154E81DA85FBB58968D24E2@ORSMSX121.amr.corp.intel.com> References: <20190911061622.774006-1-felipe.balbi@linux.intel.com> <20190911061622.774006-2-felipe.balbi@linux.intel.com> In-Reply-To: <20190911061622.774006-2-felipe.balbi@linux.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzBiMDY1MDEtNGJhZi00NDg3LThmN2MtOTMzZGViYTZhYmZhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUGJZdkpiMHJIU3lXTmx5dTZSRlByRHVsMzRja1RLWU1mNXhvQnROcnd0V2hvajBcL1pxN0NTQnlTeENoYkt2UGQifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.140] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > -----Original Message----- > From: netdev-owner@vger.kernel.org [mailto:netdev-owner@vger.kernel.org] On > Behalf Of Felipe Balbi > Sent: Tuesday, September 10, 2019 11:16 PM > To: Richard Cochran > Cc: Hall, Christopher S ; netdev@vger.kernel.org; > linux-kernel@vger.kernel.org; Felipe Balbi > Subject: [PATCH v4 2/2] PTP: add support for one-shot output > > Some controllers allow for a one-shot output pulse, in contrast to > periodic output. Now that we have extensible versions of our IOCTLs, we > can finally make use of the 'flags' field to pass a bit telling driver > that if we want one-shot pulse output. > > Signed-off-by: Felipe Balbi > --- > > Changes since v3: > - Remove bogus bitwise negation > > Changes since v2: > - Add _PEROUT_ to bit macro > > Changes since v1: > - remove comment from .flags field > > include/uapi/linux/ptp_clock.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/include/uapi/linux/ptp_clock.h b/include/uapi/linux/ptp_clock.h > index 9a0af3511b68..f16301015949 100644 > --- a/include/uapi/linux/ptp_clock.h > +++ b/include/uapi/linux/ptp_clock.h > @@ -38,8 +38,8 @@ > /* > * Bits of the ptp_perout_request.flags field: > */ > -#define PTP_PEROUT_VALID_FLAGS (0) > - > +#define PTP_PEROUT_ONE_SHOT (1<<0) > +#define PTP_PEROUT_VALID_FLAGS (PTP_PEROUT_ONE_SHOT) > /* > * struct ptp_clock_time - represents a time value > * > @@ -77,7 +77,7 @@ struct ptp_perout_request { > struct ptp_clock_time start; /* Absolute start time. */ > struct ptp_clock_time period; /* Desired period, zero means disable. */ > unsigned int index; /* Which channel to configure. */ > - unsigned int flags; /* Reserved for future use. */ > + unsigned int flags; > unsigned int rsv[4]; /* Reserved for future use. */ > }; > > -- > 2.23.0 Hi Felipe, Do you have any examples for how you envision using this? I don't see any drivers or other code on the list for doing so. Additionally, it seems weird because we do not have support for specifying the pulse width. I guess you leave that up to driver choice? Thanks, Jake