From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Souza, Jose" Subject: Re: [PATCH 4/9] drm/i915/ehl: Add dpll mgr Date: Thu, 14 Mar 2019 21:38:14 +0000 Message-ID: <02875c3294dbc9174203c99bad32e07f4aedec6b.camel@intel.com> References: <20190313211144.4842-1-rodrigo.vivi@intel.com> <20190313211144.4842-4-rodrigo.vivi@intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0674893049==" Return-path: Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id B0AF06E0B5 for ; Thu, 14 Mar 2019 21:38:17 +0000 (UTC) In-Reply-To: <20190313211144.4842-4-rodrigo.vivi@intel.com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: "Vivi, Rodrigo" , "intel-gfx@lists.freedesktop.org" Cc: "De Marchi, Lucas" List-Id: intel-gfx@lists.freedesktop.org --===============0674893049== Content-Language: en-US Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="=-V0ZrEq4tIBcgds3T6Ab/" --=-V0ZrEq4tIBcgds3T6Ab/ Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2019-03-13 at 14:11 -0700, Rodrigo Vivi wrote: > From: Lucas De Marchi >=20 > Elkhart Lake has a different set of PLLs as compared to Ice Lake, > although programming them is very similar. >=20 Reviewed-by: Jos=C3=A9 Roberto de Souza > Signed-off-by: Lucas De Marchi > Signed-off-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/intel_dpll_mgr.c | 16 +++++++++++++++- > 1 file changed, 15 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/gpu/drm/i915/intel_dpll_mgr.c > b/drivers/gpu/drm/i915/intel_dpll_mgr.c > index b3fb221c2532..a9feb119c19f 100644 > --- a/drivers/gpu/drm/i915/intel_dpll_mgr.c > +++ b/drivers/gpu/drm/i915/intel_dpll_mgr.c > @@ -3246,6 +3246,18 @@ static const struct intel_dpll_mgr icl_pll_mgr > =3D { > .dump_hw_state =3D icl_dump_hw_state, > }; > =20 > +static const struct dpll_info ehl_plls[] =3D { > + { "DPLL 0", &icl_pll_funcs, DPLL_ID_ICL_DPLL0, 0 }, > + { "DPLL 1", &icl_pll_funcs, DPLL_ID_ICL_DPLL1, 0 }, > + { }, > +}; > + > +static const struct intel_dpll_mgr ehl_pll_mgr =3D { > + .dpll_info =3D ehl_plls, > + .get_dpll =3D icl_get_dpll, > + .dump_hw_state =3D icl_dump_hw_state, > +}; > + > /** > * intel_shared_dpll_init - Initialize shared DPLLs > * @dev: drm device > @@ -3259,7 +3271,9 @@ void intel_shared_dpll_init(struct drm_device > *dev) > const struct dpll_info *dpll_info; > int i; > =20 > - if (INTEL_GEN(dev_priv) >=3D 11) > + if (IS_ELKHARTLAKE(dev_priv)) > + dpll_mgr =3D &ehl_pll_mgr; > + else if (INTEL_GEN(dev_priv) >=3D 11) > dpll_mgr =3D &icl_pll_mgr; > else if (IS_CANNONLAKE(dev_priv)) > dpll_mgr =3D &cnl_pll_mgr; --=-V0ZrEq4tIBcgds3T6Ab/ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEVNG051EijGa0MiaQVenbO/mOWkkFAlyKycQACgkQVenbO/mO WkmW+Af/WiFe2lpI/sUS923FgJKSr5kD/lybRoT8tA3TcCGu4mYBOQL2k+HWPO6U kcaAQwVLwBf51+DkCppgQBBVIemvdRE/w1bH+EdutjkwKEDPVbQxHJdg2gNnCgfM bnN4io0yGMzCWFFNcmPfuZejcBdeXWRQuY4nZyw50uebUttCYC1FKcAcRSumZt56 dnuSgYPeFaS9z2H/9KFbxIiSK4ceoPyZddbwouSJGyQKH3LKqv4oRhl688gY5ozf f91Faf5xhFcOt5g6amfgMSnLDK1r9E8Y7aZPYqKUg9PIM9T8X633OcLQRxkQJdfH 2CU93qb2giROk2DwSOkAsO7LJoH/OQ== =5eNW -----END PGP SIGNATURE----- --=-V0ZrEq4tIBcgds3T6Ab/-- --===============0674893049== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4 --===============0674893049==--