From mboxrd@z Thu Jan 1 00:00:00 1970 From: john.johansen@canonical.com (John Johansen) Date: Fri, 14 Sep 2018 11:23:36 -0700 Subject: [PATCH 10/10] LSM: Blob sharing support for S.A.R.A and LandLock In-Reply-To: References: <99cb1ae7-8881-eb9a-a8cb-a787abe454e1@schaufler-ca.com> <5b983bba-049c-795a-3354-a2e8ab33cecf@schaufler-ca.com> Message-ID: <0288a057-8f38-665e-a1ac-34330d67412b@canonical.com> To: linux-security-module@vger.kernel.org List-Id: linux-security-module.vger.kernel.org On 09/14/2018 11:18 AM, James Morris wrote: > On Thu, 13 Sep 2018, Casey Schaufler wrote: > >> On 9/13/2018 4:57 PM, Kees Cook wrote: >>> On Thu, Sep 13, 2018 at 4:51 PM, Casey Schaufler wrote: >>>> On 9/13/2018 4:06 PM, Kees Cook wrote: >>>>> - what order should any stacking happen? Makefile? security=? >>>> Makefile by default. >>> Okay, if ordering is by Makefile and everyone dislikes my >>> $lsm.enabled=0/1 thing, then these mean the same thing: >>> >>> security=selinux,tomoyo >>> security=tomoyo,selinux >>> >>> i.e. order of security= is _ignored_ in favor of the Makefile ordering. >> >> No, I think that the two lines above should have a different >> execution order. If we really need to specify multiple modules >> at boot time that is what makes the most sense. > > Agreed. > > +1 partly because if order is ever going to be important, it needs to be done now. It easy to loosen restrictions (ordering) in the future but will be problematic to add it in. From mboxrd@z Thu Jan 1 00:00:00 1970 To: James Morris , Casey Schaufler Cc: Kees Cook , Paul Moore , linux-security-module , LKML , SE Linux , Tetsuo Handa , Stephen Smalley , "linux-fsdevel@vger.kernel.org" , Alexey Dobriyan , "Schaufler, Casey" References: <99cb1ae7-8881-eb9a-a8cb-a787abe454e1@schaufler-ca.com> <5b983bba-049c-795a-3354-a2e8ab33cecf@schaufler-ca.com> From: John Johansen Message-ID: <0288a057-8f38-665e-a1ac-34330d67412b@canonical.com> Date: Fri, 14 Sep 2018 11:23:36 -0700 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Subject: Re: [PATCH 10/10] LSM: Blob sharing support for S.A.R.A and LandLock List-Id: "Security-Enhanced Linux \(SELinux\) mailing list" List-Post: List-Help: On 09/14/2018 11:18 AM, James Morris wrote: > On Thu, 13 Sep 2018, Casey Schaufler wrote: > >> On 9/13/2018 4:57 PM, Kees Cook wrote: >>> On Thu, Sep 13, 2018 at 4:51 PM, Casey Schaufler wrote: >>>> On 9/13/2018 4:06 PM, Kees Cook wrote: >>>>> - what order should any stacking happen? Makefile? security=? >>>> Makefile by default. >>> Okay, if ordering is by Makefile and everyone dislikes my >>> $lsm.enabled=0/1 thing, then these mean the same thing: >>> >>> security=selinux,tomoyo >>> security=tomoyo,selinux >>> >>> i.e. order of security= is _ignored_ in favor of the Makefile ordering. >> >> No, I think that the two lines above should have a different >> execution order. If we really need to specify multiple modules >> at boot time that is what makes the most sense. > > Agreed. > > +1 partly because if order is ever going to be important, it needs to be done now. It easy to loosen restrictions (ordering) in the future but will be problematic to add it in.