From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46B1EC43460 for ; Tue, 18 May 2021 14:35:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 22A49611CC for ; Tue, 18 May 2021 14:35:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233070AbhEROgX (ORCPT ); Tue, 18 May 2021 10:36:23 -0400 Received: from mx07-00178001.pphosted.com ([185.132.182.106]:34739 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232245AbhEROgV (ORCPT ); Tue, 18 May 2021 10:36:21 -0400 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14IEWv7u024660; Tue, 18 May 2021 16:34:54 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=IoZWo4g6WYmn4ZvcOIUxvySqtfs8j1f0MrKnheiGUHs=; b=DWsG2/8/3Qz8EOE6fD0Ev8WmmPUOpuL+EpzqNukA0oUpU0lEULgvEElHjsHFOFbVcvhP tUn4l/mQqYuLQW6Z8PCRcj7hVjryeaBDNhMwJbBX/kan5rFoVnTs98/c99WLsOMac4rl WLIDONkX7FU5nrtYQw+Kp7ZLtjfF87D1GFq6yf1OQuNACqDWJgsxkX1w5aiQTrFUiMOu n1GpjTi8F1S/XK4ROkVDUOFukZk4W3TjAbkWiRKY6OgbbVP1cMRnpIM/c1rcsXjkIZWa O60Pz0hxQ06k1DLcaITk8ZtZsrYW2BEMy4nKOoSVP1oUFOFfPXgsILqRPuwLVJCK89kj qw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 38maunsss0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 May 2021 16:34:54 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id DEBA310002A; Tue, 18 May 2021 16:34:53 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id C3E0822AED2; Tue, 18 May 2021 16:34:53 +0200 (CEST) Received: from lmecxl0573.lme.st.com (10.75.127.46) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 18 May 2021 16:34:52 +0200 Subject: Re: [PATCH v4 2/3] mtd: spinand: use the spi-mem poll status APIs To: Boris Brezillon CC: Mark Brown , Miquel Raynal , Vignesh Raghavendra , , Alexandre Torgue , , , , , References: <20210518134332.17826-1-patrice.chotard@foss.st.com> <20210518134332.17826-3-patrice.chotard@foss.st.com> <20210518161834.6860c310@collabora.com> From: Patrice CHOTARD Message-ID: <028d3c29-effe-1604-8e38-b7fb0783c4a2@foss.st.com> Date: Tue, 18 May 2021 16:34:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210518161834.6860c310@collabora.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.75.127.46] X-ClientProxiedBy: SFHDAG1NODE1.st.com (10.75.127.1) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391,18.0.761 definitions=2021-05-18_07:2021-05-18,2021-05-18 signatures=0 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 5/18/21 4:18 PM, Boris Brezillon wrote: > On Tue, 18 May 2021 15:43:31 +0200 > wrote: > >> From: Patrice Chotard >> >> Make use of spi-mem poll status APIs to let advanced controllers >> optimize wait operations. >> This should also fix the high CPU usage for system that don't have >> a dedicated STATUS poll block logic. >> >> Signed-off-by: Patrice Chotard >> Signed-off-by: Christophe Kerello >> --- >> Changes in v4: >> - Update commit message. >> - Add comment which explains how delays has been calculated. >> - Rename SPINAND_STATUS_TIMEOUT_MS to SPINAND_WAITRDY_TIMEOUT_MS. >> >> Changes in v3: >> - Add initial_delay_us and polling_delay_us parameters to spinand_wait() >> - Add SPINAND_READ/WRITE/ERASE/RESET_INITIAL_DELAY_US and >> SPINAND_READ/WRITE/ERASE/RESET_POLL_DELAY_US defines. >> >> Changes in v2: >> - non-offload case is now managed by spi_mem_poll_status() >> >> drivers/mtd/nand/spi/core.c | 45 ++++++++++++++++++++++++++----------- >> include/linux/mtd/spinand.h | 22 ++++++++++++++++++ >> 2 files changed, 54 insertions(+), 13 deletions(-) >> >> diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c >> index 17f63f95f4a2..3131fae0c715 100644 >> --- a/drivers/mtd/nand/spi/core.c >> +++ b/drivers/mtd/nand/spi/core.c >> @@ -473,20 +473,26 @@ static int spinand_erase_op(struct spinand_device *spinand, >> return spi_mem_exec_op(spinand->spimem, &op); >> } >> >> -static int spinand_wait(struct spinand_device *spinand, u8 *s) >> +static int spinand_wait(struct spinand_device *spinand, >> + unsigned long initial_delay_us, >> + unsigned long poll_delay_us, >> + u8 *s) >> { >> - unsigned long timeo = jiffies + msecs_to_jiffies(400); >> + struct spi_mem_op op = SPINAND_GET_FEATURE_OP(REG_STATUS, >> + spinand->scratchbuf); >> u8 status; >> int ret; >> >> - do { >> - ret = spinand_read_status(spinand, &status); >> - if (ret) >> - return ret; >> + ret = spi_mem_poll_status(spinand->spimem, &op, STATUS_BUSY, 0, >> + initial_delay_us, >> + poll_delay_us, >> + SPINAND_WAITRDY_TIMEOUT_MS); >> + if (ret) >> + return ret; >> >> - if (!(status & STATUS_BUSY)) >> - goto out; >> - } while (time_before(jiffies, timeo)); >> + status = *spinand->scratchbuf; >> + if (!(status & STATUS_BUSY)) >> + goto out; > > Looks like you expect the driver to not only wait for a status change > but also fill the data buffer with the last status value. I think that > should be documented in the SPI mem API. Right, i will update the API. Thanks Patrice > >> /* >> * Extra read, just in case the STATUS_READY bit has changed >> @@ -526,7 +532,10 @@ static int spinand_reset_op(struct spinand_device *spinand) >> if (ret) >> return ret; >> >> - return spinand_wait(spinand, NULL); >> + return spinand_wait(spinand, >> + SPINAND_RESET_INITIAL_DELAY_US, >> + SPINAND_RESET_POLL_DELAY_US, >> + NULL); >> } >> >> static int spinand_lock_block(struct spinand_device *spinand, u8 lock) >> @@ -549,7 +558,10 @@ static int spinand_read_page(struct spinand_device *spinand, >> if (ret) >> return ret; >> >> - ret = spinand_wait(spinand, &status); >> + ret = spinand_wait(spinand, >> + SPINAND_READ_INITIAL_DELAY_US, >> + SPINAND_READ_POLL_DELAY_US, >> + &status); >> if (ret < 0) >> return ret; >> >> @@ -585,7 +597,10 @@ static int spinand_write_page(struct spinand_device *spinand, >> if (ret) >> return ret; >> >> - ret = spinand_wait(spinand, &status); >> + ret = spinand_wait(spinand, >> + SPINAND_WRITE_INITIAL_DELAY_US, >> + SPINAND_WRITE_POLL_DELAY_US, >> + &status); >> if (!ret && (status & STATUS_PROG_FAILED)) >> return -EIO; >> >> @@ -768,7 +783,11 @@ static int spinand_erase(struct nand_device *nand, const struct nand_pos *pos) >> if (ret) >> return ret; >> >> - ret = spinand_wait(spinand, &status); >> + ret = spinand_wait(spinand, >> + SPINAND_ERASE_INITIAL_DELAY_US, >> + SPINAND_ERASE_POLL_DELAY_US, >> + &status); >> + >> if (!ret && (status & STATUS_ERASE_FAILED)) >> ret = -EIO; >> >> diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h >> index 6bb92f26833e..6988956b8492 100644 >> --- a/include/linux/mtd/spinand.h >> +++ b/include/linux/mtd/spinand.h >> @@ -170,6 +170,28 @@ struct spinand_op; >> struct spinand_device; >> >> #define SPINAND_MAX_ID_LEN 4 >> +/* >> + * For erase, write and read operation, we got the following timings : >> + * tBERS (erase) 1ms to 4ms >> + * tPROG 300us to 400us >> + * tREAD 25us to 100us >> + * In order to minimize latency, the min value is divided by 4 for the >> + * initial delay, and dividing by 20 for the poll delay. >> + * For reset, 5us/10us/500us if the device is respectively >> + * reading/programming/erasing when the RESET occurs. Since we always >> + * issue a RESET when the device is IDLE, 5us is selected for both initial >> + * and poll delay. >> + */ >> +#define SPINAND_READ_INITIAL_DELAY_US 6 >> +#define SPINAND_READ_POLL_DELAY_US 5 >> +#define SPINAND_RESET_INITIAL_DELAY_US 5 >> +#define SPINAND_RESET_POLL_DELAY_US 5 >> +#define SPINAND_WRITE_INITIAL_DELAY_US 75 >> +#define SPINAND_WRITE_POLL_DELAY_US 15 >> +#define SPINAND_ERASE_INITIAL_DELAY_US 250 >> +#define SPINAND_ERASE_POLL_DELAY_US 50 >> + >> +#define SPINAND_WAITRDY_TIMEOUT_MS 400 >> >> /** >> * struct spinand_id - SPI NAND id structure > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF20EC433B4 for ; Tue, 18 May 2021 14:36:02 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71D2E611CC for ; Tue, 18 May 2021 14:36:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71D2E611CC Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=G8TKpqEKhBuqb6S2j+8iFwvkUQ+pjR7ULprrcldcFl4=; b=GUmW3vbTxbF4UEGXnXEFsAKjM iQ/Llu0VaKt12SxiTiW0XEt7p7h1Or4XaCE8YcYB3ZI1DJMgRG61dvl0agwzl+jMh+/Z4GmWbnnfR qOJwEYgLFVEF7raZCHqMy7EHohvCoesCyoXK8nM5M/NtJnexznSLCmg+LdVmNtoM4VM66Fr1roRTz rid7JlIs1TkcJe0y9Kyg68R4ywCtsYTsuFn9Lua/pDm6TAFq/24MB6F4UuoKLGYyNXOhbnfrdkl5i pFErWiBTP2DNGfbh4asZc/+KhlfbNWzqWsNm3/I/cNRetKa9PiHibvAwoxFCMDaAWo5Sv+0iTQeT0 OLf1G1Img==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lj0oL-0013fn-FD; Tue, 18 May 2021 14:35:05 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lj0oI-0013ex-0Q; Tue, 18 May 2021 14:35:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:CC:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=IoZWo4g6WYmn4ZvcOIUxvySqtfs8j1f0MrKnheiGUHs=; b=PakBlsDsu+p8VqNDKCBNNCc++r EIQiOpYys3h44lqL6stSDWjh2Gpfq3VnKMiUc8PJunqtktAPK1CTafXrdhdjdsY2Eu9bMf8fviM8F VnWK/pbGvRzS05uiwo4K1bWALIzHh6CYraDMD8qogqdW2uqhc88eanyRjnF+shhZgtNEP1frNEP2J QiaELcmPVxU9Khiqi7q39FdNcruwAdm5LFSBk3cHY3OsK7mBDTHDYWe3/KLtw8bysXVCRMaV8shzM 7yo46Ec7WnkFWWod6eVy4u8meuAKC+f8NAj1sjqkKI/OJxyMf9mpPbV6ei2tkNZ1tGUUde0BXyIev MHlbj5MA==; Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lj0oE-00EjUk-SJ; Tue, 18 May 2021 14:35:00 +0000 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14IEWv7u024660; Tue, 18 May 2021 16:34:54 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=IoZWo4g6WYmn4ZvcOIUxvySqtfs8j1f0MrKnheiGUHs=; b=DWsG2/8/3Qz8EOE6fD0Ev8WmmPUOpuL+EpzqNukA0oUpU0lEULgvEElHjsHFOFbVcvhP tUn4l/mQqYuLQW6Z8PCRcj7hVjryeaBDNhMwJbBX/kan5rFoVnTs98/c99WLsOMac4rl WLIDONkX7FU5nrtYQw+Kp7ZLtjfF87D1GFq6yf1OQuNACqDWJgsxkX1w5aiQTrFUiMOu n1GpjTi8F1S/XK4ROkVDUOFukZk4W3TjAbkWiRKY6OgbbVP1cMRnpIM/c1rcsXjkIZWa O60Pz0hxQ06k1DLcaITk8ZtZsrYW2BEMy4nKOoSVP1oUFOFfPXgsILqRPuwLVJCK89kj qw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 38maunsss0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 May 2021 16:34:54 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id DEBA310002A; Tue, 18 May 2021 16:34:53 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id C3E0822AED2; Tue, 18 May 2021 16:34:53 +0200 (CEST) Received: from lmecxl0573.lme.st.com (10.75.127.46) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 18 May 2021 16:34:52 +0200 Subject: Re: [PATCH v4 2/3] mtd: spinand: use the spi-mem poll status APIs To: Boris Brezillon CC: Mark Brown , Miquel Raynal , Vignesh Raghavendra , , Alexandre Torgue , , , , , References: <20210518134332.17826-1-patrice.chotard@foss.st.com> <20210518134332.17826-3-patrice.chotard@foss.st.com> <20210518161834.6860c310@collabora.com> From: Patrice CHOTARD Message-ID: <028d3c29-effe-1604-8e38-b7fb0783c4a2@foss.st.com> Date: Tue, 18 May 2021 16:34:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210518161834.6860c310@collabora.com> Content-Language: en-US X-Originating-IP: [10.75.127.46] X-ClientProxiedBy: SFHDAG1NODE1.st.com (10.75.127.1) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-18_07:2021-05-18, 2021-05-18 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210518_073459_247054_01B7DF9E X-CRM114-Status: GOOD ( 29.74 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On 5/18/21 4:18 PM, Boris Brezillon wrote: > On Tue, 18 May 2021 15:43:31 +0200 > wrote: > >> From: Patrice Chotard >> >> Make use of spi-mem poll status APIs to let advanced controllers >> optimize wait operations. >> This should also fix the high CPU usage for system that don't have >> a dedicated STATUS poll block logic. >> >> Signed-off-by: Patrice Chotard >> Signed-off-by: Christophe Kerello >> --- >> Changes in v4: >> - Update commit message. >> - Add comment which explains how delays has been calculated. >> - Rename SPINAND_STATUS_TIMEOUT_MS to SPINAND_WAITRDY_TIMEOUT_MS. >> >> Changes in v3: >> - Add initial_delay_us and polling_delay_us parameters to spinand_wait() >> - Add SPINAND_READ/WRITE/ERASE/RESET_INITIAL_DELAY_US and >> SPINAND_READ/WRITE/ERASE/RESET_POLL_DELAY_US defines. >> >> Changes in v2: >> - non-offload case is now managed by spi_mem_poll_status() >> >> drivers/mtd/nand/spi/core.c | 45 ++++++++++++++++++++++++++----------- >> include/linux/mtd/spinand.h | 22 ++++++++++++++++++ >> 2 files changed, 54 insertions(+), 13 deletions(-) >> >> diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c >> index 17f63f95f4a2..3131fae0c715 100644 >> --- a/drivers/mtd/nand/spi/core.c >> +++ b/drivers/mtd/nand/spi/core.c >> @@ -473,20 +473,26 @@ static int spinand_erase_op(struct spinand_device *spinand, >> return spi_mem_exec_op(spinand->spimem, &op); >> } >> >> -static int spinand_wait(struct spinand_device *spinand, u8 *s) >> +static int spinand_wait(struct spinand_device *spinand, >> + unsigned long initial_delay_us, >> + unsigned long poll_delay_us, >> + u8 *s) >> { >> - unsigned long timeo = jiffies + msecs_to_jiffies(400); >> + struct spi_mem_op op = SPINAND_GET_FEATURE_OP(REG_STATUS, >> + spinand->scratchbuf); >> u8 status; >> int ret; >> >> - do { >> - ret = spinand_read_status(spinand, &status); >> - if (ret) >> - return ret; >> + ret = spi_mem_poll_status(spinand->spimem, &op, STATUS_BUSY, 0, >> + initial_delay_us, >> + poll_delay_us, >> + SPINAND_WAITRDY_TIMEOUT_MS); >> + if (ret) >> + return ret; >> >> - if (!(status & STATUS_BUSY)) >> - goto out; >> - } while (time_before(jiffies, timeo)); >> + status = *spinand->scratchbuf; >> + if (!(status & STATUS_BUSY)) >> + goto out; > > Looks like you expect the driver to not only wait for a status change > but also fill the data buffer with the last status value. I think that > should be documented in the SPI mem API. Right, i will update the API. Thanks Patrice > >> /* >> * Extra read, just in case the STATUS_READY bit has changed >> @@ -526,7 +532,10 @@ static int spinand_reset_op(struct spinand_device *spinand) >> if (ret) >> return ret; >> >> - return spinand_wait(spinand, NULL); >> + return spinand_wait(spinand, >> + SPINAND_RESET_INITIAL_DELAY_US, >> + SPINAND_RESET_POLL_DELAY_US, >> + NULL); >> } >> >> static int spinand_lock_block(struct spinand_device *spinand, u8 lock) >> @@ -549,7 +558,10 @@ static int spinand_read_page(struct spinand_device *spinand, >> if (ret) >> return ret; >> >> - ret = spinand_wait(spinand, &status); >> + ret = spinand_wait(spinand, >> + SPINAND_READ_INITIAL_DELAY_US, >> + SPINAND_READ_POLL_DELAY_US, >> + &status); >> if (ret < 0) >> return ret; >> >> @@ -585,7 +597,10 @@ static int spinand_write_page(struct spinand_device *spinand, >> if (ret) >> return ret; >> >> - ret = spinand_wait(spinand, &status); >> + ret = spinand_wait(spinand, >> + SPINAND_WRITE_INITIAL_DELAY_US, >> + SPINAND_WRITE_POLL_DELAY_US, >> + &status); >> if (!ret && (status & STATUS_PROG_FAILED)) >> return -EIO; >> >> @@ -768,7 +783,11 @@ static int spinand_erase(struct nand_device *nand, const struct nand_pos *pos) >> if (ret) >> return ret; >> >> - ret = spinand_wait(spinand, &status); >> + ret = spinand_wait(spinand, >> + SPINAND_ERASE_INITIAL_DELAY_US, >> + SPINAND_ERASE_POLL_DELAY_US, >> + &status); >> + >> if (!ret && (status & STATUS_ERASE_FAILED)) >> ret = -EIO; >> >> diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h >> index 6bb92f26833e..6988956b8492 100644 >> --- a/include/linux/mtd/spinand.h >> +++ b/include/linux/mtd/spinand.h >> @@ -170,6 +170,28 @@ struct spinand_op; >> struct spinand_device; >> >> #define SPINAND_MAX_ID_LEN 4 >> +/* >> + * For erase, write and read operation, we got the following timings : >> + * tBERS (erase) 1ms to 4ms >> + * tPROG 300us to 400us >> + * tREAD 25us to 100us >> + * In order to minimize latency, the min value is divided by 4 for the >> + * initial delay, and dividing by 20 for the poll delay. >> + * For reset, 5us/10us/500us if the device is respectively >> + * reading/programming/erasing when the RESET occurs. Since we always >> + * issue a RESET when the device is IDLE, 5us is selected for both initial >> + * and poll delay. >> + */ >> +#define SPINAND_READ_INITIAL_DELAY_US 6 >> +#define SPINAND_READ_POLL_DELAY_US 5 >> +#define SPINAND_RESET_INITIAL_DELAY_US 5 >> +#define SPINAND_RESET_POLL_DELAY_US 5 >> +#define SPINAND_WRITE_INITIAL_DELAY_US 75 >> +#define SPINAND_WRITE_POLL_DELAY_US 15 >> +#define SPINAND_ERASE_INITIAL_DELAY_US 250 >> +#define SPINAND_ERASE_POLL_DELAY_US 50 >> + >> +#define SPINAND_WAITRDY_TIMEOUT_MS 400 >> >> /** >> * struct spinand_id - SPI NAND id structure > ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F161AC43460 for ; Tue, 18 May 2021 14:37:27 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8298E61006 for ; Tue, 18 May 2021 14:37:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8298E61006 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=foss.st.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:CC:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=zQftkHYysF6yBR2brg2ueYs6tCl9cyodhys1buQIzpY=; b=HyQ9ObLvVXIHE8s2nLObmm31W Aj/AgpdWaVcvX/6vKd8+mQnd3oEMdVmXGDd9QQ5pIB6ZneSxQYXafEHBbVp41o5G2THDCnxHLMoiS A4TUp9GIMTb71D8g/Wpo6Yc3vZ7Sh5uIPyyhBITBvK620pyTEZ8xk1fcmgpGMaZBnFyLjPRd2DC11 lihw+Wh+HcSaTtnQT6UrSsKOzPOkEffyrrIMZZO18hVNhBJ8m+m5krozWmMbIzlRwRzvXGHM6iXI6 1lmwa1tBLynykoGFnPxXYXcIlN6aLEo4BXNEpK/EYiBmALfXiAOYxwrxWT4B1Bw3ThS3Db1WmupVA EY4fqLjLA==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lj0oa-0013k7-C8; Tue, 18 May 2021 14:35:20 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lj0oI-0013ex-0Q; Tue, 18 May 2021 14:35:03 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:MIME-Version:Date:Message-ID:From:References:CC:To: Subject:Sender:Reply-To:Content-ID:Content-Description; bh=IoZWo4g6WYmn4ZvcOIUxvySqtfs8j1f0MrKnheiGUHs=; b=PakBlsDsu+p8VqNDKCBNNCc++r EIQiOpYys3h44lqL6stSDWjh2Gpfq3VnKMiUc8PJunqtktAPK1CTafXrdhdjdsY2Eu9bMf8fviM8F VnWK/pbGvRzS05uiwo4K1bWALIzHh6CYraDMD8qogqdW2uqhc88eanyRjnF+shhZgtNEP1frNEP2J QiaELcmPVxU9Khiqi7q39FdNcruwAdm5LFSBk3cHY3OsK7mBDTHDYWe3/KLtw8bysXVCRMaV8shzM 7yo46Ec7WnkFWWod6eVy4u8meuAKC+f8NAj1sjqkKI/OJxyMf9mpPbV6ei2tkNZ1tGUUde0BXyIev MHlbj5MA==; Received: from mx07-00178001.pphosted.com ([185.132.182.106]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lj0oE-00EjUk-SJ; Tue, 18 May 2021 14:35:00 +0000 Received: from pps.filterd (m0046668.ppops.net [127.0.0.1]) by mx07-00178001.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14IEWv7u024660; Tue, 18 May 2021 16:34:54 +0200 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foss.st.com; h=subject : to : cc : references : from : message-id : date : mime-version : in-reply-to : content-type : content-transfer-encoding; s=selector1; bh=IoZWo4g6WYmn4ZvcOIUxvySqtfs8j1f0MrKnheiGUHs=; b=DWsG2/8/3Qz8EOE6fD0Ev8WmmPUOpuL+EpzqNukA0oUpU0lEULgvEElHjsHFOFbVcvhP tUn4l/mQqYuLQW6Z8PCRcj7hVjryeaBDNhMwJbBX/kan5rFoVnTs98/c99WLsOMac4rl WLIDONkX7FU5nrtYQw+Kp7ZLtjfF87D1GFq6yf1OQuNACqDWJgsxkX1w5aiQTrFUiMOu n1GpjTi8F1S/XK4ROkVDUOFukZk4W3TjAbkWiRKY6OgbbVP1cMRnpIM/c1rcsXjkIZWa O60Pz0hxQ06k1DLcaITk8ZtZsrYW2BEMy4nKOoSVP1oUFOFfPXgsILqRPuwLVJCK89kj qw== Received: from beta.dmz-eu.st.com (beta.dmz-eu.st.com [164.129.1.35]) by mx07-00178001.pphosted.com with ESMTP id 38maunsss0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 18 May 2021 16:34:54 +0200 Received: from euls16034.sgp.st.com (euls16034.sgp.st.com [10.75.44.20]) by beta.dmz-eu.st.com (STMicroelectronics) with ESMTP id DEBA310002A; Tue, 18 May 2021 16:34:53 +0200 (CEST) Received: from Webmail-eu.st.com (sfhdag2node3.st.com [10.75.127.6]) by euls16034.sgp.st.com (STMicroelectronics) with ESMTP id C3E0822AED2; Tue, 18 May 2021 16:34:53 +0200 (CEST) Received: from lmecxl0573.lme.st.com (10.75.127.46) by SFHDAG2NODE3.st.com (10.75.127.6) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 18 May 2021 16:34:52 +0200 Subject: Re: [PATCH v4 2/3] mtd: spinand: use the spi-mem poll status APIs To: Boris Brezillon CC: Mark Brown , Miquel Raynal , Vignesh Raghavendra , , Alexandre Torgue , , , , , References: <20210518134332.17826-1-patrice.chotard@foss.st.com> <20210518134332.17826-3-patrice.chotard@foss.st.com> <20210518161834.6860c310@collabora.com> From: Patrice CHOTARD Message-ID: <028d3c29-effe-1604-8e38-b7fb0783c4a2@foss.st.com> Date: Tue, 18 May 2021 16:34:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210518161834.6860c310@collabora.com> Content-Language: en-US X-Originating-IP: [10.75.127.46] X-ClientProxiedBy: SFHDAG1NODE1.st.com (10.75.127.1) To SFHDAG2NODE3.st.com (10.75.127.6) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.391, 18.0.761 definitions=2021-05-18_07:2021-05-18, 2021-05-18 signatures=0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210518_073459_247054_01B7DF9E X-CRM114-Status: GOOD ( 29.74 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 5/18/21 4:18 PM, Boris Brezillon wrote: > On Tue, 18 May 2021 15:43:31 +0200 > wrote: > >> From: Patrice Chotard >> >> Make use of spi-mem poll status APIs to let advanced controllers >> optimize wait operations. >> This should also fix the high CPU usage for system that don't have >> a dedicated STATUS poll block logic. >> >> Signed-off-by: Patrice Chotard >> Signed-off-by: Christophe Kerello >> --- >> Changes in v4: >> - Update commit message. >> - Add comment which explains how delays has been calculated. >> - Rename SPINAND_STATUS_TIMEOUT_MS to SPINAND_WAITRDY_TIMEOUT_MS. >> >> Changes in v3: >> - Add initial_delay_us and polling_delay_us parameters to spinand_wait() >> - Add SPINAND_READ/WRITE/ERASE/RESET_INITIAL_DELAY_US and >> SPINAND_READ/WRITE/ERASE/RESET_POLL_DELAY_US defines. >> >> Changes in v2: >> - non-offload case is now managed by spi_mem_poll_status() >> >> drivers/mtd/nand/spi/core.c | 45 ++++++++++++++++++++++++++----------- >> include/linux/mtd/spinand.h | 22 ++++++++++++++++++ >> 2 files changed, 54 insertions(+), 13 deletions(-) >> >> diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c >> index 17f63f95f4a2..3131fae0c715 100644 >> --- a/drivers/mtd/nand/spi/core.c >> +++ b/drivers/mtd/nand/spi/core.c >> @@ -473,20 +473,26 @@ static int spinand_erase_op(struct spinand_device *spinand, >> return spi_mem_exec_op(spinand->spimem, &op); >> } >> >> -static int spinand_wait(struct spinand_device *spinand, u8 *s) >> +static int spinand_wait(struct spinand_device *spinand, >> + unsigned long initial_delay_us, >> + unsigned long poll_delay_us, >> + u8 *s) >> { >> - unsigned long timeo = jiffies + msecs_to_jiffies(400); >> + struct spi_mem_op op = SPINAND_GET_FEATURE_OP(REG_STATUS, >> + spinand->scratchbuf); >> u8 status; >> int ret; >> >> - do { >> - ret = spinand_read_status(spinand, &status); >> - if (ret) >> - return ret; >> + ret = spi_mem_poll_status(spinand->spimem, &op, STATUS_BUSY, 0, >> + initial_delay_us, >> + poll_delay_us, >> + SPINAND_WAITRDY_TIMEOUT_MS); >> + if (ret) >> + return ret; >> >> - if (!(status & STATUS_BUSY)) >> - goto out; >> - } while (time_before(jiffies, timeo)); >> + status = *spinand->scratchbuf; >> + if (!(status & STATUS_BUSY)) >> + goto out; > > Looks like you expect the driver to not only wait for a status change > but also fill the data buffer with the last status value. I think that > should be documented in the SPI mem API. Right, i will update the API. Thanks Patrice > >> /* >> * Extra read, just in case the STATUS_READY bit has changed >> @@ -526,7 +532,10 @@ static int spinand_reset_op(struct spinand_device *spinand) >> if (ret) >> return ret; >> >> - return spinand_wait(spinand, NULL); >> + return spinand_wait(spinand, >> + SPINAND_RESET_INITIAL_DELAY_US, >> + SPINAND_RESET_POLL_DELAY_US, >> + NULL); >> } >> >> static int spinand_lock_block(struct spinand_device *spinand, u8 lock) >> @@ -549,7 +558,10 @@ static int spinand_read_page(struct spinand_device *spinand, >> if (ret) >> return ret; >> >> - ret = spinand_wait(spinand, &status); >> + ret = spinand_wait(spinand, >> + SPINAND_READ_INITIAL_DELAY_US, >> + SPINAND_READ_POLL_DELAY_US, >> + &status); >> if (ret < 0) >> return ret; >> >> @@ -585,7 +597,10 @@ static int spinand_write_page(struct spinand_device *spinand, >> if (ret) >> return ret; >> >> - ret = spinand_wait(spinand, &status); >> + ret = spinand_wait(spinand, >> + SPINAND_WRITE_INITIAL_DELAY_US, >> + SPINAND_WRITE_POLL_DELAY_US, >> + &status); >> if (!ret && (status & STATUS_PROG_FAILED)) >> return -EIO; >> >> @@ -768,7 +783,11 @@ static int spinand_erase(struct nand_device *nand, const struct nand_pos *pos) >> if (ret) >> return ret; >> >> - ret = spinand_wait(spinand, &status); >> + ret = spinand_wait(spinand, >> + SPINAND_ERASE_INITIAL_DELAY_US, >> + SPINAND_ERASE_POLL_DELAY_US, >> + &status); >> + >> if (!ret && (status & STATUS_ERASE_FAILED)) >> ret = -EIO; >> >> diff --git a/include/linux/mtd/spinand.h b/include/linux/mtd/spinand.h >> index 6bb92f26833e..6988956b8492 100644 >> --- a/include/linux/mtd/spinand.h >> +++ b/include/linux/mtd/spinand.h >> @@ -170,6 +170,28 @@ struct spinand_op; >> struct spinand_device; >> >> #define SPINAND_MAX_ID_LEN 4 >> +/* >> + * For erase, write and read operation, we got the following timings : >> + * tBERS (erase) 1ms to 4ms >> + * tPROG 300us to 400us >> + * tREAD 25us to 100us >> + * In order to minimize latency, the min value is divided by 4 for the >> + * initial delay, and dividing by 20 for the poll delay. >> + * For reset, 5us/10us/500us if the device is respectively >> + * reading/programming/erasing when the RESET occurs. Since we always >> + * issue a RESET when the device is IDLE, 5us is selected for both initial >> + * and poll delay. >> + */ >> +#define SPINAND_READ_INITIAL_DELAY_US 6 >> +#define SPINAND_READ_POLL_DELAY_US 5 >> +#define SPINAND_RESET_INITIAL_DELAY_US 5 >> +#define SPINAND_RESET_POLL_DELAY_US 5 >> +#define SPINAND_WRITE_INITIAL_DELAY_US 75 >> +#define SPINAND_WRITE_POLL_DELAY_US 15 >> +#define SPINAND_ERASE_INITIAL_DELAY_US 250 >> +#define SPINAND_ERASE_POLL_DELAY_US 50 >> + >> +#define SPINAND_WAITRDY_TIMEOUT_MS 400 >> >> /** >> * struct spinand_id - SPI NAND id structure > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel