From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C3C8C433F5 for ; Tue, 15 Feb 2022 09:21:57 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 014B483801; Tue, 15 Feb 2022 10:21:50 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1644916911; bh=5lQbwhQcIFpjBd5M3z2lzXDJKN6g7jRlmDp/aABx0mg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=erMaVdCIpmAxCNcrfDl+c+VDBsMf03m8yPqXykxmBrkeTP1tCDu7Roi82/2imTKHt J6bz8UASts4D9Jtuah1ONEvhmeSiWepRZCTCG8Qu6t3wrrWajj6HeQPhNSu6LiFzY5 d+D8SyRdnrzjipDxTvIqZhn9mIaXGDoAXdiyipuSTsl5QqaEt/kr2+c0OnbkNEa7GZ 0U8GBjci1/4DUF8FeIOcD8x6/vMs0V2HUWC0WWYt7qosx//5buES/WOHp95tiAqsQA q8x+rh/cQGx0Rtrsx4117W1HVdctf2xdLZvnnyjN242vNPjNErBJhCsc/UD99+tXBk 7qwxakK6pJibA== Received: by phobos.denx.de (Postfix, from userid 109) id E86DD838C4; Tue, 15 Feb 2022 10:21:44 +0100 (CET) Received: from mout-u-107.mailbox.org (mout-u-107.mailbox.org [91.198.250.252]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 139A8837E4 for ; Tue, 15 Feb 2022 10:21:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp2.mailbox.org (unknown [91.198.250.124]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-107.mailbox.org (Postfix) with ESMTPS id 4JybFF3b5sz9sZP; Tue, 15 Feb 2022 10:21:37 +0100 (CET) Message-ID: <02a54ace-b50a-f9a6-7ad0-b413daa7bbb2@denx.de> Date: Tue, 15 Feb 2022 10:21:33 +0100 MIME-Version: 1.0 Subject: Re: [PATCH u-boot-marvell 3/4] arm: a37xx: pci: Use dev_read_addr() Content-Language: en-US To: =?UTF-8?Q?Pali_Roh=c3=a1r?= , =?UTF-8?Q?Marek_Beh=c3=ban?= Cc: u-boot@lists.denx.de References: <20220210135345.28452-1-pali@kernel.org> <20220210135345.28452-3-pali@kernel.org> From: Stefan Roese In-Reply-To: <20220210135345.28452-3-pali@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.5 at phobos.denx.de X-Virus-Status: Clean On 2/10/22 14:53, Pali Rohár wrote: > There is only one base address, so use dev_read_addr() instead of dev_read_addr_index(). > > Signed-off-by: Pali Rohár Reviewed-by: Stefan Roese Thanks, Stefan > --- > drivers/pci/pci-aardvark.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pci/pci-aardvark.c b/drivers/pci/pci-aardvark.c > index 8e3b13b49ea0..6e65c0e1558c 100644 > --- a/drivers/pci/pci-aardvark.c > +++ b/drivers/pci/pci-aardvark.c > @@ -991,7 +991,7 @@ static int pcie_advk_of_to_plat(struct udevice *dev) > struct pcie_advk *pcie = dev_get_priv(dev); > > /* Get the register base address */ > - pcie->base = (void *)dev_read_addr_index(dev, 0); > + pcie->base = (void *)dev_read_addr(dev); > if ((fdt_addr_t)pcie->base == FDT_ADDR_T_NONE) > return -EINVAL; > Viele Grüße, Stefan Roese -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de