From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jon Hunter Subject: Re: [PATCH v3] platform/chrome: Use proper protocol transfer function Date: Tue, 19 Sep 2017 14:44:36 +0100 Message-ID: <02aa65e7-e967-055b-2af3-2e9b6ef77935@nvidia.com> References: <20170908205011.77986-1-briannorris@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170908205011.77986-1-briannorris-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org> Content-Language: en-US Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Brian Norris , Olof Johansson , Benson Leung Cc: Lee Jones , linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Doug Anderson , Brian Norris , Javier Martinez Canillas , Shawn Nematbakhsh , Gwendal Grignou , Enric Balletbo , Tomeu Vizoso , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-tegra@vger.kernel.org Hi Brian, On 08/09/17 21:50, Brian Norris wrote: > From: Shawn Nematbakhsh > > pkt_xfer should be used for protocol v3, and cmd_xfer otherwise. We had > one instance of these functions correct, but not the second, fall-back > case. We use the fall-back only when the first command returns an > IN_PROGRESS status, which is only used on some EC firmwares where we > don't want to constantly poll the bus, but instead back off and > sleep/retry for a little while. > > Fixes: 2c7589af3c4d ("mfd: cros_ec: add proto v3 skeleton") > Signed-off-by: Shawn Nematbakhsh > Signed-off-by: Brian Norris > Reviewed-by: Javier Martinez Canillas > --- > v3: > * Added Javier's reviewed tag > * It's been > 8 months since [1], so why not? And hey, Benson's officially in > MAINTAINERS now! Too bad no one told me. > > [1] https://patchwork.kernel.org/patch/9450633/ > > > v2: > * Add Benson in 'To:' > * make subject prefix more obvious > > drivers/platform/chrome/cros_ec_proto.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c > index 8dfa7fcb1248..e7bbdf947bbc 100644 > --- a/drivers/platform/chrome/cros_ec_proto.c > +++ b/drivers/platform/chrome/cros_ec_proto.c > @@ -60,12 +60,14 @@ static int send_command(struct cros_ec_device *ec_dev, > struct cros_ec_command *msg) > { > int ret; > + int (*xfer_fxn)(struct cros_ec_device *ec, struct cros_ec_command *msg); > > if (ec_dev->proto_version > 2) > - ret = ec_dev->pkt_xfer(ec_dev, msg); > + xfer_fxn = ec_dev->pkt_xfer; > else > - ret = ec_dev->cmd_xfer(ec_dev, msg); > + xfer_fxn = ec_dev->cmd_xfer; > > + ret = (*xfer_fxn)(ec_dev, msg); > if (msg->result == EC_RES_IN_PROGRESS) { > int i; > struct cros_ec_command *status_msg; > @@ -88,7 +90,7 @@ static int send_command(struct cros_ec_device *ec_dev, > for (i = 0; i < EC_COMMAND_RETRIES; i++) { > usleep_range(10000, 11000); > > - ret = ec_dev->cmd_xfer(ec_dev, status_msg); > + ret = (*xfer_fxn)(ec_dev, status_msg); > if (ret < 0) > break; > Tegra124 Nyan-Big is currently crashing during boot with -next [0] and bisect is pointing to this commit. Reverting the above on top of -next does allow the board to boot successfully. Looks like this board is proto_version 3 but I have not looked into this any further. Let me know if you have any thoughts. Cheers Jon [0] https://nvtb.github.io//linux-next/test_next-20170919/20170918213034/boot/tegra124-nyan-big/tegra124-nyan-big/tegra_defconfig_log.txt -- nvpublic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751378AbdISNpK (ORCPT ); Tue, 19 Sep 2017 09:45:10 -0400 Received: from hqemgate16.nvidia.com ([216.228.121.65]:18330 "EHLO hqemgate16.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750948AbdISNpI (ORCPT ); Tue, 19 Sep 2017 09:45:08 -0400 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 19 Sep 2017 06:44:58 -0700 Subject: Re: [PATCH v3] platform/chrome: Use proper protocol transfer function To: Brian Norris , Olof Johansson , Benson Leung CC: Lee Jones , , "Doug Anderson" , Brian Norris , Javier Martinez Canillas , Shawn Nematbakhsh , Gwendal Grignou , Enric Balletbo , Tomeu Vizoso , "linux-tegra@vger.kernel.org" References: <20170908205011.77986-1-briannorris@chromium.org> From: Jon Hunter Message-ID: <02aa65e7-e967-055b-2af3-2e9b6ef77935@nvidia.com> Date: Tue, 19 Sep 2017 14:44:36 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: <20170908205011.77986-1-briannorris@chromium.org> X-Originating-IP: [10.21.132.144] X-ClientProxiedBy: UKMAIL101.nvidia.com (10.26.138.13) To UKMAIL101.nvidia.com (10.26.138.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Brian, On 08/09/17 21:50, Brian Norris wrote: > From: Shawn Nematbakhsh > > pkt_xfer should be used for protocol v3, and cmd_xfer otherwise. We had > one instance of these functions correct, but not the second, fall-back > case. We use the fall-back only when the first command returns an > IN_PROGRESS status, which is only used on some EC firmwares where we > don't want to constantly poll the bus, but instead back off and > sleep/retry for a little while. > > Fixes: 2c7589af3c4d ("mfd: cros_ec: add proto v3 skeleton") > Signed-off-by: Shawn Nematbakhsh > Signed-off-by: Brian Norris > Reviewed-by: Javier Martinez Canillas > --- > v3: > * Added Javier's reviewed tag > * It's been > 8 months since [1], so why not? And hey, Benson's officially in > MAINTAINERS now! Too bad no one told me. > > [1] https://patchwork.kernel.org/patch/9450633/ > > > v2: > * Add Benson in 'To:' > * make subject prefix more obvious > > drivers/platform/chrome/cros_ec_proto.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c > index 8dfa7fcb1248..e7bbdf947bbc 100644 > --- a/drivers/platform/chrome/cros_ec_proto.c > +++ b/drivers/platform/chrome/cros_ec_proto.c > @@ -60,12 +60,14 @@ static int send_command(struct cros_ec_device *ec_dev, > struct cros_ec_command *msg) > { > int ret; > + int (*xfer_fxn)(struct cros_ec_device *ec, struct cros_ec_command *msg); > > if (ec_dev->proto_version > 2) > - ret = ec_dev->pkt_xfer(ec_dev, msg); > + xfer_fxn = ec_dev->pkt_xfer; > else > - ret = ec_dev->cmd_xfer(ec_dev, msg); > + xfer_fxn = ec_dev->cmd_xfer; > > + ret = (*xfer_fxn)(ec_dev, msg); > if (msg->result == EC_RES_IN_PROGRESS) { > int i; > struct cros_ec_command *status_msg; > @@ -88,7 +90,7 @@ static int send_command(struct cros_ec_device *ec_dev, > for (i = 0; i < EC_COMMAND_RETRIES; i++) { > usleep_range(10000, 11000); > > - ret = ec_dev->cmd_xfer(ec_dev, status_msg); > + ret = (*xfer_fxn)(ec_dev, status_msg); > if (ret < 0) > break; > Tegra124 Nyan-Big is currently crashing during boot with -next [0] and bisect is pointing to this commit. Reverting the above on top of -next does allow the board to boot successfully. Looks like this board is proto_version 3 but I have not looked into this any further. Let me know if you have any thoughts. Cheers Jon [0] https://nvtb.github.io//linux-next/test_next-20170919/20170918213034/boot/tegra124-nyan-big/tegra124-nyan-big/tegra_defconfig_log.txt -- nvpublic