From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 918D1C2BB55 for ; Fri, 10 Apr 2020 09:47:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6849020801 for ; Fri, 10 Apr 2020 09:47:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="0VEEMUSX" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726111AbgDJJrO (ORCPT ); Fri, 10 Apr 2020 05:47:14 -0400 Received: from mail-lf1-f65.google.com ([209.85.167.65]:38329 "EHLO mail-lf1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725913AbgDJJrN (ORCPT ); Fri, 10 Apr 2020 05:47:13 -0400 Received: by mail-lf1-f65.google.com with SMTP id l11so981215lfc.5 for ; Fri, 10 Apr 2020 02:47:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ixWyit/BPi4Ka4deLVPgn2JfqAzulpluWjNuC7xycq0=; b=0VEEMUSXUIZzs5iYhN0FjOM3beqogpopP5rDDncQ9uEaoy9IhQCJpSjbS/XcuVqDNn U4gUQkn5snZ9ZQ951zs+i+EwryOye3aC64VlDiiQi91q54yOP4gLGuYywdugT/hJpCIp C9a//G0v6owmNFn1orp3IT+/Lk3iCxeR/d8bvRnRtTgW+gGXHLUE8BuVyv2tZXgKVDO0 AdUUecxb5LHlNX8BwTIYJBdEBA6UF8fRgSiyky5Dp/ppC5ILPbCQdykVBXwRQ684kNIp rsKAmvl92WXQL/jppPC/wRaply/yTd2ovdgP+9ZA8v8YQubFLxfk2BJx24xnib5XMnwn 3m9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ixWyit/BPi4Ka4deLVPgn2JfqAzulpluWjNuC7xycq0=; b=EpfLJXjKujMA1YUgPGRqivWS0ciAUSaeYluIWsKgmU0fGQLN2aJK6wtp4+edKXqPy3 0/Jfk45pbRMAIjEoAJtuRphMzN0SLewi4++G0gpdL5N5Pur9quHyiKrKMM6RX2KJwgkS gHEL2f3oerzvc42WQH0X4QXmqHk6Y8tcZnct2Kpd6XbaSyzIK3EuvLp+WALfzTE+tLjf a4Ry+JoZJuPWIeUavYkofJCY0pBjr7Pz+jhdP8Ve+a10G3ggvt42ZU7mKSxKGQC3leT1 0Mhyq8cY4j441camvDHSeNXW/+ksYYZFxXktIDOGc7oNadYMmuHPDl2AQ+Lp5JUgkdMj 7PzA== X-Gm-Message-State: AGi0PuYfappiGpNFH/nTh9XhywTtAS/IM5fe4AU6QLSJf7PO3l10k+Qo 7+kLWKC9Gum1somBzbJrySxaFg== X-Google-Smtp-Source: APiQypKlvy1p+ulGm7rmqXh0dNWrbd9j3xSh46zFxUDGl1I0qpueqnZ7JooiYzM/K+nLb3U/hKGRBQ== X-Received: by 2002:ac2:498d:: with SMTP id f13mr2157743lfl.75.1586512032084; Fri, 10 Apr 2020 02:47:12 -0700 (PDT) Received: from ?IPv6:2a00:1fa0:449c:a024:b8e5:a34a:c38e:b427? ([2a00:1fa0:449c:a024:b8e5:a34a:c38e:b427]) by smtp.gmail.com with ESMTPSA id o6sm794019lji.15.2020.04.10.02.47.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Apr 2020 02:47:11 -0700 (PDT) Subject: Re: [PATCH] usb: gadget: fsl: Fix a wrong judgment in fsl_udc_probe() To: Tang Bin , leoyang.li@nxp.com, balbi@kernel.org, gregkh@linuxfoundation.org Cc: linux-usb@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Markus.Elfring@web.de, Shengju Zhang References: <20200410015832.8012-1-tangbin@cmss.chinamobile.com> From: Sergei Shtylyov Message-ID: <02aeae70-60b8-761c-b058-8b4bc78ffd99@cogentembedded.com> Date: Fri, 10 Apr 2020 12:47:01 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200410015832.8012-1-tangbin@cmss.chinamobile.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10.04.2020 4:58, Tang Bin wrote: > If the function "platform_get_irq()" failed, the negative value > returned will not be detected here, including "-EPROBE_DEFER", which > causes the application to fail to get the correct error message. > Thus it must be fixed. platform_get_irq() prints an appropriate error message, the problem is that the current code calls request_irq() with error code instead of IRQ. > Signed-off-by: Tang Bin > Signed-off-by: Shengju Zhang [...] MBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 51933C2BA2B for ; Fri, 10 Apr 2020 09:48:53 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E783B2078E for ; Fri, 10 Apr 2020 09:48:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.b="0VEEMUSX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E783B2078E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=cogentembedded.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 48zCrf3CWFzDrNV for ; Fri, 10 Apr 2020 19:48:50 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=cogentembedded.com (client-ip=2a00:1450:4864:20::143; helo=mail-lf1-x143.google.com; envelope-from=sergei.shtylyov@cogentembedded.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=cogentembedded.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=cogentembedded-com.20150623.gappssmtp.com header.i=@cogentembedded-com.20150623.gappssmtp.com header.a=rsa-sha256 header.s=20150623 header.b=0VEEMUSX; dkim-atps=neutral Received: from mail-lf1-x143.google.com (mail-lf1-x143.google.com [IPv6:2a00:1450:4864:20::143]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 48zCpq4myCzDrB9 for ; Fri, 10 Apr 2020 19:47:14 +1000 (AEST) Received: by mail-lf1-x143.google.com with SMTP id h6so997617lfc.0 for ; Fri, 10 Apr 2020 02:47:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cogentembedded-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=ixWyit/BPi4Ka4deLVPgn2JfqAzulpluWjNuC7xycq0=; b=0VEEMUSXUIZzs5iYhN0FjOM3beqogpopP5rDDncQ9uEaoy9IhQCJpSjbS/XcuVqDNn U4gUQkn5snZ9ZQ951zs+i+EwryOye3aC64VlDiiQi91q54yOP4gLGuYywdugT/hJpCIp C9a//G0v6owmNFn1orp3IT+/Lk3iCxeR/d8bvRnRtTgW+gGXHLUE8BuVyv2tZXgKVDO0 AdUUecxb5LHlNX8BwTIYJBdEBA6UF8fRgSiyky5Dp/ppC5ILPbCQdykVBXwRQ684kNIp rsKAmvl92WXQL/jppPC/wRaply/yTd2ovdgP+9ZA8v8YQubFLxfk2BJx24xnib5XMnwn 3m9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=ixWyit/BPi4Ka4deLVPgn2JfqAzulpluWjNuC7xycq0=; b=KIkz+frnkmQtleMR2uprhMr3nivO5J/WtswnF5P8/x6iA99tm6Ot6GvQz0WaPARdaP lote7Fuvz6Wqo5uZPpZQOVw/Oxs2qCjRk0+b8z77fhK2UstalLoLXuWKEpc+VWRVV/Zc e9I5Sdx01/ofNsrjnsrY73/L8evvWk9qjhwOdwZOx2qcjjkQtSGTlNQV1m4JE/ZHB61m R392NI0Jhf66xfbn00UxbcAt71XVmCxEKxoFonrN0ck8Vs6FQI2JzmrfkkUSYpqp73r3 P8Mdm3JWjy0OlQ6rGmrzDw9pdxyIL31rygqY566vjigVsym8EffztDXYjRMYlm/id3RG +J8g== X-Gm-Message-State: AGi0PuYph6l4aR25NnG6O3s4ibnS+O3g7HlnZc5iayZHLv747DA3ejXL 7BBtzFFG0NCL7pp7n1BKVe9Qmg== X-Google-Smtp-Source: APiQypKlvy1p+ulGm7rmqXh0dNWrbd9j3xSh46zFxUDGl1I0qpueqnZ7JooiYzM/K+nLb3U/hKGRBQ== X-Received: by 2002:ac2:498d:: with SMTP id f13mr2157743lfl.75.1586512032084; Fri, 10 Apr 2020 02:47:12 -0700 (PDT) Received: from ?IPv6:2a00:1fa0:449c:a024:b8e5:a34a:c38e:b427? ([2a00:1fa0:449c:a024:b8e5:a34a:c38e:b427]) by smtp.gmail.com with ESMTPSA id o6sm794019lji.15.2020.04.10.02.47.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Apr 2020 02:47:11 -0700 (PDT) Subject: Re: [PATCH] usb: gadget: fsl: Fix a wrong judgment in fsl_udc_probe() To: Tang Bin , leoyang.li@nxp.com, balbi@kernel.org, gregkh@linuxfoundation.org References: <20200410015832.8012-1-tangbin@cmss.chinamobile.com> From: Sergei Shtylyov Message-ID: <02aeae70-60b8-761c-b058-8b4bc78ffd99@cogentembedded.com> Date: Fri, 10 Apr 2020 12:47:01 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200410015832.8012-1-tangbin@cmss.chinamobile.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Markus.Elfring@web.de, linux-usb@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Shengju Zhang Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 10.04.2020 4:58, Tang Bin wrote: > If the function "platform_get_irq()" failed, the negative value > returned will not be detected here, including "-EPROBE_DEFER", which > causes the application to fail to get the correct error message. > Thus it must be fixed. platform_get_irq() prints an appropriate error message, the problem is that the current code calls request_irq() with error code instead of IRQ. > Signed-off-by: Tang Bin > Signed-off-by: Shengju Zhang [...] MBR, Sergei