From: Richard Henderson <richard.henderson@linaro.org>
To: Peter Maydell <peter.maydell@linaro.org>, Thomas Huth <thuth@redhat.com>
Cc: qemu-devel@nongnu.org,
"Daniel P . Berrange" <berrange@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH 2/3] capstone: Allow version 3.0.5 again
Date: Mon, 16 May 2022 09:46:57 -0700 [thread overview]
Message-ID: <02b0c561-c93c-2ac8-7579-6c456c37771c@linaro.org> (raw)
In-Reply-To: <CAFEAcA-RBUX5iXV__1AMrex21DJK7hx8mygksJa6xynJRCEW4g@mail.gmail.com>
On 5/16/22 08:46, Peter Maydell wrote:
> On Mon, 16 May 2022 at 16:43, Thomas Huth <thuth@redhat.com> wrote:
>>
>> According to
>>
>> https://lore.kernel.org/qemu-devel/20200921174118.39352-1-richard.henderson@linaro.org/
>>
>> there was an issue with Capstone 3 from Ubuntu 18. Now that we removed
>> support for Ubuntu 18.04, that issue should hopefully not bite us
>> anymore. Compiling with version 3.0.5 seems to work fine on other
>> systems, so let's allow that version again.
>
> Commit bcf368626cb33c4d says the reason for requiring capstone
>> =4.0 was "We're about to use a portion of the 4.0 API", not
> "Ubuntu's specific capstone 3 is broken"...
Looks like the patch to which this referred was never merged -- CS_ARCH_RISCV.
I still have a branch with riscv support sitting in it, from Sep 2020. Sadly, I never
posted that patch, nor said why I withheld it in the end. Perhaps the actual riscv support
in capstone was poor at the time.
The 4.0 requirement patch itself was kept for Ubuntu 18's issue:
https://lists.gnu.org/archive/html/qemu-devel/2020-09/msg07542.html
# Changes for v4:
# * Require v4.0 from the system library.
# Fixes an issue AJB found from v3.0.5 from ubuntu 18.
r~
next prev parent reply other threads:[~2022-05-16 16:50 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 14:58 [RFC PATCH 0/3] Allow Capstone 3.0.5 again and remove the submodule Thomas Huth
2022-05-16 14:58 ` [PATCH 1/3] tests/vm: Add capstone to the NetBSD and OpenBSD VMs Thomas Huth
2022-05-17 5:37 ` Richard Henderson
2022-05-16 14:58 ` [PATCH 2/3] capstone: Allow version 3.0.5 again Thomas Huth
2022-05-16 15:46 ` Peter Maydell
2022-05-16 16:46 ` Richard Henderson [this message]
2022-05-16 16:53 ` Peter Maydell
2022-05-16 19:14 ` Richard Henderson
2022-05-16 19:22 ` Thomas Huth
2022-05-17 5:35 ` Richard Henderson
2022-05-17 5:40 ` Richard Henderson
2022-05-16 14:58 ` [PATCH 3/3] capstone: Remove the capstone submodule Thomas Huth
2022-05-17 5:42 ` Richard Henderson
2022-05-19 11:41 ` Peter Maydell
2022-05-23 12:15 ` Thomas Huth
2022-06-03 0:03 ` Richard Henderson
2022-06-03 0:56 ` Richard Henderson
2022-06-03 5:21 ` Thomas Huth
2022-06-03 13:48 ` Richard Henderson
2022-06-03 15:05 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02b0c561-c93c-2ac8-7579-6c456c37771c@linaro.org \
--to=richard.henderson@linaro.org \
--cc=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.