From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55F0AC6FA8B for ; Thu, 22 Sep 2022 07:04:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230107AbiIVHEh (ORCPT ); Thu, 22 Sep 2022 03:04:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47574 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229919AbiIVHEf (ORCPT ); Thu, 22 Sep 2022 03:04:35 -0400 Received: from mail-lf1-x132.google.com (mail-lf1-x132.google.com [IPv6:2a00:1450:4864:20::132]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CB337BCA1 for ; Thu, 22 Sep 2022 00:04:31 -0700 (PDT) Received: by mail-lf1-x132.google.com with SMTP id x27so13240349lfu.0 for ; Thu, 22 Sep 2022 00:04:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=6AOWL8X+6363yl6dlkzkEYMc1TNcmq2VygjKTCBzm64=; b=bKHOfDZXtMpt20Subxu34+Lu5GEWthnW5vWbQiZd2mWo9MuEdinnZCTL41VaMH+5YA j+BtZuHj0f5UCku2oXQvitvnGdhstHYYf7FYqqlV3wD6KLqi8Lwf2dLw+xybPogs0F65 GsEFETmLMZXbLODHYV4TJb1CE7rEfJWP9Yer/P6SGzJ5pGsfzFq7jj39IEN+lz1YIqRu SNSNgDFmS4rtv+nl/90YeII1yFQRFV2hBU+bUWEoyc1JX0zC0KhbALg3RdphN0RA23pv ZI0dzd1PSwXsESE4gN235sETE/HdTh00uW/Uhbvz2PujcXaFucIbGQLo2JT0iNfTrfXM GICQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=6AOWL8X+6363yl6dlkzkEYMc1TNcmq2VygjKTCBzm64=; b=U/CXM5Oh7Zfe0X+I1iKvJhEyoc4kFRswvMziG+8hadxXIrPXQ24VWara7pFNNBkbP3 Q7mYjN1cJQHD5PXo7Xr4InC3wpqO+Am6XdX53uMk6Lb5jq6CzBnORzuAIUawbAgppvYZ JMybTYC+PtWhf6yuB9z9htJcs6KO+7RDsKf79SoMbzPbRwzOjJ/oRrnF7fmSgIsvoUTL Tnvh2SRBXktez0w74a3ctbS8MH3cpNke6Js+Etsuv5VOT9q54r8wGPACS9xnp0pofZWF ZivHk5/9MGqkO96wIfN//GAhUOfEAK0tYuhbKg62QV9zTQAfTPLrDsh3CajEtKLMHRcw jLTQ== X-Gm-Message-State: ACrzQf3O5Y5k78AD/FpksFUlOwi0E6OybC7M2Oarlbe4SyuegtdIL4mC +kWVEeekDqArMTWMl+LBSqVIvw== X-Google-Smtp-Source: AMsMyM7ywOFavyrwCMGphDto/G9dJRxjhNMo43envFpFsgAU1P4TxjX58T9WeF7u2TcHGBNlDv1A5g== X-Received: by 2002:a05:6512:2304:b0:49b:24a:f0cf with SMTP id o4-20020a056512230400b0049b024af0cfmr709077lfu.373.1663830269640; Thu, 22 Sep 2022 00:04:29 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id f7-20020a056512360700b004994117b0fdsm782114lfs.281.2022.09.22.00.04.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Sep 2022 00:04:29 -0700 (PDT) Message-ID: <02b60bf8-70ac-eb7b-33d7-1c9b7a6f0a54@linaro.org> Date: Thu, 22 Sep 2022 09:04:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml Content-Language: en-US To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Clark , Sean Paul , Abhinav Kumar , Rob Herring , Krzysztof Kozlowski Cc: Stephen Boyd , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org References: <20220915133742.115218-1-dmitry.baryshkov@linaro.org> <20220915133742.115218-6-dmitry.baryshkov@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20220915133742.115218-6-dmitry.baryshkov@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 15/09/2022 15:37, Dmitry Baryshkov wrote: > Move properties common to all MDSS DT nodes to the mdss-common.yaml. > > This extends qcom,msm8998-mdss schema to allow interconnect nodes, which > will be added later, once msm8998 gains interconnect support. > > Signed-off-by: Dmitry Baryshkov > --- (...) > - "#interrupt-cells": > - const: 1 > - > iommus: > - items: > - - description: Phandle to apps_smmu node with SID mask for Hard-Fail port0 > - - description: Phandle to apps_smmu node with SID mask for Hard-Fail port1 > - > - ranges: true > + maxItems: 2 > > interconnects: > - items: > - - description: Interconnect path from mdp0 port to the data bus > - - description: Interconnect path from mdp1 port to the data bus > + maxItems: 2 I think this is not equivalent now, because you have in total minItems:1 and maxItems:2, while in past minItems was 2. The same might apply to iommus. clocks look good. Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 456A1C6FA8B for ; Thu, 22 Sep 2022 07:04:35 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E849210E2F7; Thu, 22 Sep 2022 07:04:33 +0000 (UTC) Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by gabe.freedesktop.org (Postfix) with ESMTPS id 572EB10E2F7 for ; Thu, 22 Sep 2022 07:04:31 +0000 (UTC) Received: by mail-lf1-x12a.google.com with SMTP id x27so13240347lfu.0 for ; Thu, 22 Sep 2022 00:04:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=6AOWL8X+6363yl6dlkzkEYMc1TNcmq2VygjKTCBzm64=; b=bKHOfDZXtMpt20Subxu34+Lu5GEWthnW5vWbQiZd2mWo9MuEdinnZCTL41VaMH+5YA j+BtZuHj0f5UCku2oXQvitvnGdhstHYYf7FYqqlV3wD6KLqi8Lwf2dLw+xybPogs0F65 GsEFETmLMZXbLODHYV4TJb1CE7rEfJWP9Yer/P6SGzJ5pGsfzFq7jj39IEN+lz1YIqRu SNSNgDFmS4rtv+nl/90YeII1yFQRFV2hBU+bUWEoyc1JX0zC0KhbALg3RdphN0RA23pv ZI0dzd1PSwXsESE4gN235sETE/HdTh00uW/Uhbvz2PujcXaFucIbGQLo2JT0iNfTrfXM GICQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=6AOWL8X+6363yl6dlkzkEYMc1TNcmq2VygjKTCBzm64=; b=xSisFY7xnd5zlhdBnHnrIYVBYrDG7KhgUkszLeh3ErpUqmHePxbDuS60KkK9VpJYs3 BSLVz0A5TLFq2wAh2TRI6gMFNkp3scpUtjJWmtJYj/f5KCmv3Y3swf1y9uO9JFulri1f 09O2JY9YjImAGkBmKa1aT5t5IrvR6mzdxE5Wig7dBOzjIz+pTQ2qfweqp9YRO4skzcnr u55l+u4f1Fw3ItzHDtHt+psKB7q7XWeG0YD6nA8RoRrutvCgBbNrMf8FSw7ljB9On6tT IPw99B26yLO6HcC3oCVcIkFICg5/kIndfEi3dmodiH+s1DSe6wrzvK7nHHFZO468H7pb c60Q== X-Gm-Message-State: ACrzQf2zVOd5p+c6S1+kE9bwBlcwUkJsLeklAEVE/JYjYmOqRh0dC7/p JyRaU2L9cS9dqIe8HCg5UlNh/A== X-Google-Smtp-Source: AMsMyM7ywOFavyrwCMGphDto/G9dJRxjhNMo43envFpFsgAU1P4TxjX58T9WeF7u2TcHGBNlDv1A5g== X-Received: by 2002:a05:6512:2304:b0:49b:24a:f0cf with SMTP id o4-20020a056512230400b0049b024af0cfmr709077lfu.373.1663830269640; Thu, 22 Sep 2022 00:04:29 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id f7-20020a056512360700b004994117b0fdsm782114lfs.281.2022.09.22.00.04.28 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Sep 2022 00:04:29 -0700 (PDT) Message-ID: <02b60bf8-70ac-eb7b-33d7-1c9b7a6f0a54@linaro.org> Date: Thu, 22 Sep 2022 09:04:28 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml Content-Language: en-US To: Dmitry Baryshkov , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Clark , Sean Paul , Abhinav Kumar , Rob Herring , Krzysztof Kozlowski References: <20220915133742.115218-1-dmitry.baryshkov@linaro.org> <20220915133742.115218-6-dmitry.baryshkov@linaro.org> From: Krzysztof Kozlowski In-Reply-To: <20220915133742.115218-6-dmitry.baryshkov@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, David Airlie , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, Stephen Boyd , freedreno@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On 15/09/2022 15:37, Dmitry Baryshkov wrote: > Move properties common to all MDSS DT nodes to the mdss-common.yaml. > > This extends qcom,msm8998-mdss schema to allow interconnect nodes, which > will be added later, once msm8998 gains interconnect support. > > Signed-off-by: Dmitry Baryshkov > --- (...) > - "#interrupt-cells": > - const: 1 > - > iommus: > - items: > - - description: Phandle to apps_smmu node with SID mask for Hard-Fail port0 > - - description: Phandle to apps_smmu node with SID mask for Hard-Fail port1 > - > - ranges: true > + maxItems: 2 > > interconnects: > - items: > - - description: Interconnect path from mdp0 port to the data bus > - - description: Interconnect path from mdp1 port to the data bus > + maxItems: 2 I think this is not equivalent now, because you have in total minItems:1 and maxItems:2, while in past minItems was 2. The same might apply to iommus. clocks look good. Best regards, Krzysztof