All of lore.kernel.org
 help / color / mirror / Atom feed
From: Randy Dunlap <rdunlap@infradead.org>
To: Adrian Huang <adrianhuang0701@gmail.com>, linux-fsdevel@vger.kernel.org
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
	Adrian Huang <ahuang12@lenovo.com>
Subject: Re: [PATCH v2 1/1] exec: fix typo and grammar mistake in comment
Date: Mon, 30 Aug 2021 07:19:37 -0700	[thread overview]
Message-ID: <02c0abd5-8776-ba0a-cb76-897e2406ceb0@infradead.org> (raw)
In-Reply-To: <20210830074406.789-1-adrianhuang0701@gmail.com>

On 8/30/21 12:44 AM, Adrian Huang wrote:
> From: Adrian Huang <ahuang12@lenovo.com>
> 
> 1. backwords -> backwards
> 2. Remove 'and' and whitespace
> 3. Correct the possessive form of "process"
> 
> Cc: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Adrian Huang <ahuang12@lenovo.com>

Acked-by: Randy Dunlap <rdunlap@infradead.org>

Thanks.

> ---
> Changes since v2:
>   * Correct possessive form of "process" and fix the grammar, per Randy
> 
>   fs/exec.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/exec.c b/fs/exec.c
> index 38f63451b928..d0e20fedde21 100644
> --- a/fs/exec.c
> +++ b/fs/exec.c
> @@ -504,7 +504,7 @@ static int bprm_stack_limits(struct linux_binprm *bprm)
>   
>   /*
>    * 'copy_strings()' copies argument/environment strings from the old
> - * processes's memory to the new process's stack.  The call to get_user_pages()
> + * process's memory to the new process's stack. The call to get_user_pages()
>    * ensures the destination page is created and not swapped out.
>    */
>   static int copy_strings(int argc, struct user_arg_ptr argv,
> @@ -533,7 +533,7 @@ static int copy_strings(int argc, struct user_arg_ptr argv,
>   		if (!valid_arg_len(bprm, len))
>   			goto out;
>   
> -		/* We're going to work our way backwords. */
> +		/* We're going to work our way backwards. */
>   		pos = bprm->p;
>   		str += len;
>   		bprm->p -= len;
> @@ -600,7 +600,7 @@ static int copy_strings(int argc, struct user_arg_ptr argv,
>   }
>   
>   /*
> - * Copy and argument/environment string from the kernel to the processes stack.
> + * Copy an argument/environment string from the kernel to the process's stack.
>    */
>   int copy_string_kernel(const char *arg, struct linux_binprm *bprm)
>   {
> 


-- 
~Randy


      reply	other threads:[~2021-08-30 14:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-30  7:44 [PATCH v2 1/1] exec: fix typo and grammar mistake in comment Adrian Huang
2021-08-30 14:19 ` Randy Dunlap [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02c0abd5-8776-ba0a-cb76-897e2406ceb0@infradead.org \
    --to=rdunlap@infradead.org \
    --cc=adrianhuang0701@gmail.com \
    --cc=ahuang12@lenovo.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.