All of lore.kernel.org
 help / color / mirror / Atom feed
From: Neil Armstrong <narmstrong@baylibre.com>
To: Mattijs Korpershoek <mkorpershoek@baylibre.com>
Cc: u-boot-amlogic@groups.io, u-boot@lists.denx.de
Subject: Re: [PATCH 3/6] configs: meson64_android: use CONFIG_FASTBOOT_USB_DEV
Date: Thu, 29 Jul 2021 11:22:15 +0200	[thread overview]
Message-ID: <02c1da08-a03d-5e48-c2c9-cdaef7ea54b8@baylibre.com> (raw)
In-Reply-To: <20210729072113.208099-4-mkorpershoek@baylibre.com>

On 29/07/2021 09:21, Mattijs Korpershoek wrote:
> Right now, when running fastboot we use a hard-coded "0" for the
> device number.
> 
> Use the Kconfig option named CONFIG_FASTBOOT_USB_DEV instead.
> 
> Signed-off-by: Guillaume La Roque <mkorpershoek@baylibre.com>
> Signed-off-by: Mattijs Korpershoek <mkorpershoek@baylibre.com>
> ---
>  include/configs/meson64_android.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/configs/meson64_android.h b/include/configs/meson64_android.h
> index 661de76fd7..4027a7fe0d 100644
> --- a/include/configs/meson64_android.h
> +++ b/include/configs/meson64_android.h
> @@ -38,7 +38,7 @@
>  		"fi;" \
>  		"if test \"${run_fastboot}\" -eq 1; then " \
>  			"echo Running Fastboot...;" \
> -			"fastboot 0;" \
> +			"fastboot " __stringify(CONFIG_FASTBOOT_USB_DEV) "; " \
>  		"fi\0"
>  
>  #define BOOTENV_DEV_NAME_FASTBOOT(devtypeu, devtypel, instance)	\
> @@ -69,7 +69,7 @@
>  		"fi;" \
>  		"if test \"${run_recovery}\" -eq 1; then " \
>  			"echo Running Recovery...;" \
> -			"fastboot 0;" \
> +			"fastboot " __stringify(CONFIG_FASTBOOT_USB_DEV) "; " \
>  		"fi\0"
>  
>  #define BOOTENV_DEV_NAME_RECOVERY(devtypeu, devtypel, instance)	\
> 


Acked-by: Neil Armstrong <narmstrong@baylibre.com>

  reply	other threads:[~2021-07-29  9:22 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-29  7:21 [PATCH 0/6] VIM3: misc cleanups to prepare android support Mattijs Korpershoek
2021-07-29  7:21 ` [PATCH 1/6] configs: sei610: fix typo in header comment Mattijs Korpershoek
2021-07-29  9:21   ` Neil Armstrong
2021-07-29  7:21 ` [PATCH 2/6] configs: meson64_android: fix bad indent in EXTRA_ENV_SETTINGS Mattijs Korpershoek
2021-07-29  9:21   ` Neil Armstrong
2021-07-29  7:21 ` [PATCH 3/6] configs: meson64_android: use CONFIG_FASTBOOT_USB_DEV Mattijs Korpershoek
2021-07-29  9:22   ` Neil Armstrong [this message]
2021-07-29  7:21 ` [PATCH 4/6] configs: meson64_android: use boot part label instead of index Mattijs Korpershoek
2021-07-29  9:22   ` Neil Armstrong
2021-07-29  7:21 ` [PATCH 5/6] configs: meson64_android: use logo " Mattijs Korpershoek
2021-07-29  9:22   ` Neil Armstrong
2021-07-29  7:21 ` [PATCH 6/6] configs: meson64_android: don't set console bootargs Mattijs Korpershoek
2021-07-29  9:23   ` Neil Armstrong
2021-07-29  9:37 ` [PATCH 0/6] VIM3: misc cleanups to prepare android support Neil Armstrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02c1da08-a03d-5e48-c2c9-cdaef7ea54b8@baylibre.com \
    --to=narmstrong@baylibre.com \
    --cc=mkorpershoek@baylibre.com \
    --cc=u-boot-amlogic@groups.io \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.