From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A3BDC4338F for ; Thu, 29 Jul 2021 09:22:24 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7BB9A6103B for ; Thu, 29 Jul 2021 09:22:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7BB9A6103B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 1548B82E10; Thu, 29 Jul 2021 11:22:22 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=baylibre-com.20150623.gappssmtp.com header.i=@baylibre-com.20150623.gappssmtp.com header.b="LAyqd9F3"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 0EDE782E10; Thu, 29 Jul 2021 11:22:20 +0200 (CEST) Received: from mail-wr1-x42e.google.com (mail-wr1-x42e.google.com [IPv6:2a00:1450:4864:20::42e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 7FFDC82E4C for ; Thu, 29 Jul 2021 11:22:16 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=narmstrong@baylibre.com Received: by mail-wr1-x42e.google.com with SMTP id z4so6027918wrv.11 for ; Thu, 29 Jul 2021 02:22:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:organization:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vb70hq2mmmZpy8OmLe6j4Nps4lJhZF4grHh/R/G9nQA=; b=LAyqd9F3de23FeqgHFMoKo3nast7oNQWx/NkECOMVTk7iECzWkKRxc/pIH1+/iqGgR 7MCoPCT3XTnQo+d2EjV7lNOAlp2AyWFwwepWCQiRlJnhdlSES4nPaLd0swMsT3+asiED t+8scfLX5jG/0rQ7COiFMvAbwjxVJh2JfK/8/587/sWBa+2bZ0rx+Ml+M4ev63YUQIDN /OGJQW0Yqkn1+aGYRieksMrldTZ5ZA04wVEXAh5Ut2sV1hMZsyEuX1Q19MFgcnb1gOMl hyi5utR1WyJ4MVd4ClLKU0Rkw/6wG3eMiiCJohI5AZfpJjP1jMtD+fs256n7rPD4nRED A76g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=vb70hq2mmmZpy8OmLe6j4Nps4lJhZF4grHh/R/G9nQA=; b=TBDaYqZAYGBZ9QimxZW0JrVoflRK7nH5yTk48mxQn5eWxLMbll7RvOMzQME11qIaOd hgInJ9W7XQjV0+BxBefSW0/xTkTn7Nji7YSxS2x5PZI8Xr28LrIlkD3oyB3XNFKDhrI2 /96b3HRbHLrs/MRqLFNz4yjB1OaL+uda1A3LC6M2VRqLEE6ZS+Q/GmvcsXoL1N7z2Fhv jpgzL3oIKE4sJEWzkj7Ed4ZuLl4E/Kl3wS/zDMvWNBvTuCBMVZswqq+3Que+GCE/mJ+j B4cQ1F970Ugi90O2Rpt6AISk7zxOjkkooEqjWIJF2ib5uInhCgH/0QOkIkC5rjWKE5sb HoHg== X-Gm-Message-State: AOAM532e1rh7oan5TgDq12MJ8MMjdq+AjakJjNIl2+yWTUlXP1ikIGnc U7mInX/oIJGCUTGRQP2pamtH3i7NZI00sXbd X-Google-Smtp-Source: ABdhPJxSMscYO1Ix8pA5YLM5scF8fGiaqSWM8Y9XrdhbZSILS9V4WKQ7fNCYQhKIMFXb1310Q91Aqg== X-Received: by 2002:a5d:4207:: with SMTP id n7mr3752647wrq.326.1627550535442; Thu, 29 Jul 2021 02:22:15 -0700 (PDT) Received: from [10.1.3.29] (laubervilliers-658-1-213-31.w90-63.abo.wanadoo.fr. [90.63.244.31]) by smtp.gmail.com with ESMTPSA id s1sm8431711wmj.8.2021.07.29.02.22.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Jul 2021 02:22:15 -0700 (PDT) Subject: Re: [PATCH 3/6] configs: meson64_android: use CONFIG_FASTBOOT_USB_DEV To: Mattijs Korpershoek Cc: u-boot-amlogic@groups.io, u-boot@lists.denx.de References: <20210729072113.208099-1-mkorpershoek@baylibre.com> <20210729072113.208099-4-mkorpershoek@baylibre.com> From: Neil Armstrong Organization: Baylibre Message-ID: <02c1da08-a03d-5e48-c2c9-cdaef7ea54b8@baylibre.com> Date: Thu, 29 Jul 2021 11:22:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210729072113.208099-4-mkorpershoek@baylibre.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On 29/07/2021 09:21, Mattijs Korpershoek wrote: > Right now, when running fastboot we use a hard-coded "0" for the > device number. > > Use the Kconfig option named CONFIG_FASTBOOT_USB_DEV instead. > > Signed-off-by: Guillaume La Roque > Signed-off-by: Mattijs Korpershoek > --- > include/configs/meson64_android.h | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/include/configs/meson64_android.h b/include/configs/meson64_android.h > index 661de76fd7..4027a7fe0d 100644 > --- a/include/configs/meson64_android.h > +++ b/include/configs/meson64_android.h > @@ -38,7 +38,7 @@ > "fi;" \ > "if test \"${run_fastboot}\" -eq 1; then " \ > "echo Running Fastboot...;" \ > - "fastboot 0;" \ > + "fastboot " __stringify(CONFIG_FASTBOOT_USB_DEV) "; " \ > "fi\0" > > #define BOOTENV_DEV_NAME_FASTBOOT(devtypeu, devtypel, instance) \ > @@ -69,7 +69,7 @@ > "fi;" \ > "if test \"${run_recovery}\" -eq 1; then " \ > "echo Running Recovery...;" \ > - "fastboot 0;" \ > + "fastboot " __stringify(CONFIG_FASTBOOT_USB_DEV) "; " \ > "fi\0" > > #define BOOTENV_DEV_NAME_RECOVERY(devtypeu, devtypel, instance) \ > Acked-by: Neil Armstrong