From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6549DC433F5 for ; Wed, 15 Sep 2021 09:09:11 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B50EB61244 for ; Wed, 15 Sep 2021 09:09:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B50EB61244 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=amsat.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:46462 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mQQuh-000558-Rh for qemu-devel@archiver.kernel.org; Wed, 15 Sep 2021 05:09:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48638) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQQnX-00077L-QH; Wed, 15 Sep 2021 05:01:49 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:40480) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQQnT-0002T1-5h; Wed, 15 Sep 2021 05:01:41 -0400 Received: by mail-wr1-x436.google.com with SMTP id q26so2636891wrc.7; Wed, 15 Sep 2021 02:01:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=j3jtMg6tDjm0gVjE3OELyjopFcMxx8AQlZ8vd5URQO4=; b=mahtxW9eOWHlVnUMrr5PBLIonqPktxsxGYL8SP3V6/6UvXQ9b51bBo3bdSxxcGpBn0 rmTTZrlpx7dT7IxKMyOcfab3Z1ICBxNSMzZmixPiULi75qr9bUW+wkTOerGBJlvbXAnp 2dvturD5MGs+S1pEkPqTi93njSD6iVRgp1hd4L+6sz5WBfVBXvBtsvKAKDIrXaEvhKQN DtDya08NN7WiorUsS9LOy8vFSeAFn012qh9K9tTYZyPuPTIwyD+dvthUe66WmgpdRn+o s81U0tG+eDVR+VhTsC/IMLhH9M915yjPilPTUS4q7RMtrJcleg/QpaAjpDkCYqg2WjGG ZmlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=j3jtMg6tDjm0gVjE3OELyjopFcMxx8AQlZ8vd5URQO4=; b=SvlSdY3LPpbST/DMZ13558m3+lUXHMarOgDAtKuC3fkDvpEaZ3DPHYG4mjZg2IvPah xubIFiBq72BLnSt1qCVnJOiSs8hXqdzOuYTtGuOh/BpPyQJBm0eA/uuidsxxyw5P7nmD o5tfRTm6t2Lj6kC84e8TSYsBKwq6j1Wj0DUz2DhmM+zpxIUiOtrSzcchkV7uIHBrQz9Z 9BFQwzh98GZ0H0wLx852polua+RYaWMLryW5vgDC/cdeiPub95eHzDhmN4a1Xo7SuC4l P3TYMMjKa3HJjcAc1l27/ParOCjA8LD49cmdvLkjZH3+nnoPkkPpVYn9/ab4flWm82ay vi8Q== X-Gm-Message-State: AOAM5304MKFmXtB2o6eRSFBXvv1MtOVbBKyK75kCk4Mnu7SDHNTkqWND lvbMWfiZfcisUA4GNEZeeWU= X-Google-Smtp-Source: ABdhPJzQNwbb4RwLbLsi8Q7aSnJBvaJWo3+mB7NnOB9zEfDejOQWBlcsoJVDwAcdy5UE9FOG2iXE6w== X-Received: by 2002:a5d:58cf:: with SMTP id o15mr3644881wrf.312.1631696496278; Wed, 15 Sep 2021 02:01:36 -0700 (PDT) Received: from [192.168.1.36] (14.red-83-35-25.dynamicip.rima-tde.net. [83.35.25.14]) by smtp.gmail.com with ESMTPSA id c14sm13169948wrr.58.2021.09.15.02.01.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Sep 2021 02:01:35 -0700 (PDT) Subject: Re: [PATCH v2 27/53] target/xtensa: convert to use format_state instead of dump_state To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= References: <20210914142042.1655100-1-berrange@redhat.com> <20210914142042.1655100-28-berrange@redhat.com> <1cb38e8f-cc05-461a-c722-efb18519f6fe@amsat.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <02d057e4-87c5-318a-c3f4-41512b198169@amsat.org> Date: Wed, 15 Sep 2021 11:01:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x436.google.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-1.969, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , Chris Wulff , David Hildenbrand , Bin Meng , Mark Cave-Ayland , qemu-devel@nongnu.org, Peter Xu , Max Filippov , Taylor Simpson , Alistair Francis , Gerd Hoffmann , Eric Blake , Marek Vasut , Yoshinori Sato , Markus Armbruster , Halil Pasic , Christian Borntraeger , Palmer Dabbelt , Artyom Tarasenko , Laurent Vivier , Thomas Huth , Eduardo Habkost , Richard Henderson , Greg Kurz , Yuval Shaia , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Michael Rolnik , "Dr. David Alan Gilbert" , Stafford Horne , David Gibson , qemu-riscv@nongnu.org, Bastian Koppelmann , Cornelia Huck , Laurent Vivier , qemu-ppc@nongnu.org, Paolo Bonzini , Aleksandar Rikalo , Aurelien Jarno Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 9/15/21 10:52 AM, Daniel P. Berrangé wrote: > On Wed, Sep 15, 2021 at 09:32:38AM +0200, Philippe Mathieu-Daudé wrote: >> On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: >>> Signed-off-by: Daniel P. Berrangé >>> --- >>> target/xtensa/cpu.c | 2 +- >>> target/xtensa/cpu.h | 2 +- >>> target/xtensa/translate.c | 45 ++++++++++++++++++++------------------- >>> 3 files changed, 25 insertions(+), 24 deletions(-) >> >>> -void xtensa_cpu_dump_state(CPUState *cs, FILE *f, int flags) >>> +void xtensa_cpu_format_state(CPUState *cs, GString *buf, int flags) >>> { >>> XtensaCPU *cpu = XTENSA_CPU(cs); >>> CPUXtensaState *env = &cpu->env; >>> xtensa_isa isa = env->config->isa; >>> int i, j; >>> >>> - qemu_fprintf(f, "PC=%08x\n\n", env->pc); >>> + g_string_append_printf(buf, "PC=%08x\n\n", env->pc); >>> >>> for (i = j = 0; i < xtensa_isa_num_sysregs(isa); ++i) { >>> const uint32_t *reg = >>> @@ -1340,55 +1340,56 @@ void xtensa_cpu_dump_state(CPUState *cs, FILE *f, int flags) >>> int regno = xtensa_sysreg_number(isa, i); >>> >>> if (regno >= 0) { >>> - qemu_fprintf(f, "%12s=%08x%c", >>> - xtensa_sysreg_name(isa, i), >>> - reg[regno], >>> - (j++ % 4) == 3 ? '\n' : ' '); >>> + g_string_append_printf(buf, "%12s=%08x%c", >>> + xtensa_sysreg_name(isa, i), >>> + reg[regno], >>> + (j++ % 4) == 3 ? '\n' : ' '); >>> } >>> } >>> >>> - qemu_fprintf(f, (j % 4) == 0 ? "\n" : "\n\n"); >>> + g_string_append_printf(buf, (j % 4) == 0 ? "\n" : "\n\n"); >>> >>> for (i = 0; i < 16; ++i) { >>> - qemu_fprintf(f, " A%02d=%08x%c", >>> - i, env->regs[i], (i % 4) == 3 ? '\n' : ' '); >>> + g_string_append_printf(buf, " A%02d=%08x%c", >>> + i, env->regs[i], (i % 4) == 3 ? '\n' : ' '); >>> } >>> >>> xtensa_sync_phys_from_window(env); >>> - qemu_fprintf(f, "\n"); >>> + g_string_append_printf(buf, "\n"); >> >> g_string_append_c(); pre-existing but better to move it before >> xtensa_sync_phys_from_window(). > > I don't want to be re-arranging the code in this series. It is just > a straight search/replace of qemu_fprintf with g_string_append_printf, > with the bare minimum of other changes, to minimize risk of breaking > something unexpected. Fair enough. Max already rejected my suggestions ;) So: Reviewed-by: Philippe Mathieu-Daudé From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mQQnh-0007A1-QO for mharc-qemu-riscv@gnu.org; Wed, 15 Sep 2021 05:01:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48638) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mQQnX-00077L-QH; Wed, 15 Sep 2021 05:01:49 -0400 Received: from mail-wr1-x436.google.com ([2a00:1450:4864:20::436]:40480) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mQQnT-0002T1-5h; Wed, 15 Sep 2021 05:01:41 -0400 Received: by mail-wr1-x436.google.com with SMTP id q26so2636891wrc.7; Wed, 15 Sep 2021 02:01:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=j3jtMg6tDjm0gVjE3OELyjopFcMxx8AQlZ8vd5URQO4=; b=mahtxW9eOWHlVnUMrr5PBLIonqPktxsxGYL8SP3V6/6UvXQ9b51bBo3bdSxxcGpBn0 rmTTZrlpx7dT7IxKMyOcfab3Z1ICBxNSMzZmixPiULi75qr9bUW+wkTOerGBJlvbXAnp 2dvturD5MGs+S1pEkPqTi93njSD6iVRgp1hd4L+6sz5WBfVBXvBtsvKAKDIrXaEvhKQN DtDya08NN7WiorUsS9LOy8vFSeAFn012qh9K9tTYZyPuPTIwyD+dvthUe66WmgpdRn+o s81U0tG+eDVR+VhTsC/IMLhH9M915yjPilPTUS4q7RMtrJcleg/QpaAjpDkCYqg2WjGG ZmlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=j3jtMg6tDjm0gVjE3OELyjopFcMxx8AQlZ8vd5URQO4=; b=SvlSdY3LPpbST/DMZ13558m3+lUXHMarOgDAtKuC3fkDvpEaZ3DPHYG4mjZg2IvPah xubIFiBq72BLnSt1qCVnJOiSs8hXqdzOuYTtGuOh/BpPyQJBm0eA/uuidsxxyw5P7nmD o5tfRTm6t2Lj6kC84e8TSYsBKwq6j1Wj0DUz2DhmM+zpxIUiOtrSzcchkV7uIHBrQz9Z 9BFQwzh98GZ0H0wLx852polua+RYaWMLryW5vgDC/cdeiPub95eHzDhmN4a1Xo7SuC4l P3TYMMjKa3HJjcAc1l27/ParOCjA8LD49cmdvLkjZH3+nnoPkkPpVYn9/ab4flWm82ay vi8Q== X-Gm-Message-State: AOAM5304MKFmXtB2o6eRSFBXvv1MtOVbBKyK75kCk4Mnu7SDHNTkqWND lvbMWfiZfcisUA4GNEZeeWU= X-Google-Smtp-Source: ABdhPJzQNwbb4RwLbLsi8Q7aSnJBvaJWo3+mB7NnOB9zEfDejOQWBlcsoJVDwAcdy5UE9FOG2iXE6w== X-Received: by 2002:a5d:58cf:: with SMTP id o15mr3644881wrf.312.1631696496278; Wed, 15 Sep 2021 02:01:36 -0700 (PDT) Received: from [192.168.1.36] (14.red-83-35-25.dynamicip.rima-tde.net. [83.35.25.14]) by smtp.gmail.com with ESMTPSA id c14sm13169948wrr.58.2021.09.15.02.01.34 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 15 Sep 2021 02:01:35 -0700 (PDT) Sender: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Subject: Re: [PATCH v2 27/53] target/xtensa: convert to use format_state instead of dump_state To: =?UTF-8?Q?Daniel_P=2e_Berrang=c3=a9?= Cc: Peter Maydell , Cornelia Huck , David Hildenbrand , Bin Meng , Mark Cave-Ayland , qemu-devel@nongnu.org, Peter Xu , Max Filippov , Taylor Simpson , Alistair Francis , Gerd Hoffmann , Eric Blake , Marek Vasut , Yoshinori Sato , Markus Armbruster , Halil Pasic , Christian Borntraeger , qemu-ppc@nongnu.org, Artyom Tarasenko , Laurent Vivier , Thomas Huth , Eduardo Habkost , Richard Henderson , Greg Kurz , Yuval Shaia , qemu-s390x@nongnu.org, qemu-arm@nongnu.org, Michael Rolnik , Stafford Horne , David Gibson , qemu-riscv@nongnu.org, Bastian Koppelmann , Chris Wulff , Laurent Vivier , Palmer Dabbelt , Aurelien Jarno , Paolo Bonzini , Aleksandar Rikalo , "Dr. David Alan Gilbert" References: <20210914142042.1655100-1-berrange@redhat.com> <20210914142042.1655100-28-berrange@redhat.com> <1cb38e8f-cc05-461a-c722-efb18519f6fe@amsat.org> From: =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= Message-ID: <02d057e4-87c5-318a-c3f4-41512b198169@amsat.org> Date: Wed, 15 Sep 2021 11:01:33 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::436; envelope-from=philippe.mathieu.daude@gmail.com; helo=mail-wr1-x436.google.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, NICE_REPLY_A=-1.969, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-riscv@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Sep 2021 09:01:49 -0000 On 9/15/21 10:52 AM, Daniel P. Berrangé wrote: > On Wed, Sep 15, 2021 at 09:32:38AM +0200, Philippe Mathieu-Daudé wrote: >> On 9/14/21 4:20 PM, Daniel P. Berrangé wrote: >>> Signed-off-by: Daniel P. Berrangé >>> --- >>> target/xtensa/cpu.c | 2 +- >>> target/xtensa/cpu.h | 2 +- >>> target/xtensa/translate.c | 45 ++++++++++++++++++++------------------- >>> 3 files changed, 25 insertions(+), 24 deletions(-) >> >>> -void xtensa_cpu_dump_state(CPUState *cs, FILE *f, int flags) >>> +void xtensa_cpu_format_state(CPUState *cs, GString *buf, int flags) >>> { >>> XtensaCPU *cpu = XTENSA_CPU(cs); >>> CPUXtensaState *env = &cpu->env; >>> xtensa_isa isa = env->config->isa; >>> int i, j; >>> >>> - qemu_fprintf(f, "PC=%08x\n\n", env->pc); >>> + g_string_append_printf(buf, "PC=%08x\n\n", env->pc); >>> >>> for (i = j = 0; i < xtensa_isa_num_sysregs(isa); ++i) { >>> const uint32_t *reg = >>> @@ -1340,55 +1340,56 @@ void xtensa_cpu_dump_state(CPUState *cs, FILE *f, int flags) >>> int regno = xtensa_sysreg_number(isa, i); >>> >>> if (regno >= 0) { >>> - qemu_fprintf(f, "%12s=%08x%c", >>> - xtensa_sysreg_name(isa, i), >>> - reg[regno], >>> - (j++ % 4) == 3 ? '\n' : ' '); >>> + g_string_append_printf(buf, "%12s=%08x%c", >>> + xtensa_sysreg_name(isa, i), >>> + reg[regno], >>> + (j++ % 4) == 3 ? '\n' : ' '); >>> } >>> } >>> >>> - qemu_fprintf(f, (j % 4) == 0 ? "\n" : "\n\n"); >>> + g_string_append_printf(buf, (j % 4) == 0 ? "\n" : "\n\n"); >>> >>> for (i = 0; i < 16; ++i) { >>> - qemu_fprintf(f, " A%02d=%08x%c", >>> - i, env->regs[i], (i % 4) == 3 ? '\n' : ' '); >>> + g_string_append_printf(buf, " A%02d=%08x%c", >>> + i, env->regs[i], (i % 4) == 3 ? '\n' : ' '); >>> } >>> >>> xtensa_sync_phys_from_window(env); >>> - qemu_fprintf(f, "\n"); >>> + g_string_append_printf(buf, "\n"); >> >> g_string_append_c(); pre-existing but better to move it before >> xtensa_sync_phys_from_window(). > > I don't want to be re-arranging the code in this series. It is just > a straight search/replace of qemu_fprintf with g_string_append_printf, > with the bare minimum of other changes, to minimize risk of breaking > something unexpected. Fair enough. Max already rejected my suggestions ;) So: Reviewed-by: Philippe Mathieu-Daudé