From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A31EC43461 for ; Thu, 17 Sep 2020 12:56:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 28611221E7 for ; Thu, 17 Sep 2020 12:56:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=axentia.se header.i=@axentia.se header.b="hncvn+iv" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727102AbgIQMz4 (ORCPT ); Thu, 17 Sep 2020 08:55:56 -0400 Received: from mail-eopbgr60103.outbound.protection.outlook.com ([40.107.6.103]:22257 "EHLO EUR04-DB3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727118AbgIQMxw (ORCPT ); Thu, 17 Sep 2020 08:53:52 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F6mZwmstit6AnovMAu8eMQ3KW5R9/m5Mepgv+TKrxAt7KExpsFmZaKgYV/WJlEJ991iE3pHo4MAEEm3HsT7RKpEUIHSkA99fiGrFJKfHBMGBXmsQ3wZ7TbbQUL/RLwT3sjq0yYolPW2xMP4w+coji55VcxAo2dPSw9qpppE4Jja0LGz9566oxvbUP6KdzGTk4CX2+8iM43nibZgbV0vo5GiK6k1lTjX7mKodDL4a6nftKbgmhqBZyvswWvGpKVzfgqDwatkW68ew4TNqMOmU4CLbFpzFscKnSPaqTX7kyiD1hrBwQtHwj3ZeMbWrx7fBfgUsamYnJPy2hDNPq9b6aA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FJ7xLLSWmCCFjyGM+3ppYpPCn6c0lzRR0uXjAYHNFKc=; b=cPbGXeLUZfBe2KQIK9d75i44UuiuVGuh04y3yp/P5Zdj8rAT7xueuGE7DAbZljUjPSkLV0v9v1nDLJMZZmspebHWfq3QTDNUc7LEypVDFEoTV/H5s7VfXAv28CqqG/CgVL3UTqtNPgoSJnXnPk/AsDshO2WYDvPNhLZAfzNjxbTeY0ukX94V0ZujZ+m5dJ6obKlIkq7UEfv2xZBHLp9SEXwlq/b/oZ85hHm/ITgdo8VoidaBW2RF+Ak8crliRFp2fAlt91fUhnHpKZiT+PuCFFaOWz8/OptdNcKPK6LfN4QiQKjux/HQvh4JI8nngLZhV/gLhQb7ER0/+zaRt8iQpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=axentia.se; dmarc=pass action=none header.from=axentia.se; dkim=pass header.d=axentia.se; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axentia.se; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FJ7xLLSWmCCFjyGM+3ppYpPCn6c0lzRR0uXjAYHNFKc=; b=hncvn+iv7qIrFufsDeJcrJGS6KxhLzI+4UBRyj84TfFEKzEakqC6gBPb9vnT8MLNaBpdvBeg0LeoyApDWr/8+mrgSkxYl99BPQWfIJXyLmecubfIo2VaF9kIBLsRtSJswkh7BHRnvzoVVg9riIS6inKHjpsS6jEbkJqhE/PosbE= Authentication-Results: ti.com; dkim=none (message not signed) header.d=none;ti.com; dmarc=none action=none header.from=axentia.se; Received: from DB8PR02MB5482.eurprd02.prod.outlook.com (2603:10a6:10:eb::29) by DBAPR02MB6485.eurprd02.prod.outlook.com (2603:10a6:10:19d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.13; Thu, 17 Sep 2020 12:53:46 +0000 Received: from DB8PR02MB5482.eurprd02.prod.outlook.com ([fe80::3890:7b1:97a6:1e47]) by DB8PR02MB5482.eurprd02.prod.outlook.com ([fe80::3890:7b1:97a6:1e47%7]) with mapi id 15.20.3391.011; Thu, 17 Sep 2020 12:53:45 +0000 Subject: Re: [PATCH v3 1/6] dt-bindings: mux-j7200-wiz: Add lane function defines To: Nishanth Menon Cc: Roger Quadros , t-kristo@ti.com, robh+dt@kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, nsekhar@ti.com, kishon@ti.com References: <20200915112038.30219-1-rogerq@ti.com> <20200915112038.30219-2-rogerq@ti.com> <20200916154536.m552ft2jzfsaeokr@akan> <20200917122703.ojuzn6b3tvqbnssc@akan> From: Peter Rosin Organization: Axentia Technologies AB Message-ID: <02d57a88-ba7a-5944-8053-8f4ad03242d2@axentia.se> Date: Thu, 17 Sep 2020 14:53:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 In-Reply-To: <20200917122703.ojuzn6b3tvqbnssc@akan> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: HE1PR0701CA0046.eurprd07.prod.outlook.com (2603:10a6:3:9e::14) To DB8PR02MB5482.eurprd02.prod.outlook.com (2603:10a6:10:eb::29) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.13.3] (85.226.217.78) by HE1PR0701CA0046.eurprd07.prod.outlook.com (2603:10a6:3:9e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.4 via Frontend Transport; Thu, 17 Sep 2020 12:53:43 +0000 X-Originating-IP: [85.226.217.78] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e07bf107-963f-4db6-219e-08d85b08b674 X-MS-TrafficTypeDiagnostic: DBAPR02MB6485: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vUpRBS/j6nYjO+qq0FIftnVUH7mOVWjN/iZWJyP0eiaelcYJFhuSXcSqMDIaqLTdWJKju7ftTPQycKQoaUBP7i1Rqh3lIX9qnogRU0Mg2OEf9laHbOZt6VgvYpNV0MNT79+z1u99yLLuyQqEp9Ne1aLnjvsmuTUMzXIINIppQbrae/+OET7kPmhUlXFFCjtGNA4RyycJqr9727zCg1DAYs/TgMiE1k9qSgnFBc3Y/n4vfC07BfuoGgAyHsRPXReUuVpmjctXIxTh5U7vaHktEUrJQMPyHjFb0vyv+zaUQvqWTvT0qvMyxikIk7yDr1K/6D5YDbMf4/a4gGZ7dCWBOs45adeGIVd/hH3Y2wiFNv1LNIiVAdqWEr/37dIazC19 X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DB8PR02MB5482.eurprd02.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(346002)(39830400003)(376002)(136003)(396003)(31696002)(6916009)(5660300002)(2906002)(36916002)(8676002)(52116002)(4326008)(53546011)(86362001)(186003)(26005)(83380400001)(16526019)(31686004)(36756003)(66556008)(66946007)(6666004)(478600001)(16576012)(956004)(2616005)(316002)(6486002)(8936002)(66476007)(43740500002);DIR:OUT;SFP:1102; X-MS-Exchange-AntiSpam-MessageData: tktUZYyJEQ2hAht5jKiRJeis7bXXBAGoH/nIL6vBlpVtmK/YqxhMeQmUHjZ0g1nJyRxvl5OkMMTwBlPn4O090Mi58onXZGspHWtgHdboW+VhSP5koD9bwo+QvOwNDZ2/INcaUiLcaQhobOBSTkfjbMiRrIRXS5iuV4MWspV7/j17KgMnIXuw93sZOhIBEOTe6dxCJ2q9sLsTjxI4qO0MPMvbYg1hqTvfLiYedX2ieg069n3R/NtyqByHoKzQmbUbEx++ZKV2WNIO8tU4YJrFYY1LkyFUSLxDYEs056kJv/vovDArSAJS+iyHRntDEU3TLHdaQoK0EG3UjcfIPXXn96BhbUIeDqfGhjGPESApquAWuZrFhV/xdEkMGIDxuOSuD9FAzWdYbkSBCBVLUoRSMj87Ui8xd393qE0MYqs7Brnnr3ahb3gYU9JRVDw7TsXe9Djd944wwm2i2GObTFhRH4PZvsdueupRjssrHDPnGk2k7fr39c2DUt9n52Ba2A0eiP0DtwVfnoFG0zbshD7j4KoN1HafsGFiXc7g3pybKalc5IjF5SWcYaXbelNlOQ+PAZFW/ZhDZUgZ1u1oU0wPB5FrKDgpu6dA6zm68tb0Cbtkk0Kp+0dJXuJP2pCuqRgLst1CMyWe6UYuqP+lQ7dnJg== X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-Network-Message-Id: e07bf107-963f-4db6-219e-08d85b08b674 X-MS-Exchange-CrossTenant-AuthSource: DB8PR02MB5482.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2020 12:53:45.4373 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uDLfuoDsM47XqL3Fkwi5msPPIgdOQZGk7re9Me/JBB5JqMz4ISn4Yj07cnTOctaE X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR02MB6485 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2020-09-17 14:27, Nishanth Menon wrote: > On 11:45-20200917, Peter Rosin wrote: > [...] >> >>>> Should not the defines start with J7200_WIZ? SERDES0 seems like a too >>>> generic prefix, at least to me. >>> >>> Thanks, good point. I am not sure if WIZ should even be used.. It is >>> a TI internal prefix for various serdes solutions, but I agree that >>> SERDES0 is too generic a terminology. That said, we should cleanup >>> include/dt-bindings/mux/mux-j721e-wiz.h as well, prior to introducing >>> j7200 changes. >> >> Right. As maintainer for the directory in question, I should have >> been on Cc for that series too, but it appears I wasn't. Hence, I > > yes, you should have been. The following commit introduced it. > > commit b766e3b0d5f6 ("arm64: dts: ti: k3-j721e-main: Add system controller > node and SERDES lane mux") > >> didn't notice that file until now when I went looking for it. Why >> wasn't I on Cc? > > Got through the SoC tree - an oversight on our part[1] and should'nt have, > Apologies on the bad call. > > I would like to propose the following: > a) The header should be renamed to be something more human friendly. > b) The header should be renamed to be something TI specific and NOT per > TI SoC. > c) The macros need renaming to be less generic as it stands right now. > > > If you ack the changes, I am guessing that the changes will impact dts > a lot and would rather take the cleanups through SoC tree to maintain > bisectability? OR I can pick on an immutable tag from you with just the > header file change and pick on the dts - but I doubt that would be > bisectable. Just worried that I have picked a bunch of cleanups already > on the dts for 5.10, and would like to avoid a merge conflict. [Our mails crossed.] I do not have a tree and dt-patches should normally not go *through* me. But I'd still like to see what's happening. I did not realize this was going to cause a *lot* of churn in the dt files. How bad can it be when the file is new in this cycle? And is it worth it? But it seems you all see problems with the current naming and in that case it must surely be better to fix it early? And if it's a lot, maybe it needs to be more than one patch? I get the feeling this will need to be taken care of by someone other than me, because I'm just the maintainer of a very small subsystem and I don't normally have to deal with "big" issues involving several trees. I would be a bottleneck. Cheers, Peter From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92AA6C43461 for ; Thu, 17 Sep 2020 12:55:12 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0E3D9221E3 for ; Thu, 17 Sep 2020 12:55:12 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="csmjrW9Y"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=axentia.se header.i=@axentia.se header.b="hncvn+iv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0E3D9221E3 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=axentia.se Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:In-Reply-To:Date:Message-ID:From: References:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=gzAkIC8tUxa9EmkcQlFQSEsq4b4GIuZJSUV+v7fJ3BI=; b=csmjrW9YFifTVz6C5PrkQd7YN 7bItjBWNdkgUa5Ndlsfseg2QPnnzIhPol76pLEmf34osY4YqFUIyy3p9jEgUM8FIRJ0iByhV8QIar Upv7s8/s5pDEjUnPNLxHxTt7fJjGWpaT9NRIl51D/39X7SnSCJpxqYNlqHRephVasVhfRQjZr5Cp+ cJt7Uvdb02WRmr8Tx2Q/gNFa/9/+CnQEZwavC3s8Q9w+PzLakHcaE2USHw3SFeUuJV/dx/gahj8ai 88IXpF9P6lWsN6fW2RmNn6IPk6sEM7ITvNNSWioLTAcLCddEeieUNtgLQ4pnE9kXqHpz2WZmmwXjk topFm5l4A==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kItQ7-0006xl-ND; Thu, 17 Sep 2020 12:53:51 +0000 Received: from mail-eopbgr60091.outbound.protection.outlook.com ([40.107.6.91] helo=EUR04-DB3-obe.outbound.protection.outlook.com) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kItQ5-0006wo-VH for linux-arm-kernel@lists.infradead.org; Thu, 17 Sep 2020 12:53:50 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F6mZwmstit6AnovMAu8eMQ3KW5R9/m5Mepgv+TKrxAt7KExpsFmZaKgYV/WJlEJ991iE3pHo4MAEEm3HsT7RKpEUIHSkA99fiGrFJKfHBMGBXmsQ3wZ7TbbQUL/RLwT3sjq0yYolPW2xMP4w+coji55VcxAo2dPSw9qpppE4Jja0LGz9566oxvbUP6KdzGTk4CX2+8iM43nibZgbV0vo5GiK6k1lTjX7mKodDL4a6nftKbgmhqBZyvswWvGpKVzfgqDwatkW68ew4TNqMOmU4CLbFpzFscKnSPaqTX7kyiD1hrBwQtHwj3ZeMbWrx7fBfgUsamYnJPy2hDNPq9b6aA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FJ7xLLSWmCCFjyGM+3ppYpPCn6c0lzRR0uXjAYHNFKc=; b=cPbGXeLUZfBe2KQIK9d75i44UuiuVGuh04y3yp/P5Zdj8rAT7xueuGE7DAbZljUjPSkLV0v9v1nDLJMZZmspebHWfq3QTDNUc7LEypVDFEoTV/H5s7VfXAv28CqqG/CgVL3UTqtNPgoSJnXnPk/AsDshO2WYDvPNhLZAfzNjxbTeY0ukX94V0ZujZ+m5dJ6obKlIkq7UEfv2xZBHLp9SEXwlq/b/oZ85hHm/ITgdo8VoidaBW2RF+Ak8crliRFp2fAlt91fUhnHpKZiT+PuCFFaOWz8/OptdNcKPK6LfN4QiQKjux/HQvh4JI8nngLZhV/gLhQb7ER0/+zaRt8iQpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=axentia.se; dmarc=pass action=none header.from=axentia.se; dkim=pass header.d=axentia.se; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=axentia.se; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=FJ7xLLSWmCCFjyGM+3ppYpPCn6c0lzRR0uXjAYHNFKc=; b=hncvn+iv7qIrFufsDeJcrJGS6KxhLzI+4UBRyj84TfFEKzEakqC6gBPb9vnT8MLNaBpdvBeg0LeoyApDWr/8+mrgSkxYl99BPQWfIJXyLmecubfIo2VaF9kIBLsRtSJswkh7BHRnvzoVVg9riIS6inKHjpsS6jEbkJqhE/PosbE= Authentication-Results: ti.com; dkim=none (message not signed) header.d=none;ti.com; dmarc=none action=none header.from=axentia.se; Received: from DB8PR02MB5482.eurprd02.prod.outlook.com (2603:10a6:10:eb::29) by DBAPR02MB6485.eurprd02.prod.outlook.com (2603:10a6:10:19d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.13; Thu, 17 Sep 2020 12:53:46 +0000 Received: from DB8PR02MB5482.eurprd02.prod.outlook.com ([fe80::3890:7b1:97a6:1e47]) by DB8PR02MB5482.eurprd02.prod.outlook.com ([fe80::3890:7b1:97a6:1e47%7]) with mapi id 15.20.3391.011; Thu, 17 Sep 2020 12:53:45 +0000 Subject: Re: [PATCH v3 1/6] dt-bindings: mux-j7200-wiz: Add lane function defines To: Nishanth Menon References: <20200915112038.30219-1-rogerq@ti.com> <20200915112038.30219-2-rogerq@ti.com> <20200916154536.m552ft2jzfsaeokr@akan> <20200917122703.ojuzn6b3tvqbnssc@akan> From: Peter Rosin Organization: Axentia Technologies AB Message-ID: <02d57a88-ba7a-5944-8053-8f4ad03242d2@axentia.se> Date: Thu, 17 Sep 2020 14:53:38 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 In-Reply-To: <20200917122703.ojuzn6b3tvqbnssc@akan> Content-Language: en-US X-ClientProxiedBy: HE1PR0701CA0046.eurprd07.prod.outlook.com (2603:10a6:3:9e::14) To DB8PR02MB5482.eurprd02.prod.outlook.com (2603:10a6:10:eb::29) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.13.3] (85.226.217.78) by HE1PR0701CA0046.eurprd07.prod.outlook.com (2603:10a6:3:9e::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3412.4 via Frontend Transport; Thu, 17 Sep 2020 12:53:43 +0000 X-Originating-IP: [85.226.217.78] X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e07bf107-963f-4db6-219e-08d85b08b674 X-MS-TrafficTypeDiagnostic: DBAPR02MB6485: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:9508; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: vUpRBS/j6nYjO+qq0FIftnVUH7mOVWjN/iZWJyP0eiaelcYJFhuSXcSqMDIaqLTdWJKju7ftTPQycKQoaUBP7i1Rqh3lIX9qnogRU0Mg2OEf9laHbOZt6VgvYpNV0MNT79+z1u99yLLuyQqEp9Ne1aLnjvsmuTUMzXIINIppQbrae/+OET7kPmhUlXFFCjtGNA4RyycJqr9727zCg1DAYs/TgMiE1k9qSgnFBc3Y/n4vfC07BfuoGgAyHsRPXReUuVpmjctXIxTh5U7vaHktEUrJQMPyHjFb0vyv+zaUQvqWTvT0qvMyxikIk7yDr1K/6D5YDbMf4/a4gGZ7dCWBOs45adeGIVd/hH3Y2wiFNv1LNIiVAdqWEr/37dIazC19 X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB8PR02MB5482.eurprd02.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(346002)(39830400003)(376002)(136003)(396003)(31696002)(6916009)(5660300002)(2906002)(36916002)(8676002)(52116002)(4326008)(53546011)(86362001)(186003)(26005)(83380400001)(16526019)(31686004)(36756003)(66556008)(66946007)(6666004)(478600001)(16576012)(956004)(2616005)(316002)(6486002)(8936002)(66476007)(43740500002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData: tktUZYyJEQ2hAht5jKiRJeis7bXXBAGoH/nIL6vBlpVtmK/YqxhMeQmUHjZ0g1nJyRxvl5OkMMTwBlPn4O090Mi58onXZGspHWtgHdboW+VhSP5koD9bwo+QvOwNDZ2/INcaUiLcaQhobOBSTkfjbMiRrIRXS5iuV4MWspV7/j17KgMnIXuw93sZOhIBEOTe6dxCJ2q9sLsTjxI4qO0MPMvbYg1hqTvfLiYedX2ieg069n3R/NtyqByHoKzQmbUbEx++ZKV2WNIO8tU4YJrFYY1LkyFUSLxDYEs056kJv/vovDArSAJS+iyHRntDEU3TLHdaQoK0EG3UjcfIPXXn96BhbUIeDqfGhjGPESApquAWuZrFhV/xdEkMGIDxuOSuD9FAzWdYbkSBCBVLUoRSMj87Ui8xd393qE0MYqs7Brnnr3ahb3gYU9JRVDw7TsXe9Djd944wwm2i2GObTFhRH4PZvsdueupRjssrHDPnGk2k7fr39c2DUt9n52Ba2A0eiP0DtwVfnoFG0zbshD7j4KoN1HafsGFiXc7g3pybKalc5IjF5SWcYaXbelNlOQ+PAZFW/ZhDZUgZ1u1oU0wPB5FrKDgpu6dA6zm68tb0Cbtkk0Kp+0dJXuJP2pCuqRgLst1CMyWe6UYuqP+lQ7dnJg== X-OriginatorOrg: axentia.se X-MS-Exchange-CrossTenant-Network-Message-Id: e07bf107-963f-4db6-219e-08d85b08b674 X-MS-Exchange-CrossTenant-AuthSource: DB8PR02MB5482.eurprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Sep 2020 12:53:45.4373 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4ee68585-03e1-4785-942a-df9c1871a234 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: uDLfuoDsM47XqL3Fkwi5msPPIgdOQZGk7re9Me/JBB5JqMz4ISn4Yj07cnTOctaE X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBAPR02MB6485 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200917_085350_036686_8B571DBF X-CRM114-Status: GOOD ( 22.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, nsekhar@ti.com, linux-kernel@vger.kernel.org, kishon@ti.com, t-kristo@ti.com, robh+dt@kernel.org, linux-arm-kernel@lists.infradead.org, Roger Quadros Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2020-09-17 14:27, Nishanth Menon wrote: > On 11:45-20200917, Peter Rosin wrote: > [...] >> >>>> Should not the defines start with J7200_WIZ? SERDES0 seems like a too >>>> generic prefix, at least to me. >>> >>> Thanks, good point. I am not sure if WIZ should even be used.. It is >>> a TI internal prefix for various serdes solutions, but I agree that >>> SERDES0 is too generic a terminology. That said, we should cleanup >>> include/dt-bindings/mux/mux-j721e-wiz.h as well, prior to introducing >>> j7200 changes. >> >> Right. As maintainer for the directory in question, I should have >> been on Cc for that series too, but it appears I wasn't. Hence, I > > yes, you should have been. The following commit introduced it. > > commit b766e3b0d5f6 ("arm64: dts: ti: k3-j721e-main: Add system controller > node and SERDES lane mux") > >> didn't notice that file until now when I went looking for it. Why >> wasn't I on Cc? > > Got through the SoC tree - an oversight on our part[1] and should'nt have, > Apologies on the bad call. > > I would like to propose the following: > a) The header should be renamed to be something more human friendly. > b) The header should be renamed to be something TI specific and NOT per > TI SoC. > c) The macros need renaming to be less generic as it stands right now. > > > If you ack the changes, I am guessing that the changes will impact dts > a lot and would rather take the cleanups through SoC tree to maintain > bisectability? OR I can pick on an immutable tag from you with just the > header file change and pick on the dts - but I doubt that would be > bisectable. Just worried that I have picked a bunch of cleanups already > on the dts for 5.10, and would like to avoid a merge conflict. [Our mails crossed.] I do not have a tree and dt-patches should normally not go *through* me. But I'd still like to see what's happening. I did not realize this was going to cause a *lot* of churn in the dt files. How bad can it be when the file is new in this cycle? And is it worth it? But it seems you all see problems with the current naming and in that case it must surely be better to fix it early? And if it's a lot, maybe it needs to be more than one patch? I get the feeling this will need to be taken care of by someone other than me, because I'm just the maintainer of a very small subsystem and I don't normally have to deal with "big" issues involving several trees. I would be a bottleneck. Cheers, Peter _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel