From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755312AbcFQJ0V (ORCPT ); Fri, 17 Jun 2016 05:26:21 -0400 Received: from mail-db3on0140.outbound.protection.outlook.com ([157.55.234.140]:7735 "EHLO emea01-db3-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753967AbcFQJ0S (ORCPT ); Fri, 17 Jun 2016 05:26:18 -0400 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=dsafonov@virtuozzo.com; Subject: Re: [PATCHv9 2/2] selftest/x86: add mremap vdso test To: Ingo Molnar References: <1463487232-4377-1-git-send-email-dsafonov@virtuozzo.com> <1463487232-4377-3-git-send-email-dsafonov@virtuozzo.com> <20160617080346.GB30525@gmail.com> CC: , , , , , , , , <0x7f454c46@gmail.com>, Shuah Khan , From: Dmitry Safonov Message-ID: <02e163e0-acbb-0f3a-df66-3e55b453936a@virtuozzo.com> Date: Fri, 17 Jun 2016 12:24:58 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <20160617080346.GB30525@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [195.214.232.10] X-ClientProxiedBy: HE1PR01CA0061.eurprd01.prod.exchangelabs.com (10.165.170.157) To DB6PR0801MB1349.eurprd08.prod.outlook.com (10.168.11.137) X-MS-Office365-Filtering-Correlation-Id: f0c5b346-610f-496e-9eca-08d396916d74 X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1349;2:awap8k4uyoYPVcqCIa2YMGqRwpeyPlnm9rHzFnelP/Lt2nZ9TPQGvoIuqMs78ATFZqDibXIAjhUPQcyNHxlPix4oufOnv3UTb0jNvzdwxykoh/7oo2iV3DsStuWOgLqHFVd0i8kNF8LM8qdT89bn/7eRLbE5lbo05aaXE4UpOK/iMfjR3INh3zW3vXy32VFr;3:kSmLWUot4o+ZTyvB79qng2EOfyVSd2ccXwk2mPqdv8Qs+1IyV57lVRt/wi96pmK+GKDpn/aIHdqpiNC3XopFCo0DUQqXLSDUsmmJZmOoNjTe6hWEVPJfuE5mHj4yKhho X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0801MB1349; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1349;25:kVaBSaC0tuBACcJHBPP6qgQ/LRr77+6oJKXrgHRo1gMaZ82A6YR1ADjNVPg6e0EDRfnLmCe/9dPsNr1enshY0KOSI9rY7GkfpOlzN5FpkV4DE9rwVHw2ghh6Bb/JD3eNHTDmENFsYdXhKK5YHqkE7vsWKFvduDsc9w/KOPC6eiO7gTN2PovWYpCKk0fJdioqfSHnBrF97LfDE+9pvfdjBrVDaGjhUtydv5P3/x7F5KuNUlEFAZxxElcvrG3xkZaVENn9ecwk7z0MMCa6d+n0PcCzvNBFIJMT+OfS+n/vxIPTe+ZogeD+aNggD6tUtgtfj4RG/xyaGe9o7tTM4jS4yZowoZT4gJSXXvrBH5Y3T6l+DAhmGWZaUUQlQLbhrAiUomMyWdpZFolxs5EgFhKvX7/6lXJ5ciq44h7w3kQIny85Gao1c0DKeU8N75d76f5VEoGMI+lTFR2E8LP/dMmilSgiEvAUjFlwicQSC5/Ktl/XX5a2QPpjQdV2cwoAASFo2mu9+OUpUZM5sijvkHzJK9c3E/9FQXEI5nAaMCytNUMqrwPZAi4bJ2wYbW0w6Vs0FiLmT0kn9dDFYQc8vv+oJx6qlEtSLMUvsduD+mQJOgf3ekgkDPJj3iZj8KUgTD+3DSm69simQkhOrmpP8hCMsVxmR/XfPKMvuH2sy0kPIb+ihP570MXly1wI2faDVXc1 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(265634631926514); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040130)(601004)(2401047)(5005006)(8121501046)(3002001)(10201501046)(6041072)(6043046);SRVR:DB6PR0801MB1349;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0801MB1349; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1349;4:l+Wi8SvacwcP4Xn5nPWCFxnv7WJlGRzge8wasll4PHRIbteJfNnXVkH0h9EkahSIaYOwC4taBpIXRUWnTHaq9f3ejzfXsTvfe0S9EB/KxxCZFfLKmaTBcLQdriKDLZ+O2vb45FArEdC4ayjgdq2p7FxjO2PhmyIJt4Byb6oRK/kOQpNowwTWH4XpcSbl8XNOU9d1nC0s6dHLnlJFh05i63QQG7Fjcm81/16n1t5VrH72Q6t9yXBrJCEJ4kAKYqybEJrhCcw0C6Rv8rczt6350+d0KOSUEssDDT/N2ClE5hRopeyJyWeen68oVZMmu/Tg5FD2IoeywpNuuR6vagQbWqfa5oftcYlaK00NxEjRlE1/DKkMm5UcSOcpJKFMtYA1aCXJ4PQvzOyRK+HcntDXSa/HAoTwwj3hWnKEfxVMjcqTNcaUcV07jJAQmBm02xiwK/iocrKvspd2YiRCMH8cYFaobd7AcOcn/kHWQ+Hfgow= X-Forefront-PRVS: 09760A0505 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10019020)(4630300001)(6049001)(6009001)(7916002)(24454002)(199003)(189002)(377454003)(8676002)(2950100001)(77096005)(68736007)(5004730100002)(31696002)(81156014)(81166006)(105586002)(106356001)(19580395003)(19580405001)(83506001)(47776003)(3846002)(65956001)(66066001)(4326007)(64126003)(110136002)(86362001)(65806001)(189998001)(230700001)(36756003)(2906002)(42186005)(23746002)(6116002)(101416001)(92566002)(33646002)(5008740100001)(76176999)(54356999)(50986999)(31686004)(97736004)(4001350100001)(586003)(50466002)(65826006);DIR:OUT;SFP:1102;SCL:1;SRVR:DB6PR0801MB1349;H:[10.30.26.154];FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DB6PR0801MB1349;23:/2UNt5V21SL70zJFqb3kufmAMFqkzIvBJ0n?= =?Windows-1252?Q?XDJHBFr/blxBDGRvajadw2IsNKaPWKlEmsnpWAn0tErBEeVp4kHJ/HYF?= =?Windows-1252?Q?pA+KyspWYVlVTSSFJb8iK991IveN97VZM0ajH+pLnGbHC53IhgWHy+NE?= =?Windows-1252?Q?nX8pTPHKAZ0jrv9ZpQXLx6D8iCTYhsjeCm2+8plt61R+Z8GLaiLNqgwk?= =?Windows-1252?Q?EGe8dBzxQvxaiOIPJozh+390fnhwu+9R5Aa4gSrB6wN8I3eqVATe/qHo?= =?Windows-1252?Q?VD7B943La0EcIzTnQ5FfIaFbEBfzKZwwKBRbcZX7YwpYZKWDx+nqdmlW?= =?Windows-1252?Q?s82Pc7xwS3BmN6M7ca6nXiULo6DHY7H+9GWpb3RSq4e/geRjbehx61P0?= =?Windows-1252?Q?nPlZO1QB64W8CK2lQlYhHoyCEC2LqioFVERejsS+T1UwRFKhiPLr+XRp?= =?Windows-1252?Q?wvYlc/GoHI2nK2PQ+uYN8LuEjnlnnZQFPzw60e66c5JnanLzRRmPGpD2?= =?Windows-1252?Q?FtKdhU6qtjjj2ZhGYcz7RvfiHedHJO7QEQm+s+wZSknJrm2RyH8wJ5fK?= =?Windows-1252?Q?3Pzdd+2xoEOEZpztKqs1sZ6lA4U3/R7V+e+YQmO5+SmviLrrSDQmdNbq?= =?Windows-1252?Q?26OgEW2EUGFQJCieqC6RwPq94qgwsX/vzQQp7IoTBYlo8+V86AJXihb4?= =?Windows-1252?Q?NZ4YayOlIe8IgyfMoemJ+n0qAFo+MQu1oBzRsd1/M9m6WyAKybJWsh2y?= =?Windows-1252?Q?9rYGPJ5T8u1smKQ2LGjpwV/fLXHoR/9n8+S8irK5L+wZyKU66PVlU5sV?= =?Windows-1252?Q?gBOwpalHUwig2O13kkD7vkZRLCcKYENLozKK6XKFay+qIs2igJiWz0PY?= =?Windows-1252?Q?Oc99gr6JkKXI8HZMHkuAAbunNf9WY8Tb6XHA5p4G0TClxxpkVMjLpbR8?= =?Windows-1252?Q?TeaHHxEkoLgfi7JcO/RD3daobQkpa4jS9+mQ9DWaAjVeTTBfinF6Sn2n?= =?Windows-1252?Q?itKpyP0q5u62yqIeA3VVE0Y1rOYj/Q97GBV0sV/NGMlZiXNvU21itU6O?= =?Windows-1252?Q?DMZafbgo1dk2n80xGxmDpIIu3qmCK8W6IKrFuIV0rRoKrtGc716c0uep?= =?Windows-1252?Q?7/tWG7BLcMO2Lhk9/Al2M7JQ/VlmQYy3IPDL0sOhl9RG8dTYjErTy9xS?= =?Windows-1252?Q?0b9LJogqznTCUBci43jrNUTwCvVPCeNLKwP+GFE4bEsepOO64o8+jcpY?= =?Windows-1252?Q?fugG+re6iFjPNaLt+Kjf9aH8PmjTf4GMQ77lsJ7AHEmXLPvxSV3e9Bfu?= =?Windows-1252?Q?qjFA+QDcEUJJZ3ULOQcl32FRjDqF5DmuQyUFYRYT+sX4fHggbowABvDY?= =?Windows-1252?Q?Gai7mNz/HdChe?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1349;6:KNaG+jaGzkCdlkilmbtcd+5daqLddcZxVk05YLqI1r+xuouV+1ilTPhPb+0Qykqy2nT2Kr4T5mUkb0Hh3J3JgLwhmToYdGgeKveNNDgiJJuWkbh2GsoRezfitRC/P1/uBm74bpyp2j8l1ouWFdUPiviJ+24dU+/9DEAUwTlyy7k1NIrN6/YuB25CD/Pj9rJGvTjBBfuPG06dqi1ejztEwMhvVyInrsAZiFQkbNgIPV0ko8eUvC+BENrUPonuIF4yr2KGyq6Exb0udNQvNJxBJQfvH+OvZSaph5OksaMVnXdK6/hZwA8PM5GmnkQPidKF;5:d2TdTcljrBiiKwSaR116KptAAzpNnqA1qwepYvD2xTS+ClJfW6qk4nAhUTRxJss5FjsCdaSoPU5G7QarXQjG6t3dwnKmzFwqZVF5l+u30W/Hy7fdHXUWoCvqg0dBfCwQQ/Z4AA1R78dLQasC+T3CTA==;24:9Kyqxm3hTcEfykNxQLjvoQV25dIp0nqgznlJgEGAm0+4a0uaMCuPbsJDhjilOrsJ8p35Y6FsGh19vLHyjObPdamiUdmx291oqtKeB89Toog=;7:1y70OLOxyi9zE8kSvk0Ju0ymqqQ5gWw/QF12jvAQ+DEQEeYax87SXJ/f279s9HXVH0HLGkjD+UeBIdhXLOiUxydUxhuJzomMxKiFSvrQ0b9Bf9A2U3h4QLd/YpyuJTXle/arcxYPLcNGaiUNAO4ppudA+ZFSThorXWzBvELbS5mc2MooxmFUNJeDAvZUIOlAN2bH2DuGJffgr0gKyjQnDvvKM3HelgPkVhlqVLycSJs9fJFsXDQsY21NOxEfPMcO SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1349;20:WS3Wz6ft5Lkbrb4m1AHxgpIfcWH0jHRTH1M+6m7vXHIUZ3n0o5UA3E5/GLjMwscOJKJRqECo1iB+wc8Eckgw/NIThnDZQNNk4nhMOhbSp11u+hXYL+c9r5f9ceXZuoTD7bq8RFizv9Bct4NoeFd6tpzI8zJ0E7ZzrGq+qTCYgmM= X-OriginatorOrg: virtuozzo.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Jun 2016 09:26:12.0049 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1349 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/17/2016 11:03 AM, Ingo Molnar wrote: > > * Dmitry Safonov wrote: > >> Should print on success: >> [root@localhost ~]# ./test_mremap_vdso_32 >> AT_SYSINFO_EHDR is 0xf773f000 >> [NOTE] Moving vDSO: [f773f000, f7740000] -> [a000000, a001000] >> [OK] >> Or segfault if landing was bad (before patches): >> [root@localhost ~]# ./test_mremap_vdso_32 >> AT_SYSINFO_EHDR is 0xf774f000 >> [NOTE] Moving vDSO: [f774f000, f7750000] -> [a000000, a001000] >> Segmentation fault (core dumped) > > Yeah, so I changed my mind again, I still don't like that the testcase faults on > old kernels: > > triton:~/tip/tools/testing/selftests/x86> ./test_mremap_vdso_32 > AT_SYSINFO_EHDR is 0xf7786000 > [NOTE] Moving vDSO: [0xf7786000, 0xf7787000] -> [0xf7781000, 0xf7782000] > Segmentation fault > > How do I know that this testcase is special and that a segmentation fault in this > case means that I'm running it on a too old kernel and that it's not some other > unexpected failure in the test? > > At minimum please run it behind fork() and catch the -SIGSEGV child exit: > > mremap(0xf7747000, 4096, 4096, MREMAP_MAYMOVE|MREMAP_FIXED, 0xf7742000) = 0xf7742000 > --- SIGSEGV {si_signo=SIGSEGV, si_code=SEGV_MAPERR, si_addr=0xf7747be9} --- > +++ killed by SIGSEGV +++ > > and print: > > [FAIL] mremap() of the vDSO does not work on this kernel! > > or such. > > Ok? Ok, will do. Thanks, Dmitry From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f199.google.com (mail-pf0-f199.google.com [209.85.192.199]) by kanga.kvack.org (Postfix) with ESMTP id 790176B0005 for ; Fri, 17 Jun 2016 05:26:18 -0400 (EDT) Received: by mail-pf0-f199.google.com with SMTP id e189so150799448pfa.2 for ; Fri, 17 Jun 2016 02:26:18 -0700 (PDT) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on0137.outbound.protection.outlook.com. [104.47.1.137]) by mx.google.com with ESMTPS id f5si17556664pay.145.2016.06.17.02.26.17 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 17 Jun 2016 02:26:17 -0700 (PDT) Subject: Re: [PATCHv9 2/2] selftest/x86: add mremap vdso test References: <1463487232-4377-1-git-send-email-dsafonov@virtuozzo.com> <1463487232-4377-3-git-send-email-dsafonov@virtuozzo.com> <20160617080346.GB30525@gmail.com> From: Dmitry Safonov Message-ID: <02e163e0-acbb-0f3a-df66-3e55b453936a@virtuozzo.com> Date: Fri, 17 Jun 2016 12:24:58 +0300 MIME-Version: 1.0 In-Reply-To: <20160617080346.GB30525@gmail.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: To: Ingo Molnar Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, luto@amacapital.net, tglx@linutronix.de, hpa@zytor.com, x86@kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, 0x7f454c46@gmail.com, Shuah Khan , linux-kselftest@vger.kernel.org On 06/17/2016 11:03 AM, Ingo Molnar wrote: > > * Dmitry Safonov wrote: > >> Should print on success: >> [root@localhost ~]# ./test_mremap_vdso_32 >> AT_SYSINFO_EHDR is 0xf773f000 >> [NOTE] Moving vDSO: [f773f000, f7740000] -> [a000000, a001000] >> [OK] >> Or segfault if landing was bad (before patches): >> [root@localhost ~]# ./test_mremap_vdso_32 >> AT_SYSINFO_EHDR is 0xf774f000 >> [NOTE] Moving vDSO: [f774f000, f7750000] -> [a000000, a001000] >> Segmentation fault (core dumped) > > Yeah, so I changed my mind again, I still don't like that the testcase faults on > old kernels: > > triton:~/tip/tools/testing/selftests/x86> ./test_mremap_vdso_32 > AT_SYSINFO_EHDR is 0xf7786000 > [NOTE] Moving vDSO: [0xf7786000, 0xf7787000] -> [0xf7781000, 0xf7782000] > Segmentation fault > > How do I know that this testcase is special and that a segmentation fault in this > case means that I'm running it on a too old kernel and that it's not some other > unexpected failure in the test? > > At minimum please run it behind fork() and catch the -SIGSEGV child exit: > > mremap(0xf7747000, 4096, 4096, MREMAP_MAYMOVE|MREMAP_FIXED, 0xf7742000) = 0xf7742000 > --- SIGSEGV {si_signo=SIGSEGV, si_code=SEGV_MAPERR, si_addr=0xf7747be9} --- > +++ killed by SIGSEGV +++ > > and print: > > [FAIL] mremap() of the vDSO does not work on this kernel! > > or such. > > Ok? Ok, will do. Thanks, Dmitry -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org