From: Saeed Mahameed <saeedm@mellanox.com>
To: "jonathan.lemon@gmail.com" <jonathan.lemon@gmail.com>,
"ilias.apalodimas@linaro.org" <ilias.apalodimas@linaro.org>,
Tariq Toukan <tariqt@mellanox.com>,
"brouer@redhat.com" <brouer@redhat.com>
Cc: "kernel-team@fb.com" <kernel-team@fb.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH 00/10 net-next] page_pool cleanups
Date: Fri, 18 Oct 2019 21:21:41 +0000 [thread overview]
Message-ID: <02eb26349dfe19d41f9b81b35fdb2b1e14008b7e.camel@mellanox.com> (raw)
In-Reply-To: <1df61f9dedf2e26bbc94298cc2605002a4700ce6.camel@mellanox.com>
On Fri, 2019-10-18 at 13:50 -0700, Saeed Mahameed wrote:
> On Wed, 2019-10-16 at 15:50 -0700, Jonathan Lemon wrote:
> > This patch combines work from various people:
> > - part of Tariq's work to move the DMA mapping from
> > the mlx5 driver into the page pool. This does not
> > include later patches which remove the dma address
> > from the driver, as this conflicts with AF_XDP.
> >
> > - Saeed's changes to check the numa node before
> > including the page in the pool, and flushing the
> > pool on a node change.
> >
>
> Hi Jonathan, thanks for submitting this,
> the patches you have are not up to date, i have new ones with tracing
> support and some fixes from offlist review iterations, plus
> performance
> numbers and a cover letter.
>
> I will send it to you and you can post it as v2 ?
actually i suggest to take my 3 patches out of this series and submit
them as standalone, they are not directly related to the other stuff
here, and can perfectly work without them, since my 3 patches are
addressing a real issue with page pool numa node migration.
>
>
> > - Statistics and cleanup for page pool.
> >
> > Jonathan Lemon (5):
> > page_pool: Add page_pool_keep_page
> > page_pool: allow configurable linear cache size
> > page_pool: Add statistics
> > net/mlx5: Add page_pool stats to the Mellanox driver
> > page_pool: Cleanup and rename page_pool functions.
> >
> > Saeed Mahameed (2):
> > page_pool: Add API to update numa node and flush page caches
> > net/mlx5e: Rx, Update page pool numa node when changed
> >
> > Tariq Toukan (3):
> > net/mlx5e: RX, Remove RX page-cache
> > net/mlx5e: RX, Manage RX pages only via page pool API
> > net/mlx5e: RX, Internal DMA mapping in page_pool
> >
> > drivers/net/ethernet/mellanox/mlx5/core/en.h | 18 +-
> > .../net/ethernet/mellanox/mlx5/core/en/xdp.c | 12 +-
> > .../net/ethernet/mellanox/mlx5/core/en_main.c | 19 +-
> > .../net/ethernet/mellanox/mlx5/core/en_rx.c | 128 ++--------
> > .../ethernet/mellanox/mlx5/core/en_stats.c | 39 ++--
> > .../ethernet/mellanox/mlx5/core/en_stats.h | 19 +-
> > include/net/page_pool.h | 216 +++++++++-----
> > --
> > -
> > net/core/page_pool.c | 221 +++++++++++---
> > --
> > --
> > 8 files changed, 319 insertions(+), 353 deletions(-)
> >
next prev parent reply other threads:[~2019-10-18 21:22 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 22:50 [PATCH 00/10 net-next] page_pool cleanups Jonathan Lemon
2019-10-16 22:50 ` [PATCH 01/10 net-next] net/mlx5e: RX, Remove RX page-cache Jonathan Lemon
2019-10-17 1:30 ` Jakub Kicinski
2019-10-18 20:03 ` Jonathan Lemon
2019-10-18 20:53 ` Saeed Mahameed
2019-10-19 0:10 ` Jonathan Lemon
2019-10-20 7:29 ` Tariq Toukan
2019-10-16 22:50 ` [PATCH 02/10 net-next] net/mlx5e: RX, Manage RX pages only via page pool API Jonathan Lemon
2019-10-16 22:50 ` [PATCH 03/10 net-next] net/mlx5e: RX, Internal DMA mapping in page_pool Jonathan Lemon
2019-10-17 1:33 ` Jakub Kicinski
2019-10-18 20:04 ` Jonathan Lemon
2019-10-18 21:01 ` Saeed Mahameed
2019-10-16 22:50 ` [PATCH 04/10 net-next] page_pool: Add API to update numa node and flush page caches Jonathan Lemon
2019-10-17 12:06 ` Ilias Apalodimas
2019-10-18 21:07 ` Saeed Mahameed
2019-10-18 23:38 ` Jonathan Lemon
2019-10-16 22:50 ` [PATCH 05/10 net-next] net/mlx5e: Rx, Update page pool numa node when changed Jonathan Lemon
2019-10-16 22:50 ` [PATCH 06/10 net-next] page_pool: Add page_pool_keep_page Jonathan Lemon
2019-10-16 22:50 ` [PATCH 07/10 net-next] page_pool: allow configurable linear cache size Jonathan Lemon
2019-10-17 8:51 ` Jesper Dangaard Brouer
2019-10-18 20:31 ` Jonathan Lemon
2019-10-16 22:50 ` [PATCH 08/10 net-next] page_pool: Add statistics Jonathan Lemon
2019-10-17 8:29 ` Jesper Dangaard Brouer
2019-10-18 21:29 ` Saeed Mahameed
2019-10-18 23:37 ` Jonathan Lemon
2019-10-16 22:50 ` [PATCH 09/10 net-next] net/mlx5: Add page_pool stats to the Mellanox driver Jonathan Lemon
2019-10-17 11:09 ` Jesper Dangaard Brouer
2019-10-18 20:45 ` Jonathan Lemon
2019-10-16 22:50 ` [PATCH 10/10 net-next] page_pool: Cleanup and rename page_pool functions Jonathan Lemon
2019-10-18 20:50 ` [PATCH 00/10 net-next] page_pool cleanups Saeed Mahameed
2019-10-18 21:21 ` Saeed Mahameed [this message]
2019-10-18 23:32 ` Jonathan Lemon
2019-10-21 19:08 ` Saeed Mahameed
2019-10-21 21:45 ` Jonathan Lemon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02eb26349dfe19d41f9b81b35fdb2b1e14008b7e.camel@mellanox.com \
--to=saeedm@mellanox.com \
--cc=brouer@redhat.com \
--cc=ilias.apalodimas@linaro.org \
--cc=jonathan.lemon@gmail.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=tariqt@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.