From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>, dev@dpdk.org
Cc: Mark Spender <mspender@solarflare.com>
Subject: Re: [PATCH 02/11] net/sfc/base: improve API to get supported filter matches
Date: Tue, 7 Mar 2017 13:25:00 +0000 [thread overview]
Message-ID: <0305e912-1d88-f6d5-39b4-dec8c410475c@intel.com> (raw)
In-Reply-To: <1488470591-5853-3-git-send-email-arybchenko@solarflare.com>
On 3/2/2017 4:03 PM, Andrew Rybchenko wrote:
> From: Mark Spender <mspender@solarflare.com>
>
> The previous API had various problems, including the length of the
> caller provided buffer not being specified, no means being available
> to discover how big the buffer needs to be, and a lack of clarity of
> what the resulting list contains.
>
> To improve it:
> - add the buffer length as a parameter
> - if the provided buffer is too short, fail with ENOSPC and return
> the required length
> - ensure that the list contents are valid and add comments describing it
>
> It is safe to change this API as, unsuprisingly, it has no users.
>
> Signed-off-by: Mark Spender <mspender@solarflare.com>
> Signed-off-by: Andrew Rybchenko <arybchenko@solarflare.com>
<...>
>
> - *length = index;
> - memcpy(list, rx_matches, *length);
> + memcpy(buffer, rx_matches, list_length * sizeof (rx_matches[0]));
Checkpatch warning:
WARNING:SPACING: space prohibited between function name and open
parenthesis '('
#326: FILE: drivers/net/sfc/base/efx_filter.c:1410:
+ memcpy(buffer, rx_matches, list_length * sizeof (rx_matches[0]))
next prev parent reply other threads:[~2017-03-07 13:25 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 16:03 [PATCH 00/11] Support flow API in Solarflare PMD Andrew Rybchenko
2017-03-02 16:03 ` [PATCH 01/11] net/sfc/base: split local MAC I/G back into separate flags Andrew Rybchenko
2017-03-02 16:03 ` [PATCH 02/11] net/sfc/base: improve API to get supported filter matches Andrew Rybchenko
2017-03-07 13:25 ` Ferruh Yigit [this message]
2017-03-07 14:47 ` Andrew Rybchenko
2017-03-07 14:56 ` Ferruh Yigit
2017-03-02 16:03 ` [PATCH 03/11] net/sfc: implement dummy filter control callback Andrew Rybchenko
2017-03-02 16:03 ` [PATCH 04/11] net/sfc: provide a way to check if filter is supported Andrew Rybchenko
2017-03-02 16:03 ` [PATCH 05/11] net/sfc: add flow API filters support Andrew Rybchenko
2017-03-07 13:21 ` Ferruh Yigit
2017-03-09 15:29 ` Andrew Rybchenko
2017-03-02 16:03 ` [PATCH 06/11] net/sfc: add VLAN in " Andrew Rybchenko
2017-03-02 16:03 ` [PATCH 07/11] net/sfc: add IPV4 " Andrew Rybchenko
2017-03-07 13:21 ` Ferruh Yigit
2017-03-02 16:03 ` [PATCH 08/11] net/sfc: add IPV6 " Andrew Rybchenko
2017-03-02 16:03 ` [PATCH 09/11] net/sfc: add TCP " Andrew Rybchenko
2017-03-02 16:03 ` [PATCH 10/11] net/sfc: add UDP " Andrew Rybchenko
2017-03-02 16:03 ` [PATCH 11/11] net/sfc: add unknown unicast/multicast match in flow API Andrew Rybchenko
2017-03-07 13:27 ` [PATCH 00/11] Support flow API in Solarflare PMD Ferruh Yigit
2017-03-07 14:56 ` Andrew Rybchenko
2017-03-09 15:26 ` [PATCH v2 " Andrew Rybchenko
2017-03-09 15:26 ` [PATCH v2 01/11] net/sfc/base: split local MAC I/G back into separate flags Andrew Rybchenko
2017-03-09 15:26 ` [PATCH v2 02/11] net/sfc/base: improve API to get supported filter matches Andrew Rybchenko
2017-03-09 15:26 ` [PATCH v2 03/11] net/sfc: implement dummy filter control callback Andrew Rybchenko
2017-03-09 15:26 ` [PATCH v2 04/11] net/sfc: provide a way to check if filter is supported Andrew Rybchenko
2017-03-09 15:26 ` [PATCH v2 05/11] net/sfc: add flow API filters support Andrew Rybchenko
2017-03-09 15:26 ` [PATCH v2 06/11] net/sfc: add VLAN in " Andrew Rybchenko
2017-03-09 15:26 ` [PATCH v2 07/11] net/sfc: add IPV4 " Andrew Rybchenko
2017-03-09 15:26 ` [PATCH v2 08/11] net/sfc: add IPV6 " Andrew Rybchenko
2017-03-09 15:26 ` [PATCH v2 09/11] net/sfc: add TCP " Andrew Rybchenko
2017-03-09 15:26 ` [PATCH v2 10/11] net/sfc: add UDP " Andrew Rybchenko
2017-03-09 15:26 ` [PATCH v2 11/11] net/sfc: add unknown unicast/multicast match in flow API Andrew Rybchenko
2017-03-09 17:28 ` [PATCH v2 00/11] Support flow API in Solarflare PMD Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0305e912-1d88-f6d5-39b4-dec8c410475c@intel.com \
--to=ferruh.yigit@intel.com \
--cc=arybchenko@solarflare.com \
--cc=dev@dpdk.org \
--cc=mspender@solarflare.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.