All of lore.kernel.org
 help / color / mirror / Atom feed
From: NIshka Dasgupta <nishka.dasgupta@yahoo.com>
To: Julia Lawall <julia.lawall@lip6.fr>
Cc: gregkh@linuxfoundation.org, outreachy-kernel@googlegroups.com,
	ajay.kathat@microchip.com, adham.abozaeid@microchip.com
Subject: Re: [Outreachy kernel] [PATCH 0/5] Remove return variables in multiple functions
Date: Wed, 20 Mar 2019 21:28:22 +0530	[thread overview]
Message-ID: <0310644f-84f3-2aca-1a90-5463b2dc37b3@yahoo.com> (raw)
In-Reply-To: <alpine.DEB.2.21.1903192102070.2460@hadrien>



On 20/03/19 1:34 AM, Julia Lawall wrote:
> 
> 
> On Wed, 20 Mar 2019, 'Nishka Dasgupta' via outreachy-kernel wrote:
> 
>> The following patches remove the return variable in multiple functions
>> and return the required values directly. These issues were suggested by
>> Coccinelle using ret.cocci.
>>
>> Nishka Dasgupta (5):
>>    staging: wilc1000: Remove return variable
>>    staging: wilc1000: Remove return variable
>>    staging: wilc1000: Remove return variable
>>    staging: wilc1000: Remove return variable
>>    staging: wilc1000: Remove return variable
> 
> I haven't received the other patches in this series, but just from the
> above there is a problem.  Every patch should have a subject line that is
> unique.  On solution would be to incorporate the file name, but it seems
> that you have only two files.  If the changes are not too voluminous, you
> could send a single patch for all of the changes in a given file.

Since you've acked one or two of them, should I send a version 2 of the 
entire patchset or just the ones that need adjustments?
Thanking you,
Nishka

> julia

>>
>>   drivers/staging/wilc1000/host_interface.c | 11 +++--------
>>   drivers/staging/wilc1000/wilc_spi.c       |  6 ++----
>>   2 files changed, 5 insertions(+), 12 deletions(-)
>>
>> --
>> 2.19.1
>>
>> --
>> You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to outreachy-kernel+unsubscribe@googlegroups.com.
>> To post to this group, send email to outreachy-kernel@googlegroups.com.
>> To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/cover.1553025265.git.nishka.dasgupta%40yahoo.com.
>> For more options, visit https://groups.google.com/d/optout.
>>


  reply	other threads:[~2019-03-20 15:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-19 19:57 [PATCH 0/5] Remove return variables in multiple functions Nishka Dasgupta
2019-03-19 19:57 ` [PATCH 1/5] staging: wilc1000: Remove return variable Nishka Dasgupta
2019-03-19 20:11   ` [Outreachy kernel] " Julia Lawall
2019-03-19 19:57 ` [PATCH 2/5] " Nishka Dasgupta
2019-03-19 20:15   ` [Outreachy kernel] " Julia Lawall
2019-03-19 19:57 ` [PATCH 3/5] " Nishka Dasgupta
2019-03-19 19:57 ` [PATCH 4/5] " Nishka Dasgupta
2019-03-19 19:57 ` [PATCH 5/5] " Nishka Dasgupta
2019-03-19 20:16   ` [Outreachy kernel] " Julia Lawall
2019-03-19 20:04 ` [Outreachy kernel] [PATCH 0/5] Remove return variables in multiple functions Julia Lawall
2019-03-20 15:58   ` NIshka Dasgupta [this message]
2019-03-20 20:10     ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0310644f-84f3-2aca-1a90-5463b2dc37b3@yahoo.com \
    --to=nishka.dasgupta@yahoo.com \
    --cc=adham.abozaeid@microchip.com \
    --cc=ajay.kathat@microchip.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=julia.lawall@lip6.fr \
    --cc=outreachy-kernel@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.