From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephan Linz Date: Mon, 3 Nov 2003 14:01:35 +0100 Subject: [U-Boot-Users] [PATCH-1/2] LAN91C111 In-Reply-To: <71555548814716479478431542AA5F8A058F82@dlee2k98.ent.ti.com> References: <71555548814716479478431542AA5F8A058F82@dlee2k98.ent.ti.com> Message-ID: <0311031401350N.02205@pcj86> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Am Montag, 3. November 2003 13:13 schrieb Woodruff, Richard: > I've been using the 91111 for a while now. I've not had any real problems > with it. As the environment I'm in has some 30 odd boards, I've never used > the hard coded mac address. Hi Richard It is not a problem of hard coded mac addresses because smc_mac_addr[] will be used as buffer storage too. Furthermore it's a problem of type casting from signed char to unsigned short (type of word) when writing the mac address into LAN91C111 (near line smc91111.c:smc_open():700 the USE_32_BIT branch). Note: it could be _only_ a NIOS related problem, but I think the type unsigned char for smc_mac_addr[] is more exact in common case, or not? Regards, Stephan > > Regards, > > Richard W. > > -----Original Message----- > From: u-boot-users-admin at lists.sourceforge.net > [mailto:u-boot-users-admin at lists.sourceforge.net] On Behalf Of Stephan Linz > Sent: Monday, November 03, 2003 5:02 AM > To: u-boot-users at lists.sourceforge.net > Subject: [U-Boot-Users] [PATCH-1/2] LAN91C111 > > Hi all, > > in context of one of my emails last week: > http://sourceforge.net/mailarchive/forum.php?thread_id=3364771&forum_id=128 >9 8 > > > I'm wondering about how many people are using the LAN91C111 driver without > significant problems. There is (just was :-) a fat signed/unsigned bug in > drivers/smc91111.c which is significant at NIOS plattforms when you are > using > MAC addresses with address elements above 0x7f. Example: 00:07:ed:0a:a4:7b > goes over to 00:07:ed:ff:a4:ff inside the chip. Simple solution: > > static char smc_mac_addr[] = { . . . }; > > have to be: > > static char unsigned smc_mac_addr[6] = { . . . }; > > > In attatchment you will find my smc91111_fix patch. It includes some other > minor fixes I've made. This patch has been working successful at NIOS > Stratix > and Cyclone boards. > > Please try out and patch CVS tree. > > > Best Regards,