From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Cc: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>,
alsa-devel@alsa-project.org,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
tiwai@suse.de, Curtis Malainey <curtis@malainey.com>,
broonie@kernel.org,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH 2/5] ASoC: Intel: bdw-rt5677: fix module load/unload issues
Date: Wed, 24 Jun 2020 21:14:25 +0200 [thread overview]
Message-ID: <031f1766-14cc-76ed-4a0f-b0436c50922a@intel.com> (raw)
In-Reply-To: <20200622154241.29053-3-pierre-louis.bossart@linux.intel.com>
On 2020-06-22 5:42 PM, Pierre-Louis Bossart wrote:
> The mainline code currently prevents modules from being removed.
>
> The BE dailink .init() function calls devm_gpiod_get() using the codec
> component device as argument. When the machine driver is removed, the
> references to the gpiod are not released, and it's not possible to
> remove the codec driver module - which is the only entity which could
> free the gpiod.
>
> This conceptual deadlock can be avoided by invoking gpiod_get() in the
> .init() callback, and calling gpiod_put() in the exit() callback.
>
> Tested on SAMUS Chromebook with SOF driver.
>
As /intel/haswell is the go-to driver for BDW platforms, please test and
confirm with legacy driver first. SOF is optional and thus non-blocking.
Czarek
next prev parent reply other threads:[~2020-06-24 19:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-22 15:42 [PATCH 0/5] ASoC: add dailink .exit() callback Pierre-Louis Bossart
2020-06-22 15:42 ` [PATCH 1/5] ASoC: soc-link: introduce exit() callback Pierre-Louis Bossart
2020-06-22 23:54 ` Kuninori Morimoto
2020-06-23 14:50 ` Pierre-Louis Bossart
2020-06-24 23:25 ` Kuninori Morimoto
2020-06-22 15:42 ` [PATCH 2/5] ASoC: Intel: bdw-rt5677: fix module load/unload issues Pierre-Louis Bossart
2020-06-22 18:18 ` Andy Shevchenko
2020-06-22 18:23 ` Pierre-Louis Bossart
2020-06-22 18:26 ` Mark Brown
2020-06-23 8:40 ` Andy Shevchenko
2020-06-23 9:37 ` Mark Brown
2020-06-23 8:43 ` Andy Shevchenko
2020-06-24 19:14 ` Cezary Rojewski [this message]
2020-06-24 20:06 ` Pierre-Louis Bossart
2020-06-24 20:26 ` Cezary Rojewski
2020-06-22 15:42 ` [PATCH 3/5] ASoC: Intel: kbl-rt5660: use .exit() dailink callback to release gpiod Pierre-Louis Bossart
2020-06-22 18:20 ` Andy Shevchenko
2020-06-22 18:26 ` Pierre-Louis Bossart
2020-06-23 8:39 ` Andy Shevchenko
2020-06-22 15:42 ` [PATCH 4/5] ASoC: intel: sof_rt5682: move disabling jack to dai link's exit() Pierre-Louis Bossart
2020-06-22 15:42 ` [PATCH 5/5] ASoC: intel: cml_rt1011_rt5682: disable jack in dailink .exit() Pierre-Louis Bossart
2020-06-23 12:39 ` [PATCH 0/5] ASoC: add dailink .exit() callback Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=031f1766-14cc-76ed-4a0f-b0436c50922a@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=broonie@kernel.org \
--cc=curtis@malainey.com \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.