From: Baolin Wang <baolin.wang@linux.alibaba.com>
To: Kemeng Shi <shikemeng@huaweicloud.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
akpm@linux-foundation.org, mgorman@techsingularity.net,
david@redhat.com
Subject: Re: [PATCH 5/9] mm/compaction: remove repeat compact_blockskip_flush check in reset_isolation_suitable
Date: Tue, 15 Aug 2023 16:42:22 +0800 [thread overview]
Message-ID: <031fb6f3-4f5b-2b3b-bc12-afa3d10ae0f0@linux.alibaba.com> (raw)
In-Reply-To: <20230805110711.2975149-6-shikemeng@huaweicloud.com>
On 8/5/2023 7:07 PM, Kemeng Shi wrote:
> We have compact_blockskip_flush check in __reset_isolation_suitable, just
> remove repeat check before __reset_isolation_suitable in
> compact_blockskip_flush.
>
> Signed-off-by: Kemeng Shi <shikemeng@huaweicloud.com>
Reviewed-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
> mm/compaction.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/mm/compaction.c b/mm/compaction.c
> index 8d7d38073d30..d8416d3dd445 100644
> --- a/mm/compaction.c
> +++ b/mm/compaction.c
> @@ -434,9 +434,7 @@ void reset_isolation_suitable(pg_data_t *pgdat)
> if (!populated_zone(zone))
> continue;
>
> - /* Only flush if a full compaction finished recently */
> - if (zone->compact_blockskip_flush)
> - __reset_isolation_suitable(zone);
> + __reset_isolation_suitable(zone);
> }
> }
>
next prev parent reply other threads:[~2023-08-15 8:43 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-05 11:07 [PATCH 0/9] Fixes and cleanups to compaction Kemeng Shi
2023-08-05 3:14 ` Matthew Wilcox
2023-08-05 4:07 ` Kemeng Shi
2023-08-05 11:07 ` [PATCH 1/9] mm/compaction: use correct list in move_freelist_{head}/{tail} Kemeng Shi
2023-08-05 17:11 ` Andrew Morton
2023-08-07 0:37 ` Kemeng Shi
2023-08-15 7:16 ` Baolin Wang
2023-08-05 11:07 ` [PATCH 2/9] mm/compaction: call list_is_{first}/{last} more intuitively " Kemeng Shi
2023-08-15 7:49 ` Baolin Wang
2023-08-05 11:07 ` [PATCH 3/9] mm/compaction: correctly return failure with bogus compound_order in strict mode Kemeng Shi
2023-08-15 8:28 ` Baolin Wang
2023-08-15 9:22 ` Kemeng Shi
2023-08-05 11:07 ` [PATCH 4/9] mm/compaction: simplify pfn iteration in isolate_freepages_range Kemeng Shi
2023-08-15 8:38 ` Baolin Wang
2023-08-15 9:32 ` Kemeng Shi
2023-08-15 10:07 ` Baolin Wang
2023-08-15 10:37 ` Kemeng Shi
2023-08-19 11:58 ` Baolin Wang
2023-08-22 1:37 ` Kemeng Shi
2023-08-24 2:19 ` Baolin Wang
2023-08-05 11:07 ` [PATCH 5/9] mm/compaction: remove repeat compact_blockskip_flush check in reset_isolation_suitable Kemeng Shi
2023-08-15 8:42 ` Baolin Wang [this message]
2023-08-05 11:07 ` [PATCH 6/9] mm/compaction: rename is_via_compact_memory to compaction_with_allocation_order Kemeng Shi
2023-08-15 8:58 ` Baolin Wang
2023-08-15 12:04 ` Kemeng Shi
2023-08-19 12:14 ` Baolin Wang
2023-08-22 1:51 ` Kemeng Shi
2023-08-24 2:20 ` Baolin Wang
2023-08-05 11:07 ` [PATCH 7/9] mm/compaction: factor out code to test if we should run compaction for target order Kemeng Shi
2023-08-15 8:53 ` Baolin Wang
2023-08-15 12:10 ` Kemeng Shi
2023-08-19 12:27 ` Baolin Wang
2023-08-22 1:57 ` Kemeng Shi
2023-08-24 2:25 ` Baolin Wang
2023-08-24 2:59 ` Kemeng Shi
2023-08-05 11:07 ` [PATCH 8/9] mm/compaction: call compaction_suit_allocation_order in kcompactd_node_suitable Kemeng Shi
2023-08-05 11:07 ` [PATCH 9/9] mm/compaction: call compaction_suit_allocation_order in kcompactd_do_work Kemeng Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=031fb6f3-4f5b-2b3b-bc12-afa3d10ae0f0@linux.alibaba.com \
--to=baolin.wang@linux.alibaba.com \
--cc=akpm@linux-foundation.org \
--cc=david@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=shikemeng@huaweicloud.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.