From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26CEAC43217 for ; Fri, 4 Nov 2022 20:09:57 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229804AbiKDUJz (ORCPT ); Fri, 4 Nov 2022 16:09:55 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229505AbiKDUJx (ORCPT ); Fri, 4 Nov 2022 16:09:53 -0400 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0060F264B0 for ; Fri, 4 Nov 2022 13:09:51 -0700 (PDT) Received: by mail-qk1-x730.google.com with SMTP id k2so3749929qkk.7 for ; Fri, 04 Nov 2022 13:09:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=s2w2x5qgfrs2UH4lH19Zuziwi2d3oMiqWOuY2i6wV+k=; b=BbHsErvmIp1WxlY55kMFQeuoO0DjymG1Js+lbuRznbSV1gD6ahTMrtM9A+Eysndx5Y zk0RM8yBptrLXnGGPvqDk1yw2x36Dr3mvuzBtMdVdSq9wS98XYaiNDc92rCqryoEw17K H404WLabDMsRb54A2XyMj9KNNdU2Tkzn0Pv9w5eWXtxdv2i19k4fetRuDdLdBB4YPzDi Wodvrq6HdF66Oa3Hv2oPGimscsBU4Y8oUTIXe28TIVDzRcNo1qPkVu/QhW3+NfRRBMqf i8JO+je4Hh/ch7fo9SKpJD+7StAJigkt5/2uV7LjA1jLiCrcwA3eO8CA8JaISlqIdgrt e0hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s2w2x5qgfrs2UH4lH19Zuziwi2d3oMiqWOuY2i6wV+k=; b=KgC07Q/vq5vY1XWZeLP0X/ki/Ht8SbL6c9PwF62WGHRsAlTt/eTDSzb7OxcgMk6LDG g6YXId+tzpF+ke8ZEAYj0vtsIuznSEsdciggv2g+rEFek8Vh7jISwrcqHEmbWfySpHli GxeD+Ov4BEeMPUBYSaQ+lhVBU5+Rpvk5yWIsBCoZ7yDuISr0oFJ8t1I9p0CGYjAarUM4 /7CEKdXsBdlT0Pxp3lLx9a5dt1A5FhKySq5pWS6Xz3iMh6m+C6bRCgOFaqeBHdUVM4+G HAZK0eebaH9a+apAsDXArFRaKLz8uSQ+pcbiRxHfaHM1zQtwQoAr/qrWq21w5nxxLyhu 8qZA== X-Gm-Message-State: ACrzQf1zHlmVN4zloPivX3qOoQI8F7rgSAG27M4b5o49IP9qxIgF4wOk 594vZ6sKXA1sOYwPnlkkOrBCXQ== X-Google-Smtp-Source: AMsMyM6yqTk+Qn0lS01FjE4TynKZffWANmYs4XwHwnWPriRKzRd1O4hk4tVEaywrwhFRlbJEi/gw2g== X-Received: by 2002:a05:620a:400e:b0:6da:dd3c:7ff4 with SMTP id h14-20020a05620a400e00b006dadd3c7ff4mr25651530qko.682.1667592591116; Fri, 04 Nov 2022 13:09:51 -0700 (PDT) Received: from ?IPV6:2601:586:5000:570:aad6:acd8:4ed9:299b? ([2601:586:5000:570:aad6:acd8:4ed9:299b]) by smtp.gmail.com with ESMTPSA id bq33-20020a05620a46a100b006eeb3165554sm110636qkb.19.2022.11.04.13.09.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Nov 2022 13:09:50 -0700 (PDT) Message-ID: <03251423-b136-e4ff-2485-bbb16c0c7f5b@linaro.org> Date: Fri, 4 Nov 2022 16:09:49 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v1 2/7] dt-bindings: usb: hpe,gxp-udc: Add binding for gxp gadget Content-Language: en-US To: "Yu, Richard" , "Verdun, Jean-Marie" , "Hawkins, Nick" , "gregkh@linuxfoundation.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "linux@armlinux.org.uk" , "balbi@kernel.org" , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "Chang, Clay" References: <20221103160625.15574-1-richard.yu@hpe.com> <20221103160625.15574-3-richard.yu@hpe.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/11/2022 16:03, Yu, Richard wrote: > Hi Mr. Kozlowski, > > Thank you very much for your quick review and feedbacks. > > I will modify the patches based on your feedback accordingly. > > On this specific patch, you have questions on how we defined the device/gadget configurations: vdevnum and fepnum. > > Please see my answers following the questions: > >> + vdevnum: >> + description: >> + virtual device number. > > That's unusual property... Why numbering devices is part of DT (hardware description)? > >>> Richard: In HPE GXP virtual EHCI controller chipset, it can support up to 8 virtual devices(gadgets). Each device/gadget will be represented by a bit in 8 bits register. For example, the interrupt register bit 0 indicates the interrupt from device 0, bit 1 for device 1 ... so on. When an user defines a device/gadget, he/she can define the device number as between 0 and 7. Thus, the driver can up to the bit position. That is why we have numbering devices as port of DT. > >> + >> + fepnum: >> + description: >> + number of the flexible end-points this device is needed. > > Similar question. > >>> Richard: In HPE GXP virtual EHCI Controller chipset, there is a flexible EP pool. Each flexible EP has its own mapping register. The mapping register bit 0 to 3 is for device number (vdevnum) and bit 4 to 7 is for EP number inside the device. The device driver configures the mapping register to assign a flexible EP to a specific device. Here, "fepnum" is the input letting the driver know how many EP is needed for this device/gadget. > > Hope I have answered your questions on "vdevnum" and "fepnum". Unfortunately I don't see your answers... Or actually I am not sure what is the answer and what is not. What is unusual, you did not quote my email but quoted something else. Please send it again, but following normal mailing list netiquette for replies. Here is one: https://en.opensuse.org/openSUSE:Mailing_list_netiquette Just don't use corporate style of emails on mailing list. We usually cannot handle them... Best regards, Krzysztof From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E07DC4332F for ; Fri, 4 Nov 2022 20:11:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:To:Subject: MIME-Version:Date:Message-ID:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eeL+bcpxyE92wtbwWgfKlqMq1RhjfhRQEAs9T6QC33M=; b=aaH5KEXOMZANuW wu45c0AtM3hIiJXG3RQD1tawek6Y6gaA7NOr3Q3/Avwx0dYWjCR31pbQgzVbbeQRs8WyCItLv34b6 ZMMVCFUy8owapRTre121KTP6D9ugXvNze212D/e8X51gd7+KsdEfNnHHX+7dSSVmZtaeeeKplPbh/ WRH/j8KeN2ubVY93r4DBMtMSkVCEFQzgGa89xejxbVeWZebOt4SQB94M8cdlqH7lgT1RivHQEcEgY peMJKtBgv7UKJCSDE0oOVlq+eeqF4bvZN5HSWGqL15h1CiepM8CN/7oxGMn/XbFEifEwf19iLbreR 99Lv6mE3ARFf+M9s5QlQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1or30m-004zTj-Md; Fri, 04 Nov 2022 20:09:56 +0000 Received: from mail-qk1-x72c.google.com ([2607:f8b0:4864:20::72c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1or30i-004zSf-Fz for linux-arm-kernel@lists.infradead.org; Fri, 04 Nov 2022 20:09:54 +0000 Received: by mail-qk1-x72c.google.com with SMTP id 8so3769571qka.1 for ; Fri, 04 Nov 2022 13:09:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=s2w2x5qgfrs2UH4lH19Zuziwi2d3oMiqWOuY2i6wV+k=; b=BbHsErvmIp1WxlY55kMFQeuoO0DjymG1Js+lbuRznbSV1gD6ahTMrtM9A+Eysndx5Y zk0RM8yBptrLXnGGPvqDk1yw2x36Dr3mvuzBtMdVdSq9wS98XYaiNDc92rCqryoEw17K H404WLabDMsRb54A2XyMj9KNNdU2Tkzn0Pv9w5eWXtxdv2i19k4fetRuDdLdBB4YPzDi Wodvrq6HdF66Oa3Hv2oPGimscsBU4Y8oUTIXe28TIVDzRcNo1qPkVu/QhW3+NfRRBMqf i8JO+je4Hh/ch7fo9SKpJD+7StAJigkt5/2uV7LjA1jLiCrcwA3eO8CA8JaISlqIdgrt e0hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s2w2x5qgfrs2UH4lH19Zuziwi2d3oMiqWOuY2i6wV+k=; b=FfSH4W5c5rGqLAY1/iFyCvwUMijM8vsMWmOXyovwX6DUdyDpGyowjGlSlZFXSXG8tl 9kbR8pQpZiU9Sm37EI0VLCQMUZzKKkahtjBD7VkUmiO1esJrU7+0k7qbdiT8l5nSwZho JANLEA0AJDR9BvAYionuRcQg2MI3gLj2AUMvBtFUUU3y+DC6tL6nfSSaC9L1rV5/3bbI pbOY/rcJlQMjv5DSqPwryh+G9dOmk1ofI/56GdNhStKbLuk6I1tzUKz0TNu3va//vPXD Sz4bgSMTQ9u/YGyjTO/SCtvU7daz6YKcpFBrZ+uR3LuT79us95fO4fZYRv6058+kxROF R9sg== X-Gm-Message-State: ACrzQf3EHv3wJGp0GysQy52ywgwhwFXLMdPyoPkCuMOXvR5xMch028uN Jhzlsu035Z6JFrnrzBxDrNptdQ== X-Google-Smtp-Source: AMsMyM6yqTk+Qn0lS01FjE4TynKZffWANmYs4XwHwnWPriRKzRd1O4hk4tVEaywrwhFRlbJEi/gw2g== X-Received: by 2002:a05:620a:400e:b0:6da:dd3c:7ff4 with SMTP id h14-20020a05620a400e00b006dadd3c7ff4mr25651530qko.682.1667592591116; Fri, 04 Nov 2022 13:09:51 -0700 (PDT) Received: from ?IPV6:2601:586:5000:570:aad6:acd8:4ed9:299b? ([2601:586:5000:570:aad6:acd8:4ed9:299b]) by smtp.gmail.com with ESMTPSA id bq33-20020a05620a46a100b006eeb3165554sm110636qkb.19.2022.11.04.13.09.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 04 Nov 2022 13:09:50 -0700 (PDT) Message-ID: <03251423-b136-e4ff-2485-bbb16c0c7f5b@linaro.org> Date: Fri, 4 Nov 2022 16:09:49 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v1 2/7] dt-bindings: usb: hpe,gxp-udc: Add binding for gxp gadget Content-Language: en-US To: "Yu, Richard" , "Verdun, Jean-Marie" , "Hawkins, Nick" , "gregkh@linuxfoundation.org" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "linux@armlinux.org.uk" , "balbi@kernel.org" , "linux-usb@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "Chang, Clay" References: <20221103160625.15574-1-richard.yu@hpe.com> <20221103160625.15574-3-richard.yu@hpe.com> From: Krzysztof Kozlowski In-Reply-To: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221104_130952_630352_49D491B7 X-CRM114-Status: GOOD ( 22.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 04/11/2022 16:03, Yu, Richard wrote: > Hi Mr. Kozlowski, > > Thank you very much for your quick review and feedbacks. > > I will modify the patches based on your feedback accordingly. > > On this specific patch, you have questions on how we defined the device/gadget configurations: vdevnum and fepnum. > > Please see my answers following the questions: > >> + vdevnum: >> + description: >> + virtual device number. > > That's unusual property... Why numbering devices is part of DT (hardware description)? > >>> Richard: In HPE GXP virtual EHCI controller chipset, it can support up to 8 virtual devices(gadgets). Each device/gadget will be represented by a bit in 8 bits register. For example, the interrupt register bit 0 indicates the interrupt from device 0, bit 1 for device 1 ... so on. When an user defines a device/gadget, he/she can define the device number as between 0 and 7. Thus, the driver can up to the bit position. That is why we have numbering devices as port of DT. > >> + >> + fepnum: >> + description: >> + number of the flexible end-points this device is needed. > > Similar question. > >>> Richard: In HPE GXP virtual EHCI Controller chipset, there is a flexible EP pool. Each flexible EP has its own mapping register. The mapping register bit 0 to 3 is for device number (vdevnum) and bit 4 to 7 is for EP number inside the device. The device driver configures the mapping register to assign a flexible EP to a specific device. Here, "fepnum" is the input letting the driver know how many EP is needed for this device/gadget. > > Hope I have answered your questions on "vdevnum" and "fepnum". Unfortunately I don't see your answers... Or actually I am not sure what is the answer and what is not. What is unusual, you did not quote my email but quoted something else. Please send it again, but following normal mailing list netiquette for replies. Here is one: https://en.opensuse.org/openSUSE:Mailing_list_netiquette Just don't use corporate style of emails on mailing list. We usually cannot handle them... Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel