From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.0 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82580C07E99 for ; Fri, 9 Jul 2021 06:05:53 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 85B1461442 for ; Fri, 9 Jul 2021 06:05:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 85B1461442 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 2422A831F7; Fri, 9 Jul 2021 08:05:50 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1625810750; bh=YQ/9fXjwOxby3N2IXoko0R7lF1EDv2QUvxgaK/Wt73k=; h=Subject:To:Cc:References:From:Date:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=Rhq+WYDe9hCpUwFsnQMk2DuurMuNFbH1T/5VuCKeeTkNdOVQQUyg+P5uJ3L8owvkK YzX33VQGdo46CTt9R+i6uNm9I7/I5nHabrnd4covxPzCE9uuhy8zl3zPveBRSfsPZa PYQbkVK/YB2ea73OeQRbbfPBTmsPIHWNSANimTSxxouaw6HEYm9hRnI9WYAtuf/ytz Y9UEK1SuHsM/kyhRF3Nmy1wQztCJmG25lurWT2g3rRJVGH8g2hMeiMjfPORhfmzhMt zZtxsrdrL7d32OiqqzxW16xO9ps0UEqkXlH5jjFTaWtF8+zDELz+9CFe+MVmcjSzz/ 6kpnaQ1ULI/Ww== Received: by phobos.denx.de (Postfix, from userid 109) id 99BAE831FF; Fri, 9 Jul 2021 08:05:48 +0200 (CEST) Received: from mout-u-107.mailbox.org (mout-u-107.mailbox.org [91.198.250.252]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D6BAB82DB1 for ; Fri, 9 Jul 2021 08:05:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=fail smtp.mailfrom=sr@denx.de Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-u-107.mailbox.org (Postfix) with ESMTPS id 4GLjMF5B3QzQk9T; Fri, 9 Jul 2021 08:05:45 +0200 (CEST) Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter06.heinlein-hosting.de (spamfilter06.heinlein-hosting.de [80.241.56.125]) (amavisd-new, port 10030) with ESMTP id W4RcsekYczh5; Fri, 9 Jul 2021 08:05:42 +0200 (CEST) Subject: Re: [PATCH u-boot-mvebu 00/31] kwboot / kwbimage improvements To: =?UTF-8?Q?Marek_Beh=c3=ban?= , u-boot@lists.denx.de, Chris Packham , Baruch Siach , Dirk Eibach , Chris Packham Cc: Dennis Gilmore , Mario Six , Jon Nettleton References: <20210708173032.27999-1-marek.behun@nic.cz> From: Stefan Roese Message-ID: <0325eee7-7c6a-5e61-6e3d-229567b07000@denx.de> Date: Fri, 9 Jul 2021 08:05:40 +0200 MIME-Version: 1.0 In-Reply-To: <20210708173032.27999-1-marek.behun@nic.cz> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-MBO-SPAM-Probability: X-Rspamd-Score: -1.41 / 15.00 / 15.00 X-Rspamd-Queue-Id: 7CF79181E X-Rspamd-UID: 82109f X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Marek & Pali, On 08.07.21 19:30, Marek Behún wrote: > Hi Stefan and others, > > this is a series of improvements to kwboot, kwbimage and mvebu. > > The main goal of this series is to correctly use BootROM's code > for loading U-Boot from NOR / NAND: currently only SPL is read by > BootROM and the main U-Boot is read by SPL. By using BootROM to also > load main U-Boot we can reduce the size of SPL image, since it does > not need to contain code for reading NOR / NAND. Before going into a review of the patches, let me ask about the motivation of this patchset. Is the reduction of the SPL image size the main motivation for this series? Or did you experiece some problems with the SPL code for U-Boot proper loading? BTW: This patch / mail subject "kwboot / kwbimage improvements" does not really match its content AFAIU. Here, the SPL returns always back to the BootROM for U-Boot proper loading part is missing. Or do I misunderstand something? BTW2: Could you please list the affected MVEBU SoC's that are affected by this series so that this is clear? > Before merging, this series should be tested on as many relevant > boards as possible. I fully agree. I very much welcome any "Tested-by" tags and reviews from others. Thanks, Stefan > Marek & Pali > > Marek Behún (2): > tools: kwbimage: Add constant for SDIO bootfrom > tools: kwbimage: Cosmetic fix - remove redundant space character > > Pali Rohár (29): > tools: kwbimage: Fix compilation without CONFIG_SYS_U_BOOT_OFFS > tools: kwbimage: Simplify aligning and calculating checksum > tools: kwbimage: Align SPI and NAND images to 256 bytes > tools: kwbimage: Fix generation of SATA, SDIO and PCIe images > tools: kwbimage: Don't crash when binary file name does not contain > '/' > tools: kwbimage: Fix check for v0 extended header checksum > tools: kwbimage: Validate extended headers of v1 images > tools: kwbimage: Validate data checksum of v1 images > tools: kwbimage: Print size of binary header in > kwbimage_print_header() > tools: kwboot: Fix wrong parameter passed to read() > tools: kwboot: Fix restoring terminal > tools: kwboot: Print trailing newline after terminal is terminated > tools: kwboot: Cosmetic fix - add missing curly brackets > tools: kwboot: Check for v1 header size > tools: kwbimage: Use -a parameter (load address) for v1 images > arm: mvebu: Fix return_to_bootrom() > arm: mvebu: Mark return_to_bootrom() as a noreturn function > arm: mvebu: Implement return_to_bootrom() via U-Boot's SPL framework > arm: mvebu: Use U-Boot's SPL BootROM framework for booting from > NAND/UART > arm: mvebu: Always use BootROM for loading the rest of U-Boot's binary > arm: mvebu: gdsys: Remove custom spl_board_init() > arm: mvebu: Remove legacy U-Boot header from kwbimage v1 files > tools: kwbimage: Remove v1 kwbimage SPL padding to > CONFIG_SYS_U_BOOT_OFFS bytes > arm: mvebu: Remove unused macro CONFIG_SYS_U_BOOT_OFFS > tools: kwbimage: Add support for more BINARY headers > tools: kwbimage: Don't parse PAYLOAD keyword > tools: kwbimage: Add support for DATA command also for v1 images > tools: kwbimage: Add support for a new DATA_DELAY command > tools: kwbimage: Do not hide usage of secure header under > CONFIG_ARMADA_38X > > Makefile | 2 +- > arch/arm/mach-mvebu/Kconfig | 16 +- > arch/arm/mach-mvebu/include/mach/cpu.h | 2 +- > arch/arm/mach-mvebu/lowlevel_spl.S | 3 +- > arch/arm/mach-mvebu/spl.c | 90 +------ > board/gdsys/a38x/Makefile | 2 +- > board/gdsys/a38x/spl.c | 20 -- > include/configs/clearfog.h | 6 +- > include/configs/controlcenterdc.h | 8 +- > include/configs/db-88f6720.h | 3 - > include/configs/db-88f6820-amc.h | 5 - > include/configs/db-88f6820-gp.h | 6 - > include/configs/db-mv784mp-gp.h | 3 - > include/configs/ds414.h | 5 - > include/configs/helios4.h | 6 +- > include/configs/theadorable.h | 3 - > include/configs/turris_omnia.h | 6 - > include/configs/x530.h | 3 - > scripts/config_whitelist.txt | 1 - > tools/Makefile | 8 - > tools/kwbimage.c | 339 +++++++++++++++++-------- > tools/kwbimage.h | 30 ++- > tools/kwboot.c | 14 +- > 23 files changed, 296 insertions(+), 285 deletions(-) > delete mode 100644 board/gdsys/a38x/spl.c > Viele Grüße, Stefan -- DENX Software Engineering GmbH, Managing Director: Wolfgang Denk HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-51 Fax: (+49)-8142-66989-80 Email: sr@denx.de