From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7EBEC432BE for ; Wed, 1 Sep 2021 11:01:47 +0000 (UTC) Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by mail.kernel.org (Postfix) with ESMTP id 135BD61008 for ; Wed, 1 Sep 2021 11:01:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 135BD61008 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dpdk.org Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E52040140; Wed, 1 Sep 2021 13:01:46 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id 34EBA4013F for ; Wed, 1 Sep 2021 13:01:44 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10093"; a="205940959" X-IronPort-AV: E=Sophos;i="5.84,369,1620716400"; d="scan'208";a="205940959" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2021 04:01:43 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,369,1620716400"; d="scan'208";a="428583158" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga003.jf.intel.com with ESMTP; 01 Sep 2021 04:01:43 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 1 Sep 2021 04:01:42 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Wed, 1 Sep 2021 04:01:42 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 1 Sep 2021 04:01:42 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.171) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Wed, 1 Sep 2021 04:01:41 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eMOoJeWZD0f8eTyTErkUfXcGGwKib4Ho2Xcooo67fzNvgEdPgycMzkvk7s9FgoODtz8lD0XBmzm/YM06MAOyFiNZ7x4QxHK7AKlW0K1IipGguxLbq1UsMhbLITRLhUQi/1Kp7JwhZobclIBcQNoyI+8Y1RAfkcF93MMtV4PaEMPYQig7AsaK6+XENf9XGdRdkxCecdLdXSpvQ9AOcLDVNYWrmsUbDe84Ggujcbho7xWFtu11LpmsdoDNplXkj2ZzqPl7ZMFq9SOQldKqQu7RQCO0n+rx+x43lGgAW1V3ktSkjbbe5nJBwGrwqYQyTgLizk5cViHPYT18IbtaRN8pbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=qwkXij1fpGAN8ffags9Pm8tuZIsRN/nJFO2FkLVCkV4=; b=ELEIPT0N7CnssMSHQFr0y4qzByyG8Fmi4ioN6FggHTyd+zZnK/j1/E8YsYMhtXffwiizqwIm1CUxklwBaWkDOLwogzb9GduOjQWTT88CZmYxaulsJP0Goh0diCCDpXz4dVAeTHgsqsev0r94VxSpQu+t/afzpeiicoE1zQJFCIJ7YuyJizkvSjg+EZXkK6FMabvHvXiOggF8ejZBnlBt8pv92Wm2ROQWyLYsIkXcZazFNLtgEhXbekjkKUqzx3nLIIsPcN7DKixJHvbNZviqzZUvzPyr714nGx91RTQeMAuEnZZ544IM3x9uQrN/U3kaNOK8gUJoB17qVrhcqQ7vYQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qwkXij1fpGAN8ffags9Pm8tuZIsRN/nJFO2FkLVCkV4=; b=vx1XDCcKcSTpugbo3ZKeLN/48oIhYiZfxbrPxwTDPABf5tpd9q8Top6LWqud6fW038sY6WhyOCHqnE6AepvBtx0eSzLctsRq6wjNqzSrzOtk7KYMGCkpXJO6gkGmcm4b9SN1qyy0155tZb2AwH57DB2fCQtKPcLG+m3fYm23pvY= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5093.namprd11.prod.outlook.com (2603:10b6:510:3e::23) by PH0PR11MB4822.namprd11.prod.outlook.com (2603:10b6:510:39::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17; Wed, 1 Sep 2021 11:01:36 +0000 Received: from PH0PR11MB5093.namprd11.prod.outlook.com ([fe80::d145:710a:1bac:7e91]) by PH0PR11MB5093.namprd11.prod.outlook.com ([fe80::d145:710a:1bac:7e91%8]) with mapi id 15.20.4478.020; Wed, 1 Sep 2021 11:01:36 +0000 To: Ferruh Yigit , "Ding, Xuan" , "dev@dpdk.org" CC: "maxime.coquelin@redhat.com" , "Xia, Chenbo" , "Hu, Jiayu" , "Richardson, Bruce" References: <20210831131039.29964-1-xuan.ding@intel.com> <2c9fc397-df61-2ef6-0cce-db5dbbb1c952@intel.com> <926d7065-481f-b84e-1d05-bdeebd31d6ea@intel.com> From: "Burakov, Anatoly" Message-ID: <032e666a-9ada-f4c0-36bc-ad9b5fac4359@intel.com> Date: Wed, 1 Sep 2021 12:01:30 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Firefox/78.0 Thunderbird/78.13.0 In-Reply-To: <926d7065-481f-b84e-1d05-bdeebd31d6ea@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB6PR0301CA0097.eurprd03.prod.outlook.com (2603:10a6:6:30::44) To PH0PR11MB5093.namprd11.prod.outlook.com (2603:10b6:510:3e::23) MIME-Version: 1.0 Received: from [192.168.1.12] (212.17.34.161) by DB6PR0301CA0097.eurprd03.prod.outlook.com (2603:10a6:6:30::44) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4478.17 via Frontend Transport; Wed, 1 Sep 2021 11:01:35 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0bbdeb63-dfe8-4283-3f65-08d96d37ddd6 X-MS-TrafficTypeDiagnostic: PH0PR11MB4822: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:10000; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5d2+XpyOJ+9PCwYJBU+upADCqBMkoki6VNCfKbtNiRCW1dGI1FEgsFTs6D55cTNw8I7DULWv/wFMCCHZKytXRNPxOCW5cyL9NvWa6auDajgeuTU53e2Q6YoA4A4vw7JYllJlEfUfdwVDND8MnlMNMyrZ73Dm4wvjTyU31q8L78xEi3D6ngD4JkKedLTio8IsTgc10GenpO8VpAImdDCb30jTQ6NUekknd2Pokkyu+ci6hheH4I2ONi/l/G2Sno8+ogXu56xpAnYJtDYZqwRwcFDP90C6TrPvDeV9KbV0go9WrttXmUP63WiuM/x40CDReYehuSDnkJr2vp4uzxMrBtshWxfvrSRvz9odkIwmdofHne6qWjeL8AKpqOI+LKlT34I0hmqwJvA/fziJ8b/vFbmVqeWiYVRpjg8DeECfUkT2nPI0kCJe5f9WMJCENDn3mGoM2b58PpQzypA/0vMCEmEA6phvJkpQb3ER4EUw9rTvb3jiRoEgERZaE4kaMg3XIzz52+w/wZrh08mzE4UTkCmqZ17EUzYpBealwspynAUf5lLzlSMzGPHsS0/twYP+dOnz4oOB9VF2OXYJCHqJXWBD42/wHNhdiuCJUhaWx03G8/JBRoblUL3kH379Jy5r+TOBsUuYbqCDjX+qO5J8q6hI+3sjbhu5O8tjUiw4oRFXgTGFasFHoXmT9igB61K0rwSApS5+THuOT0ewmu+qo2QuflYd6piNI40Jlmv8tJBBVaUIHIsNW7g8qY/TrbGnDcXQZN2KqeYPGJZ8hGYzlJuOty3s7/6a7in1E9ufaOTz3B7G6TLHcm5ECfHJNf2x X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5093.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(136003)(366004)(346002)(396003)(376002)(36756003)(26005)(8676002)(38100700002)(956004)(186003)(8936002)(54906003)(110136005)(16576012)(83380400001)(6486002)(53546011)(66556008)(66476007)(66946007)(6666004)(2616005)(107886003)(31696002)(2906002)(5660300002)(4326008)(31686004)(86362001)(316002)(478600001)(966005)(43740500002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?WG0rWWRlczljeE1YeDRTLzQwUHVNYm1MZC9KRGlaM3hQWGgxRjE2S1ZNVWx6?= =?utf-8?B?SjArbjBQQ2lKd2J3c004MjhKWGtTM2pxQ0U2S2JoaGpLUUM0VHpuU1NrWHBs?= =?utf-8?B?aFBvSGhiSGhBQ3U2Mi9qV1FtbW95MjZ4eGpFM1BJLzBEMUJEeHBaWmZISFpu?= =?utf-8?B?LzZIa2lOd2g4M09oUHFUWU00WFNkcXlmUWdROFB5M2liQkU0a2d1RnlVbEQv?= =?utf-8?B?eGZYcVY4bjFwbEJMWUhyVWI4dVBjUDVlK0VHN3QvZFk3QUMxa0VnWjNHMUU3?= =?utf-8?B?Y21hVDlhL2xhbytOYlBUcG1kNDdvNFZPQ3cwUjJPSVEva21UVlV5dEMzL3hr?= =?utf-8?B?cEtiN1IxbTFOZTNQS0xVV3g3Z0szWHlJWE5qdEFFTFpIZ0J0MVkyTVgwdUI5?= =?utf-8?B?bFNrMnFua2h3VS9oVzFHZjlaVHdwVi9lRHpmVDNFOGErYjF5bTFIRjY5RkF2?= =?utf-8?B?YzhSZ3JpSzBLUWlFZTBnNW5RTk11MGRwOTQ4WkpxUGF5ODU5L1MvT0s2R0or?= =?utf-8?B?L3FCQnJJZzlLcFdCdmcwbmlJY0E4MUxCWDFtUDcrVGt5WktiUFd3Y2hnTmRZ?= =?utf-8?B?K2lWYzRIamZJaFBtT2F4WWFYQlJETlg0VzhoNmV0aHNwNExWVUFPSXN4RUVa?= =?utf-8?B?QmxXYjgyUnU2S21weTV5NlNaQml0L2hBRjNtN0IyaERvb3lJL0huOGxQYUNY?= =?utf-8?B?blhiRWVGcmlyMytScTc1cnkybHAyK2dHRGRkNER5T2hVK3NJSkxtNGtWd0s1?= =?utf-8?B?Y081V3FwcExUZzhDaWZUUkEzY292UjNpQlljeDBrL2VMRXplYnJJQWd4ZURX?= =?utf-8?B?RUhqQnFpNVRmMjc2Y2U1RksrUXNCekdWNk16cm0vemFOZ3RUcFY1UE9IcG11?= =?utf-8?B?Z2hGRkRYUXhHVHlYQ0g4YURJdHZ5U2t6K1pxRlRDckU4R0tmQnlGbGxzTk0r?= =?utf-8?B?a05HMGY0NU82cVpoT3h4K2xIams3UVNwYnFvRmFWWnRpK0pIY2pNa2JOYjhI?= =?utf-8?B?YStpTnN1Z0k3NXVLdDZLa3VEWG9SMU9ubEtHN1M0MGFkVVZLb2EvRHlodTRn?= =?utf-8?B?QUhTUUpQSDNBWGVud3BKc1g1T0d3QTl4azZDTHk5SHYwZUNkODFNNm9UREJM?= =?utf-8?B?cGFoYUVVdlMrV014UjlmeGhRMzNvcDBxbDVNMWhEbDhkUTlVc0ZYb1JDbEdH?= =?utf-8?B?RFVZQnNHZWhSVWw1elUvM2xZRU5xWFNnajR6VStzUlhacTdaVXk0M0xyOEFK?= =?utf-8?B?aDdkWEtpM1VvT1A0cVlFUldiZitQK1lYY1A2b2ZmRWcvcVNXcmNQV1ZmNGF3?= =?utf-8?B?VXdBdTdhRThmMVhKYWhEeWkwMC9FSkQvdDNzbHNDczZ4ZUlmcDhpNXVudHVa?= =?utf-8?B?MG1mMSt5aTRBNGpVeGVDOS9EeXpUd3pEeTl1b3VSWW85KzI0SFdmZXNoS3I0?= =?utf-8?B?OVRJbGthUUZ4VkxrbHVpTVAzbUlCYXpDNEhraE50TTNrY3MzWGliMFlHR1Uv?= =?utf-8?B?Q1dSeFFDb3dqNit4RmU5dE9wOURjNFRvUXkrRW4wemlqOW1wbms3Y0oyYmlF?= =?utf-8?B?SlIwL0Fhd3prVnpBaEc2RldIV1RKNmtFZ2QrMDNpRDhtVTYyd1FPN0t4NzVC?= =?utf-8?B?a2Q5a0ExZ0VBVmRIOTJPc2pNNVNPQlN3NFVCdCtnWERFd1pDaGNaY2s2ODJU?= =?utf-8?B?WXlGSE0wZ2hCZUlGNGtJS3JiWXNoRjhTZVdzRE4vZTQxcFZuZElyVy9Wd3JU?= =?utf-8?Q?/KOAlEGrhXxKqP8ydvoTBse4xiZMOgjVU22KfgE?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0bbdeb63-dfe8-4283-3f65-08d96d37ddd6 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5093.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2021 11:01:36.3782 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 3Pp3jROte8U9Iswt/0rLkd2+84nGApBDb23S7O40gzTkX8f55qXmC3Te0huwtgi3boYLuERK+9fhPIZs0UR3p3vP0k5Tl+mcKoJyt9xZgqo= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4822 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] doc: announce change in vfio dma mapping X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 01-Sep-21 10:56 AM, Ferruh Yigit wrote: > On 9/1/2021 2:41 AM, Ding, Xuan wrote: >> Hi Ferruh, >> >>> -----Original Message----- >>> From: Yigit, Ferruh >>> Sent: Wednesday, September 1, 2021 12:01 AM >>> To: Ding, Xuan ; dev@dpdk.org; Burakov, Anatoly >>> >>> Cc: maxime.coquelin@redhat.com; Xia, Chenbo ; Hu, >>> Jiayu ; Richardson, Bruce >>> Subject: Re: [PATCH] doc: announce change in vfio dma mapping >>> >>> On 8/31/2021 2:10 PM, Xuan Ding wrote: >>>> Currently, the VFIO subsystem will compact adjacent DMA regions for the >>>> purposes of saving space in the internal list of mappings. This has a >>>> side effect of compacting two separate mappings that just happen to be >>>> adjacent in memory. Since VFIO implementation on IA platforms also does >>>> not allow partial unmapping of memory mapped for DMA, the current >>> DPDK >>>> VFIO implementation will prevent unmapping of accidentally adjacent >>>> maps even though it could have been unmapped [1]. >>>> >>>> The proper fix for this issue is to change the VFIO DMA mapping API to >>>> also include page size, and always map memory page-by-page. >>>> >>>> [1] https://mails.dpdk.org/archives/dev/2021-July/213493.html >>>> >>>> Signed-off-by: Xuan Ding >>>> --- >>>> doc/guides/rel_notes/deprecation.rst | 3 +++ >>>> 1 file changed, 3 insertions(+) >>>> >>>> diff --git a/doc/guides/rel_notes/deprecation.rst >>> b/doc/guides/rel_notes/deprecation.rst >>>> index 76a4abfd6b..1234420caf 100644 >>>> --- a/doc/guides/rel_notes/deprecation.rst >>>> +++ b/doc/guides/rel_notes/deprecation.rst >>>> @@ -287,3 +287,6 @@ Deprecation Notices >>>> reserved bytes to 2 (from 3), and use 1 byte to indicate warnings and >>> other >>>> information from the crypto/security operation. This field will be used to >>>> communicate events such as soft expiry with IPsec in lookaside mode. >>>> + >>>> +* vfio: the functions `rte_vfio_container_dma_map` will be amended to >>>> + include page size. This change is targeted for DPDK 22.02. >>>> >>> >>> Is this means adding a new parameter to API? >>> If so this is an ABI/API break and we can't do this change in the 22.02. >> >> Our original plan is add a new parameter in order not to use a new function name, so you mean, any changes to the API can only be done in the LTS version? >> If so, we can only add a new API and retire the old one in 22.11. >> > > We can add a new API anytime. Adding new parameter to an existing API can be > done on the ABI break release. So, 22.11 then? > > You can add the new API in this release, and start using it. > And mark the old API as deprecated in this release. This lets existing binaries > to keep using it, but app needs to switch to new API for compilation. > Old API can be removed on 22.11, and you will need a deprecation notice before > 22.11 for it. > > Is above plan works for you? > We have slightly rethought our approach, and the functionality that Xuan requires does not rely on this API. They can, for all intents and purposes, be considered unrelated issues. I still think it's a good idea to update the API that way, so I would like to do that, and if we have to wait until 22.11 to fix it, I'm OK with that. Since there no longer is any urgency here, it's acceptable to wait for the next LTS to break it. -- Thanks, Anatoly