From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BA713C071FF for ; Mon, 23 Sep 2019 20:53:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7C12020856 for ; Mon, 23 Sep 2019 20:53:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="p3GRkh3S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7C12020856 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2BEA66B02AE; Mon, 23 Sep 2019 16:53:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 295916B02B0; Mon, 23 Sep 2019 16:53:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1AABF6B02B1; Mon, 23 Sep 2019 16:53:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0096.hostedemail.com [216.40.44.96]) by kanga.kvack.org (Postfix) with ESMTP id EF4826B02AE for ; Mon, 23 Sep 2019 16:53:34 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with SMTP id 9074C181AC9B6 for ; Mon, 23 Sep 2019 20:53:34 +0000 (UTC) X-FDA: 75967386348.08.tray33_209ac674aa03 X-HE-Tag: tray33_209ac674aa03 X-Filterd-Recvd-Size: 4963 Received: from hqemgate16.nvidia.com (hqemgate16.nvidia.com [216.228.121.65]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Mon, 23 Sep 2019 20:53:33 +0000 (UTC) Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 23 Sep 2019 13:53:38 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Mon, 23 Sep 2019 13:53:32 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Mon, 23 Sep 2019 13:53:32 -0700 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 23 Sep 2019 20:53:32 +0000 Received: from [10.110.48.28] (10.124.1.5) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 23 Sep 2019 20:53:32 +0000 Subject: Re: [PATCH v2 02/11] asm-generic/pgtable: Adds dummy functions to monitor lockless pgtable walks To: Leonardo Bras , , CC: Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Arnd Bergmann , Aneesh Kumar K.V , "Christophe Leroy" , Andrew Morton , Dan Williams , Nicholas Piggin , Mahesh Salgaonkar , Thomas Gleixner , Richard Fontana , Ganesh Goudar , Allison Randal , "Greg Kroah-Hartman" , Mike Rapoport , YueHaibing , Ira Weiny , Jason Gunthorpe , Keith Busch , Linux-MM References: <20190920195047.7703-1-leonardo@linux.ibm.com> <20190920195047.7703-3-leonardo@linux.ibm.com> <007934281451e843a0428dc1e674f9dae149b75b.camel@linux.ibm.com> X-Nvconfidentiality: public From: John Hubbard Message-ID: <0339a482-48b9-ca22-ff13-4892500844dc@nvidia.com> Date: Mon, 23 Sep 2019 13:53:31 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <007934281451e843a0428dc1e674f9dae149b75b.camel@linux.ibm.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To DRHQMAIL107.nvidia.com (10.27.9.16) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1569272019; bh=Rg3KZ0g5slXwrYm7QwCemgYQBaqe/QDUEENbhGWrHpI=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=p3GRkh3SrNbDF4z4y2JzDeQftWX/RAHi/RTO54xJeEwcKtRCSmSi8MpfjY0XqDLpv +ojFovxvh95v9OgzrB4FP5Dles2JkDcAuKzolHbdCOdizBHjchiP0mL/rpb5Yh0iiJ QMOr3X+iZI/55r8GzIywT3uxA2UDvmJijrEZ72zFAzt+ujgVy5n9CmbKQH5Tr+EGpA xVPCkXkfvxuGMt1J+gp21r8iudz4aWf3w93rlTpyGOpdvEPEUZNeferMk017/G9Qm4 DoN+vO+vOwVCVsQ+Hqs5zSi9ukaAbf+wDnst4WVoGDLb4TnH4lb5PVTnZt//WI0Yny Vp3HPbUd1DZOQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/23/19 1:48 PM, Leonardo Bras wrote: > Thanks for the feedback, > > On Mon, 2019-09-23 at 13:39 -0700, John Hubbard wrote: >> Please remember to include linux-mm if there is a v2. > > Sure, I will include on v3. > >> Nit: seems like it would be nicer to just put it all in one place, and use >> positive logic, and also I think people normally don't compress the empty >> functions quite that much. So like this: > > I did this by following the default on the rest of this file. > As you can see, all other features use the standard of > #ifndef SOMETHING > dummy/generic functions > #endif > > Declaring the functions become responsibility of the arch. I noticed that, but...well, I guess you're right. Follow the way it is. :) thanks, -- John Hubbard NVIDIA > >> #ifdef __HAVE_ARCH_LOCKLESS_PGTBL_WALK_COUNTER >> void start_lockless_pgtbl_walk(struct mm_struct *mm); >> void end_lockless_pgtbl_walk(struct mm_struct *mm); >> int running_lockless_pgtbl_walk(struct mm_struct *mm); >> >> #else >> static inline void start_lockless_pgtbl_walk(struct mm_struct *mm) >> { >> } >> static inline void end_lockless_pgtbl_walk(struct mm_struct *mm) >> { >> } >> static inline int running_lockless_pgtbl_walk(struct mm_struct *mm) >> { >> return 0; >> } >> #endif >> >> thanks, From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.0 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A17DC00300 for ; Mon, 23 Sep 2019 21:00:41 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3410121971 for ; Mon, 23 Sep 2019 20:59:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="p3GRkh3S" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3410121971 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=nvidia.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from bilbo.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 46ccBx3pXczDqKK for ; Tue, 24 Sep 2019 06:59:37 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nvidia.com (client-ip=216.228.121.65; helo=hqemgate16.nvidia.com; envelope-from=jhubbard@nvidia.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=nvidia.com Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=nvidia.com header.i=@nvidia.com header.b="p3GRkh3S"; dkim-atps=neutral Received: from hqemgate16.nvidia.com (hqemgate16.nvidia.com [216.228.121.65]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 46cc42171ZzDqMk for ; Tue, 24 Sep 2019 06:53:37 +1000 (AEST) Received: from hqpgpgate102.nvidia.com (Not Verified[216.228.121.13]) by hqemgate16.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Mon, 23 Sep 2019 13:53:38 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate102.nvidia.com (PGP Universal service); Mon, 23 Sep 2019 13:53:32 -0700 X-PGP-Universal: processed; by hqpgpgate102.nvidia.com on Mon, 23 Sep 2019 13:53:32 -0700 Received: from DRHQMAIL107.nvidia.com (10.27.9.16) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 23 Sep 2019 20:53:32 +0000 Received: from [10.110.48.28] (10.124.1.5) by DRHQMAIL107.nvidia.com (10.27.9.16) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 23 Sep 2019 20:53:32 +0000 Subject: Re: [PATCH v2 02/11] asm-generic/pgtable: Adds dummy functions to monitor lockless pgtable walks To: Leonardo Bras , , References: <20190920195047.7703-1-leonardo@linux.ibm.com> <20190920195047.7703-3-leonardo@linux.ibm.com> <007934281451e843a0428dc1e674f9dae149b75b.camel@linux.ibm.com> X-Nvconfidentiality: public From: John Hubbard Message-ID: <0339a482-48b9-ca22-ff13-4892500844dc@nvidia.com> Date: Mon, 23 Sep 2019 13:53:31 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <007934281451e843a0428dc1e674f9dae149b75b.camel@linux.ibm.com> X-Originating-IP: [10.124.1.5] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To DRHQMAIL107.nvidia.com (10.27.9.16) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1569272019; bh=Rg3KZ0g5slXwrYm7QwCemgYQBaqe/QDUEENbhGWrHpI=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=p3GRkh3SrNbDF4z4y2JzDeQftWX/RAHi/RTO54xJeEwcKtRCSmSi8MpfjY0XqDLpv +ojFovxvh95v9OgzrB4FP5Dles2JkDcAuKzolHbdCOdizBHjchiP0mL/rpb5Yh0iiJ QMOr3X+iZI/55r8GzIywT3uxA2UDvmJijrEZ72zFAzt+ujgVy5n9CmbKQH5Tr+EGpA xVPCkXkfvxuGMt1J+gp21r8iudz4aWf3w93rlTpyGOpdvEPEUZNeferMk017/G9Qm4 DoN+vO+vOwVCVsQ+Hqs5zSi9ukaAbf+wDnst4WVoGDLb4TnH4lb5PVTnZt//WI0Yny Vp3HPbUd1DZOQ== X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jason Gunthorpe , Thomas Gleixner , Arnd Bergmann , Greg Kroah-Hartman , YueHaibing , Keith Busch , Nicholas Piggin , Mike Rapoport , Mahesh Salgaonkar , Richard Fontana , Linux-MM , Paul Mackerras , "Aneesh Kumar K.V" , Ganesh Goudar , Andrew Morton , Ira Weiny , Dan Williams , Allison Randal Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On 9/23/19 1:48 PM, Leonardo Bras wrote: > Thanks for the feedback, > > On Mon, 2019-09-23 at 13:39 -0700, John Hubbard wrote: >> Please remember to include linux-mm if there is a v2. > > Sure, I will include on v3. > >> Nit: seems like it would be nicer to just put it all in one place, and use >> positive logic, and also I think people normally don't compress the empty >> functions quite that much. So like this: > > I did this by following the default on the rest of this file. > As you can see, all other features use the standard of > #ifndef SOMETHING > dummy/generic functions > #endif > > Declaring the functions become responsibility of the arch. I noticed that, but...well, I guess you're right. Follow the way it is. :) thanks, -- John Hubbard NVIDIA > >> #ifdef __HAVE_ARCH_LOCKLESS_PGTBL_WALK_COUNTER >> void start_lockless_pgtbl_walk(struct mm_struct *mm); >> void end_lockless_pgtbl_walk(struct mm_struct *mm); >> int running_lockless_pgtbl_walk(struct mm_struct *mm); >> >> #else >> static inline void start_lockless_pgtbl_walk(struct mm_struct *mm) >> { >> } >> static inline void end_lockless_pgtbl_walk(struct mm_struct *mm) >> { >> } >> static inline int running_lockless_pgtbl_walk(struct mm_struct *mm) >> { >> return 0; >> } >> #endif >> >> thanks,