From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32E65C48BE6 for ; Mon, 14 Jun 2021 08:09:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 02C17613C5 for ; Mon, 14 Jun 2021 08:09:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232615AbhFNILv (ORCPT ); Mon, 14 Jun 2021 04:11:51 -0400 Received: from frasgout.his.huawei.com ([185.176.79.56]:3228 "EHLO frasgout.his.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232528AbhFNILu (ORCPT ); Mon, 14 Jun 2021 04:11:50 -0400 Received: from fraeml705-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4G3P0s5vvHz6H7n1; Mon, 14 Jun 2021 15:56:45 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml705-chm.china.huawei.com (10.206.15.54) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 14 Jun 2021 10:09:46 +0200 Received: from [10.47.95.26] (10.47.95.26) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 14 Jun 2021 09:09:46 +0100 Subject: Re: [PATCH v12 3/5] iommu/vt-d: Add support for IOMMU default DMA mode build options To: Lu Baolu , , , , CC: , , , , References: <1623414043-40745-1-git-send-email-john.garry@huawei.com> <1623414043-40745-4-git-send-email-john.garry@huawei.com> From: John Garry Message-ID: <03675e2f-c3a6-ce33-ef96-f9ae544b2d13@huawei.com> Date: Mon, 14 Jun 2021 09:03:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Originating-IP: [10.47.95.26] X-ClientProxiedBy: lhreml725-chm.china.huawei.com (10.201.108.76) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/06/2021 03:14, Lu Baolu wrote: > On 2021/6/11 20:20, John Garry wrote: >> diff --git a/drivers/iommu/Kconfig b/drivers/iommu/Kconfig >> index 2a71347611d4..4467353f981b 100644 >> --- a/drivers/iommu/Kconfig >> +++ b/drivers/iommu/Kconfig >> @@ -94,6 +94,7 @@ choice >>       prompt "IOMMU default DMA mode" >>       depends on IOMMU_DMA >> +    default IOMMU_DEFAULT_LAZY if INTEL_IOMMU >>       default IOMMU_DEFAULT_STRICT > > If two default values are different. Which one will be overridden? If I understand your question correctly, I think you are asking if both are set: CONFIG_IOMMU_DEFAULT_LAZY=y CONFIG_IOMMU_DEFAULT_STRICT=y If this happens, then make defconfig complains about both being set, and selects the 2nd, whatever that is. If neither are set, then IOMMU_DEFAULT_LAZY is set if INTEL_IOMMU is set, otherwise IOMMU_DEFAULT_STRICT. Thanks, John From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 533BDC48BE6 for ; Mon, 14 Jun 2021 08:09:55 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EE039613C5 for ; Mon, 14 Jun 2021 08:09:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE039613C5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=iommu-bounces@lists.linux-foundation.org Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id BB2AB83A72; Mon, 14 Jun 2021 08:09:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id or3wE4ihHrPf; Mon, 14 Jun 2021 08:09:52 +0000 (UTC) Received: from lists.linuxfoundation.org (lf-lists.osuosl.org [IPv6:2605:bc80:3010:104::8cd3:938]) by smtp1.osuosl.org (Postfix) with ESMTPS id 8B952834F4; Mon, 14 Jun 2021 08:09:52 +0000 (UTC) Received: from lf-lists.osuosl.org (localhost [127.0.0.1]) by lists.linuxfoundation.org (Postfix) with ESMTP id 6352DC000E; Mon, 14 Jun 2021 08:09:52 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by lists.linuxfoundation.org (Postfix) with ESMTP id E1AF3C000B for ; Mon, 14 Jun 2021 08:09:50 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id CE90B60642 for ; Mon, 14 Jun 2021 08:09:50 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id wM-mOOBjT-rI for ; Mon, 14 Jun 2021 08:09:49 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by smtp3.osuosl.org (Postfix) with ESMTPS id AA0966059E for ; Mon, 14 Jun 2021 08:09:49 +0000 (UTC) Received: from fraeml705-chm.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4G3P0s5vvHz6H7n1; Mon, 14 Jun 2021 15:56:45 +0800 (CST) Received: from lhreml724-chm.china.huawei.com (10.201.108.75) by fraeml705-chm.china.huawei.com (10.206.15.54) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2176.2; Mon, 14 Jun 2021 10:09:46 +0200 Received: from [10.47.95.26] (10.47.95.26) by lhreml724-chm.china.huawei.com (10.201.108.75) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.2; Mon, 14 Jun 2021 09:09:46 +0100 Subject: Re: [PATCH v12 3/5] iommu/vt-d: Add support for IOMMU default DMA mode build options To: Lu Baolu , , , , References: <1623414043-40745-1-git-send-email-john.garry@huawei.com> <1623414043-40745-4-git-send-email-john.garry@huawei.com> From: John Garry Message-ID: <03675e2f-c3a6-ce33-ef96-f9ae544b2d13@huawei.com> Date: Mon, 14 Jun 2021 09:03:43 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.1.2 MIME-Version: 1.0 In-Reply-To: Content-Language: en-US X-Originating-IP: [10.47.95.26] X-ClientProxiedBy: lhreml725-chm.china.huawei.com (10.201.108.76) To lhreml724-chm.china.huawei.com (10.201.108.75) X-CFilter-Loop: Reflected Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com X-BeenThere: iommu@lists.linux-foundation.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: Development issues for Linux IOMMU support List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Errors-To: iommu-bounces@lists.linux-foundation.org Sender: "iommu" T24gMTIvMDYvMjAyMSAwMzoxNCwgTHUgQmFvbHUgd3JvdGU6Cj4gT24gMjAyMS82LzExIDIwOjIw LCBKb2huIEdhcnJ5IHdyb3RlOgo+PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9pb21tdS9LY29uZmln IGIvZHJpdmVycy9pb21tdS9LY29uZmlnCj4+IGluZGV4IDJhNzEzNDc2MTFkNC4uNDQ2NzM1M2Y5 ODFiIDEwMDY0NAo+PiAtLS0gYS9kcml2ZXJzL2lvbW11L0tjb25maWcKPj4gKysrIGIvZHJpdmVy cy9pb21tdS9LY29uZmlnCj4+IEBAIC05NCw2ICs5NCw3IEBAIGNob2ljZQo+PiDCoMKgwqDCoMKg IHByb21wdCAiSU9NTVUgZGVmYXVsdCBETUEgbW9kZSIKPj4gwqDCoMKgwqDCoCBkZXBlbmRzIG9u IElPTU1VX0RNQQo+PiArwqDCoMKgIGRlZmF1bHQgSU9NTVVfREVGQVVMVF9MQVpZIGlmIElOVEVM X0lPTU1VCj4+IMKgwqDCoMKgwqAgZGVmYXVsdCBJT01NVV9ERUZBVUxUX1NUUklDVAo+IAo+IElm IHR3byBkZWZhdWx0IHZhbHVlcyBhcmUgZGlmZmVyZW50LiBXaGljaCBvbmUgd2lsbCBiZSBvdmVy cmlkZGVuPwoKSWYgSSB1bmRlcnN0YW5kIHlvdXIgcXVlc3Rpb24gY29ycmVjdGx5LCBJIHRoaW5r IHlvdSBhcmUgYXNraW5nIGlmIGJvdGggCmFyZSBzZXQ6CkNPTkZJR19JT01NVV9ERUZBVUxUX0xB Wlk9eQpDT05GSUdfSU9NTVVfREVGQVVMVF9TVFJJQ1Q9eQoKSWYgdGhpcyBoYXBwZW5zLCB0aGVu IG1ha2UgZGVmY29uZmlnIGNvbXBsYWlucyBhYm91dCBib3RoIGJlaW5nIHNldCwgYW5kIApzZWxl Y3RzIHRoZSAybmQsIHdoYXRldmVyIHRoYXQgaXMuCgpJZiBuZWl0aGVyIGFyZSBzZXQsIHRoZW4g SU9NTVVfREVGQVVMVF9MQVpZIGlzIHNldCBpZiBJTlRFTF9JT01NVSBpcyAKc2V0LCBvdGhlcndp c2UgSU9NTVVfREVGQVVMVF9TVFJJQ1QuCgpUaGFua3MsCkpvaG4KX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaW9tbXUgbWFpbGluZyBsaXN0CmlvbW11QGxp c3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3VuZGF0aW9uLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2lvbW11