Re: [PATCH 3/4] dma: Let st*_dma() propagate MemTxResult

From: "Cédric Le Goater" <clg@kaod.org>
To: "Philippe Mathieu-Daudé" <philmd@redhat.com>, qemu-devel@nongnu.org
Cc: Daniel Henrique Barboza <danielhb413@gmail.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	David Hildenbrand <david@redhat.com>, Li Qiang <liq3ea@gmail.com>,
	Qiuhao Li <Qiuhao.Li@outlook.com>, Peter Xu <peterx@redhat.com>,
	Greg Kurz <groug@kaod.org>, Alexander Bulekov <alxndr@bu.edu>,
	qemu-ppc@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>,
	David Gibson <david@gibson.dropbear.id.au>
Subject: Re: [PATCH 3/4] dma: Let st*_dma() propagate MemTxResult
Date: Wed, 22 Dec 2021 07:45:54 +0100	[thread overview]
Message-ID: <036975e0-28f9-75c2-aada-a2a0976cf302@kaod.org> (raw)
In-Reply-To: <20211218145111.1540114-4-philmd@redhat.com>

On 12/18/21 15:51, Philippe Mathieu-Daudé wrote:
> dma_memory_write() returns a MemTxResult type. Do not discard
> it, return it to the caller.
> 
> Signed-off-by: Philippe Mathieu-Daudé <philmd@redhat.com>

Reviewed-by: Cédric Le Goater <clg@kaod.org>

Thanks,

C.
     

> ---
>   include/sysemu/dma.h | 20 ++++++++++----------
>   1 file changed, 10 insertions(+), 10 deletions(-)
> 
> diff --git a/include/sysemu/dma.h b/include/sysemu/dma.h
> index b711d390a4f..191cf0b271a 100644
> --- a/include/sysemu/dma.h
> +++ b/include/sysemu/dma.h
> @@ -249,13 +249,13 @@ static inline void dma_memory_unmap(AddressSpace *as,
>           dma_memory_read(as, addr, &val, (_bits) / 8, attrs); \
>           return _end##_bits##_to_cpu(val);                               \
>       }                                                                   \
> -    static inline void st##_sname##_##_end##_dma(AddressSpace *as,      \
> -                                                 dma_addr_t addr,       \
> -                                                 uint##_bits##_t val,   \
> -                                                 MemTxAttrs attrs)      \
> -    {                                                                   \
> -        val = cpu_to_##_end##_bits(val);                                \
> -        dma_memory_write(as, addr, &val, (_bits) / 8, attrs);           \
> +    static inline MemTxResult st##_sname##_##_end##_dma(AddressSpace *as, \
> +                                                        dma_addr_t addr, \
> +                                                        uint##_bits##_t val, \
> +                                                        MemTxAttrs attrs) \
> +    { \
> +        val = cpu_to_##_end##_bits(val); \
> +        return dma_memory_write(as, addr, &val, (_bits) / 8, attrs); \
>       }
>   
>   static inline uint8_t ldub_dma(AddressSpace *as, dma_addr_t addr, MemTxAttrs attrs)
> @@ -266,10 +266,10 @@ static inline uint8_t ldub_dma(AddressSpace *as, dma_addr_t addr, MemTxAttrs att
>       return val;
>   }
>   
> -static inline void stb_dma(AddressSpace *as, dma_addr_t addr,
> -                           uint8_t val, MemTxAttrs attrs)
> +static inline MemTxResult stb_dma(AddressSpace *as, dma_addr_t addr,
> +                                  uint8_t val, MemTxAttrs attrs)
>   {
> -    dma_memory_write(as, addr, &val, 1, attrs);
> +    return dma_memory_write(as, addr, &val, 1, attrs);
>   }
>   
>   DEFINE_LDST_DMA(uw, w, 16, le);
>