From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhang, Qi Z" Subject: Re: [PATCH 2/2] app/testpmd: enable VF untag drop in testpmd Date: Thu, 9 Mar 2017 02:59:07 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153064A3C@SHSMSX103.ccr.corp.intel.com> References: <20170303015924.68986-1-qi.z.zhang@intel.com> <20170303015924.68986-3-qi.z.zhang@intel.com> <8d111f4c-274d-e59f-1e7e-a2550b80d1bb@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: "Yigit, Ferruh" , "Wu, Jingjing" , "Zhang, Helin" Return-path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by dpdk.org (Postfix) with ESMTP id 7A2F5532D for ; Thu, 9 Mar 2017 03:59:13 +0100 (CET) In-Reply-To: <8d111f4c-274d-e59f-1e7e-a2550b80d1bb@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Yigit, Ferruh > Sent: Tuesday, March 7, 2017 7:14 PM > To: Zhang, Qi Z ; Wu, Jingjing ; > Zhang, Helin > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] app/testpmd: enable VF untag drop in > testpmd >=20 > On 3/3/2017 1:59 AM, Qi Zhang wrote: > > Add command line to support untag drop to specific VF in testpmd. > > > > Signed-off-by: Qi Zhang > > --- > > app/test-pmd/cmdline.c | 104 > > +++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 104 insertions(+) > > > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > > 43fc636..4ddc2c9 100644 > > --- a/app/test-pmd/cmdline.c > > +++ b/app/test-pmd/cmdline.c > > @@ -311,6 +311,10 @@ static void cmd_help_long_parsed(void > > *parsed_result, > > > > "set vf vlan antispoof (port_id) (vf_id) (on|off)\n" > > " Set VLAN antispoof for a VF from the PF.\n\n" > > +#ifdef RTE_LIBRTE_I40E_PMD > > + "set vf vlan untagdrop (port_id) (vf_id) (on|off)\n" > > + " Set VLAN untag drop for a VF from the PF.\n\n" > > +#endif >=20 > We should decide how to implement PMD specific APIs in testpmd, and be > consistent about it. >=20 > Currently there are two approaches: >=20 > 1- Wrap PMD specific feature and API with and PMD #ifdef, as done here. >=20 > 2- Enable feature by default, return -ENOTSUP for port_id that does not s= upport > it. Ex: cmd_vf_rxvlan_filter. > > I am for second option. And explicitly not disabling I40E driver does not= mean > you should have those NICs in your runtime environment, so the effect wil= l be > same as always enabling it. > Yes, I notice this problem, during implementation, I saw both patterns exis= t, so I have to choose one of them We'd better align this. Both option ok for me, but a little bit prefer option 1 , since it's not ne= cessary to explore a command if no backend device, that make the hint more = clean. >=20 > And since number of PMD specific APIs are increasing, perhaps we should f= ind a > better approach for testpmd to prevent them corrupting testpmd. Will think about this, also like to know if you or anyone have any good sug= gestion. >=20 > Also it may worth to discuss why number of PMD specific APIs are increasi= ng. >=20 > > > > "set vf vlan tag (port_id) (vf_id) (on|off)\n" > > " Set VLAN tag for a VF from the PF.\n\n" > > @@ -10995,6 +10999,103 @@ cmdline_parse_inst_t > cmd_set_vf_vlan_anti_spoof =3D { > > }, > > }; > > > <...>