From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhang, Qi Z" Subject: Re: [PATCH v2 2/3] eal: clean up interrupt handle Date: Fri, 31 Mar 2017 00:57:50 +0000 Message-ID: <039ED4275CED7440929022BC67E7061153079E58@SHSMSX103.ccr.corp.intel.com> References: <1487801822-30938-1-git-send-email-qi.z.zhang@intel.com> <20170307091928.57990-1-qi.z.zhang@intel.com> <20170307091928.57990-3-qi.z.zhang@intel.com> <4826709.YPY02QJpPJ@xps13> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "dev@dpdk.org" To: Thomas Monjalon Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id DFEB0DE0 for ; Fri, 31 Mar 2017 02:57:53 +0200 (CEST) In-Reply-To: <4826709.YPY02QJpPJ@xps13> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > Sent: Friday, March 31, 2017 12:40 AM > To: Zhang, Qi Z > Cc: dev@dpdk.org > Subject: Re: [PATCH v2 2/3] eal: clean up interrupt handle >=20 > 2017-03-07 04:19, Qi Zhang: > > The patch change the prototype of callback function > > (rte_intr_callback_fn) by removing the unnecessary parameter. > > > > Signed-off-by: Qi Zhang > > --- > > drivers/net/bnxt/bnxt_irq.c | 3 +-- > > drivers/net/e1000/em_ethdev.c | 8 +++----- > > drivers/net/e1000/igb_ethdev.c | 15 ++++++--------- > > drivers/net/enic/enic_main.c | 3 +-- > > drivers/net/fm10k/fm10k_ethdev.c | 12 ++++-------- > > drivers/net/i40e/i40e_ethdev.c | 8 +++----- > > drivers/net/i40e/i40e_ethdev_vf.c | 5 ++--- > > drivers/net/ixgbe/ixgbe_ethdev.c | 14 +++++--------- > > drivers/net/nfp/nfp_net.c | 6 ++---- > > drivers/net/qede/qede_ethdev.c | 4 ++-- > > drivers/net/sfc/sfc_intr.c | 10 ++++++---- > > drivers/net/virtio/virtio_ethdev.c | 5 ++--- > > lib/librte_eal/common/include/rte_interrupts.h | 3 +-- > > lib/librte_eal/linuxapp/eal/eal_alarm.c | 5 ++--- > > lib/librte_eal/linuxapp/eal/eal_interrupts.c | 3 +-- > > 15 files changed, 41 insertions(+), 63 deletions(-) >=20 > bnx2x must be updated. > There is an error with bnx2x_interrupt_handler. Will update Thanks! Qi