From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
Subject: Re: [PATCH v2 3/3] net/ixgbe: enable flex bytes for
	generic flow API
Date: Fri, 2 Jun 2017 02:00:13 +0000
Message-ID: <039ED4275CED7440929022BC67E70611530A71E0@SHSMSX103.ccr.corp.intel.com>
References: <1496259940-15547-1-git-send-email-qi.z.zhang@intel.com>
 <1496259940-15547-4-git-send-email-qi.z.zhang@intel.com>
 <6A0DE07E22DDAD4C9103DF62FEBC09093B5CAFB2@shsmsx102.ccr.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Lu, Wenzhuo" <wenzhuo.lu@intel.com>, "Zhang, Helin"
 <helin.zhang@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by dpdk.org (Postfix) with ESMTP id A498F7CE8
 for <dev@dpdk.org>; Fri,  2 Jun 2017 04:00:17 +0200 (CEST)
In-Reply-To: <6A0DE07E22DDAD4C9103DF62FEBC09093B5CAFB2@shsmsx102.ccr.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Lu, Wenzhuo
> Sent: Friday, June 2, 2017 9:49 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Zhang, Helin
> <helin.zhang@intel.com>
> Cc: dev@dpdk.org
> Subject: RE: [PATCH v2 3/3] net/ixgbe: enable flex bytes for generic flow=
 API
>=20
> Hi Qi,
>=20
>=20
> > -----Original Message-----
> > From: Zhang, Qi Z
> > Sent: Thursday, June 1, 2017 3:46 AM
> > To: Lu, Wenzhuo; Zhang, Helin
> > Cc: dev@dpdk.org; Zhang, Qi Z
> > Subject: [PATCH v2 3/3] net/ixgbe: enable flex bytes for generic flow
> > API
> >
> > Add fdir flex byte support for rte_flow APIs.
> >
> > Signed-off-by: Qi Zhang <qi.z.zhang@intel.com>
> > ---
> >
> > v2:
> > - fix couple checkpatch errors.
> >
> >  drivers/net/ixgbe/ixgbe_ethdev.h |   3 +
> >  drivers/net/ixgbe/ixgbe_fdir.c   |  31 ++++++++-
> >  drivers/net/ixgbe/ixgbe_flow.c   | 137
> > ++++++++++++++++++++++++++++++++++++++-
> >  3 files changed, 167 insertions(+), 4 deletions(-)
>=20
>=20
> > diff --git a/drivers/net/ixgbe/ixgbe_fdir.c
> > b/drivers/net/ixgbe/ixgbe_fdir.c index 7f6c7b5..950f5ba 100644
> > --- a/drivers/net/ixgbe/ixgbe_fdir.c
> > +++ b/drivers/net/ixgbe/ixgbe_fdir.c
> > @@ -302,7 +302,7 @@ fdir_set_input_mask_82599(struct rte_eth_dev
> *dev)
> >  	 * mask VM pool and DIPv6 since there are currently not supported
> >  	 * mask FLEX byte, it will be set in flex_conf
> >  	 */
> > -	uint32_t fdirm =3D IXGBE_FDIRM_POOL | IXGBE_FDIRM_DIPv6 |
> > IXGBE_FDIRM_FLEX;
> > +	uint32_t fdirm =3D IXGBE_FDIRM_POOL | IXGBE_FDIRM_DIPv6;
> >  	uint32_t fdirtcpm;  /* TCP source and destination port masks. */
> >  	uint32_t fdiripv6m; /* IPv6 source and destination masks. */
> >  	volatile uint32_t *reg;
> > @@ -333,6 +333,10 @@ fdir_set_input_mask_82599(struct rte_eth_dev
> *dev)
> >  		return -EINVAL;
> >  	}
> >
> > +	/* flex byte mask */
> > +	if (info->mask.flex_bytes_mask =3D=3D 0)
> > +		fdirm |=3D IXGBE_FDIRM_FLEX;
> > +
> >  	IXGBE_WRITE_REG(hw, IXGBE_FDIRM, fdirm);
> Should the same change be done for x550?
>=20
Currently I didn't see it is necessary.
Because I saw fdir_set_input_mask_x550 will only be used for mac-vlan and t=
unneling filter
where flex byte is not considered in this patch. so keep it disabled
Please correct if I miss something.