From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
Subject: Re: [RFC 1/7] net/af_xdp: new PMD driver
Date: Thu, 1 Mar 2018 01:51:08 +0000
Message-ID: <039ED4275CED7440929022BC67E706115315D3B2@SHSMSX103.ccr.corp.intel.com>
References: <20180227093306.23854-1-qi.z.zhang@intel.com>
 <20180227093306.23854-2-qi.z.zhang@intel.com>
 <20180228154217.4aff5095@xeon-e3>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Karlsson, Magnus"
 <magnus.karlsson@intel.com>, "Topel, Bjorn" <bjorn.topel@intel.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Return-path: <dev-bounces@dpdk.org>
Received: from mga17.intel.com (mga17.intel.com [192.55.52.151])
 by dpdk.org (Postfix) with ESMTP id 807B14C8C
 for <dev@dpdk.org>; Thu,  1 Mar 2018 02:51:13 +0100 (CET)
In-Reply-To: <20180228154217.4aff5095@xeon-e3>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Stephen Hemminger [mailto:stephen@networkplumber.org]
> Sent: Thursday, March 1, 2018 7:42 AM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>
> Cc: dev@dpdk.org; magnus.karlsson@intei.com; Topel, Bjorn
> <bjorn.topel@intel.com>
> Subject: Re: [dpdk-dev] [RFC 1/7] net/af_xdp: new PMD driver
>=20
> On Tue, 27 Feb 2018 17:33:00 +0800
> Qi Zhang <qi.z.zhang@intel.com> wrote:
>=20
> > struct pmd_internals {
> > +	int sfd;
> > +	int if_index;
> > +	char if_name[0x100];
>=20
> why not IFNAMSIZ?
>=20
> > +	struct ether_addr eth_addr;
> > +	struct xdp_queue rx;
> > +	struct xdp_queue tx;
> > +	struct xdp_umem *umem;
> > +	struct rte_mempool *mb_pool;
> > +
> > +	unsigned long rx_pkts;
> > +	unsigned long rx_bytes;
> > +	unsigned long rx_dropped;
> > +
> > +	unsigned long tx_pkts;
> > +	unsigned long err_pkts;
> > +	unsigned long tx_bytes;
>=20
> why not per-queue stats? per-port stats are expensive

multi-queue is not supported in this implementation, but will be considered=
.

Regards
Qi
>=20
> > +	uint16_t port_id;
> > +	uint16_t queue_idx;
> > +	int ring_size;
> > +	struct rte_ring *buf_ring;
> > +};