From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
Subject: Re: [PATCH] net/i40e: remove unnecessary FDIR
	mask	configuration
Date: Mon, 26 Mar 2018 03:15:26 +0000
Message-ID: <039ED4275CED7440929022BC67E7061153174027@SHSMSX103.ccr.corp.intel.com>
References: <1518332974-86392-1-git-send-email-beilei.xing@intel.com>
 <696B43C21188DF4F9C9091AAE4789B824E2D65CC@IRSMSX108.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>
To: "Rybalchenko, Kirill" <kirill.rybalchenko@intel.com>, "Xing, Beilei"
 <beilei.xing@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id E4CCFA48D
 for <dev@dpdk.org>; Mon, 26 Mar 2018 05:15:31 +0200 (CEST)
In-Reply-To: <696B43C21188DF4F9C9091AAE4789B824E2D65CC@IRSMSX108.ger.corp.intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Rybalchenko, Kirill
> Sent: Wednesday, March 14, 2018 11:17 PM
> To: Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.c=
om>
> Cc: dev@dpdk.org
> Subject: RE: [dpdk-dev] [PATCH] net/i40e: remove unnecessary FDIR mask
> configuration
>=20
>=20
>=20
> > -----Original Message-----
> > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Beilei Xing
> > Sent: Sunday 11 February 2018 07:10
> > To: Zhang, Qi Z <qi.z.zhang@intel.com>
> > Cc: dev@dpdk.org
> > Subject: [dpdk-dev] [PATCH] net/i40e: remove unnecessary FDIR mask
> > configuration
> >
> > Remove unnecessary FDIR mask configuration, otherwise flow directory
> > mask will be changed when configuring hash input set.
> >
> > Signed-off-by: Beilei Xing <beilei.xing@intel.com>
> > ---
> >  drivers/net/i40e/rte_pmd_i40e.c | 4 ----
> >  1 file changed, 4 deletions(-)
> >
> > diff --git a/drivers/net/i40e/rte_pmd_i40e.c
> > b/drivers/net/i40e/rte_pmd_i40e.c index 1288c51..b684249 100644
> > --- a/drivers/net/i40e/rte_pmd_i40e.c
> > +++ b/drivers/net/i40e/rte_pmd_i40e.c
> > @@ -3094,10 +3094,6 @@ rte_pmd_i40e_inset_set(uint16_t port, uint8_t
> > pctype,
> >  		return -ENOTSUP;
> >  	}
> >
> > -	/* Clear mask first */
> > -	for (i =3D 0; i < 2; i++)
> > -		i40e_check_write_reg(hw, I40E_GLQF_FD_MSK(i, pctype),
> > 0);
> > -
> >  	inset_reg =3D inset->inset;
> >  	for (i =3D 0; i < 2; i++)
> >  		mask_reg[i] =3D (inset->mask[i].field_idx << 16) |
> > --
> > 2.5.5
>=20
>=20
> Reviewed-by: Kirill Rybalchenko <kirill.rybalchenko@intel.com>
>=20
>=20
Acked-by: Qi Zhang <qi.z.zhang@intel.com>