From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
Subject: Re: [PATCH] net/avf: fix link autoneg value
Date: Wed, 28 Mar 2018 06:42:31 +0000
Message-ID: <039ED4275CED7440929022BC67E70611531754F1@SHSMSX103.ccr.corp.intel.com>
References: <20180309175631.242976-1-ferruh.yigit@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Yigit, Ferruh" <ferruh.yigit@intel.com>,
 "stable@dpdk.org" <stable@dpdk.org>
To: "Yigit, Ferruh" <ferruh.yigit@intel.com>, "Wu, Jingjing"
 <jingjing.wu@intel.com>, "Lu, Wenzhuo" <wenzhuo.lu@intel.com>
Return-path: <dev-bounces@dpdk.org>
In-Reply-To: <20180309175631.242976-1-ferruh.yigit@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Ferruh:

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Ferruh Yigit
> Sent: Saturday, March 10, 2018 1:57 AM
> To: Wu, Jingjing <jingjing.wu@intel.com>; Lu, Wenzhuo
> <wenzhuo.lu@intel.com>
> Cc: dev@dpdk.org; Yigit, Ferruh <ferruh.yigit@intel.com>; stable@dpdk.org
> Subject: [dpdk-dev] [PATCH] net/avf: fix link autoneg value
>=20
> Intention of the logic is:
> If ETH_LINK_SPEED_FIXED is set in dev_conf, set link_autoneg to
> ETH_LINK_FIXED, else set it to ETH_LINK_AUTONEG
>=20
> ETH_LINK_SPEED_FIXED value is 1, and ETH_LINK_FIXED is 0;
>=20
> Current logic is broken, fix it according above values.
>=20
> Fixes: 48de41ca11f0 ("net/avf: enable link status update")
> Cc: jingjing.wu@intel.com
> Cc: stable@dpdk.org
>=20
> Signed-off-by: Ferruh Yigit <ferruh.yigit@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

BTW, I saw the same issue on i40evf, will you also fix that?

Thanks
Qi