All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Xu, Rosen" <rosen.xu@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Xing, Beilei" <beilei.xing@intel.com>,
	"Zhang, Helin" <helin.zhang@intel.com>,
	"Wu, Jingjing" <jingjing.wu@intel.com>
Subject: Re: [PATCH v4] drivers/net/i40e: fix missing promiscuous disable at device disable
Date: Wed, 18 Apr 2018 12:01:51 +0000	[thread overview]
Message-ID: <039ED4275CED7440929022BC67E706115319FBAB@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <1524039101-158658-1-git-send-email-rosen.xu@intel.com>



> -----Original Message-----
> From: Xu, Rosen
> Sent: Wednesday, April 18, 2018 4:12 PM
> To: dev@dpdk.org
> Cc: Xing, Beilei <beilei.xing@intel.com>; Zhang, Helin
> <helin.zhang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>
> Subject: [PATCH v4] drivers/net/i40e: fix missing promiscuous disable at
> device disable
> 
> v4 updates:
> ===========
>  - Add some comments for this patch
> 
> v3 updates:
> ===========
>  - Move modification from device close to device disable
>  - i40evf_reset_vf() will cause kernel driver enable all vlan promiscuous,
>    so unicast/multicast promiscuous disable should set before reset.
> 
> v2 updates:
> ===========
>  - Add more comments
> 
> In scenario of Kernel Driver runs on PF and PMD runs on VF, PMD exit
> doesn't disable promiscuous mode, this will cause vlan filter set by Kernel
> Driver will not take effect.
> 
> This patch will fix it, add promiscuous disable at device disable.
> 
> Signed-off-by: Rosen Xu <rosen.xu@intel.com>

Acked-by: Qi Zhang <qi.z.zhang@intel.com>

Change log need be removed when apply

  reply	other threads:[~2018-04-18 12:01 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-15  5:14 [PATCH] Add i40e Promiscuous disable in i40evf_dev_stop Rosen Xu
2018-04-17  3:02 ` [PATCH v3] drivers/net/i40e: fix missing promiscuous disable at device disable Rosen Xu
2018-04-17 13:31   ` Zhang, Qi Z
2018-04-18  8:11 ` [PATCH v4] " Rosen Xu
2018-04-18 12:01   ` Zhang, Qi Z [this message]
2018-04-28 11:38 ` [PATCH v5] net/i40e: fix disabling promiscuous mode Rosen Xu
2018-05-08  1:47   ` Zhang, Helin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=039ED4275CED7440929022BC67E706115319FBAB@SHSMSX103.ccr.corp.intel.com \
    --to=qi.z.zhang@intel.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=helin.zhang@intel.com \
    --cc=jingjing.wu@intel.com \
    --cc=rosen.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.