From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Zhang, Qi Z" Subject: Re: [PATCH] ethdev: fix checking Rx/Tx queue status Date: Fri, 11 May 2018 12:34:06 +0000 Message-ID: <039ED4275CED7440929022BC67E70611531B14E8@SHSMSX103.ccr.corp.intel.com> References: <20180511082228.158405-1-yanglong.wu@intel.com> <2601191342CEEE43887BDE71AB977258AEDC5D28@irsmsx105.ger.corp.intel.com> <039ED4275CED7440929022BC67E70611531B135E@SHSMSX103.ccr.corp.intel.com> <2601191342CEEE43887BDE71AB977258AEDC5DA4@irsmsx105.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Cc: "Lu, Wenzhuo" , "Wu, Yanglong" To: "Ananyev, Konstantin" , "Wu, Yanglong" , "dev@dpdk.org" Return-path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 2C27A1C333 for ; Fri, 11 May 2018 14:34:11 +0200 (CEST) In-Reply-To: <2601191342CEEE43887BDE71AB977258AEDC5DA4@irsmsx105.ger.corp.intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Ananyev, Konstantin > Sent: Friday, May 11, 2018 5:51 PM > To: Zhang, Qi Z ; Wu, Yanglong > ; dev@dpdk.org > Cc: Lu, Wenzhuo ; Wu, Yanglong > > Subject: RE: [dpdk-dev] [PATCH] ethdev: fix checking Rx/Tx queue status >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Qi Z > > Sent: Friday, May 11, 2018 10:24 AM > > To: Ananyev, Konstantin ; Wu, Yanglong > > ; dev@dpdk.org > > Cc: Lu, Wenzhuo ; Wu, Yanglong > > > > Subject: RE: [dpdk-dev] [PATCH] ethdev: fix checking Rx/Tx queue > > status > > > > > > > > > -----Original Message----- > > > From: Ananyev, Konstantin > > > Sent: Friday, May 11, 2018 4:39 PM > > > To: Wu, Yanglong ; dev@dpdk.org > > > Cc: Zhang, Qi Z ; Lu, Wenzhuo > > > ; Wu, Yanglong > > > Subject: RE: [dpdk-dev] [PATCH] ethdev: fix checking Rx/Tx queue > > > status > > > > > > > > > > > > > -----Original Message----- > > > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Yanglong Wu > > > > Sent: Friday, May 11, 2018 9:22 AM > > > > To: dev@dpdk.org > > > > Cc: Zhang, Qi Z ; Lu, Wenzhuo > > > > ; Wu, Yanglong > > > > Subject: [dpdk-dev] [PATCH] ethdev: fix checking Rx/Tx queue > > > > status > > > > > > > > Relax the check for queue setup, since some device may not update > > > > queue states during dev_stop. > > > > > > > > Fixes: cac923cfea47 ("ethdev: support runtime queue setup") > > > > Signed-off-by: Yanglong Wu > > > > --- > > > > lib/librte_ethdev/rte_ethdev.c | 10 ++++++---- > > > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/lib/librte_ethdev/rte_ethdev.c > > > > b/lib/librte_ethdev/rte_ethdev.c index a357ee09f..34379642a 100644 > > > > --- a/lib/librte_ethdev/rte_ethdev.c > > > > +++ b/lib/librte_ethdev/rte_ethdev.c > > > > @@ -1479,8 +1479,9 @@ rte_eth_rx_queue_setup(uint16_t port_id, > > > uint16_t rx_queue_id, > > > > RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP)) > > > > return -EBUSY; > > > > > > > > - if (dev->data->rx_queue_state[rx_queue_id] !=3D > > > > - RTE_ETH_QUEUE_STATE_STOPPED) > > > > + if (dev->data->dev_started && > > > > + (dev->data->rx_queue_state[rx_queue_id] !=3D > > > > + RTE_ETH_QUEUE_STATE_STOPPED)) > > > > return -EBUSY; > > > > > > > > rxq =3D dev->data->rx_queues; > > > > @@ -1611,8 +1612,9 @@ rte_eth_tx_queue_setup(uint16_t port_id, > > > uint16_t tx_queue_id, > > > > RTE_ETH_DEV_CAPA_RUNTIME_TX_QUEUE_SETUP)) > > > > return -EBUSY; > > > > > > > > - if (dev->data->tx_queue_state[tx_queue_id] !=3D > > > > - RTE_ETH_QUEUE_STATE_STOPPED) > > > > + if (dev->data->dev_started && > > > > + (dev->data->tx_queue_state[tx_queue_id] !=3D > > > > + RTE_ETH_QUEUE_STATE_STOPPED)) > > > > return -EBUSY; > > > > > > > > txq =3D dev->data->tx_queues; > > > > -- > > > > > > That would break runtime queue setup. > > > > Em... would you explain more, I can't figure out why this break runtime > queue setup so far. >=20 > Ah yes, it was me not reading code properly. > So yep - you right it wouldn't break things. >=20 > > > > > Why not fix offending PMDs instead? > > > > Ixgbe, i40e have this issue, not sure what about others. > > probably we should fix at rte_eth_dev_stop to save all PMD? >=20 > Probably yes, that's a good thing to do in long term anyway. I'm thinking if it's better to move all queue state change into ethdev laye= r. So there could be a patch to update queue states properly at dev_start/dev_= stop/queue_start/queue_stop and maintainer help them self to cleanup PMD, a= nd I think our proposed fix should be part of this. But for now, can we just keep current simple fix? Regards Qi >=20 > > > > > > > > > 2.11.0 >=20 > Acked-by: Konstantin Ananyev