From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
Subject: Re: [PATCH v2] net/ixgbe: update PMD Tx offload mask
Date: Thu, 25 Oct 2018 15:23:43 +0000
Message-ID: <039ED4275CED7440929022BC67E70611532DB769@SHSMSX103.ccr.corp.intel.com>
References: <20181025145840.38440-1-zhirun.yan@intel.com>
 <20181025074528.GC55104@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Xing, Beilei" <beilei.xing@intel.com>
To: "Ye, Xiaolong" <xiaolong.ye@intel.com>, "Yan, Zhirun"
 <zhirun.yan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id 3709369D4
 for <dev@dpdk.org>; Thu, 25 Oct 2018 17:23:50 +0200 (CEST)
In-Reply-To: <20181025074528.GC55104@intel.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Ye, Xiaolong
> Sent: Thursday, October 25, 2018 2:45 AM
> To: Yan, Zhirun <zhirun.yan@intel.com>
> Cc: dev@dpdk.org; Zhang, Qi Z <qi.z.zhang@intel.com>; Xing, Beilei
> <beilei.xing@intel.com>
> Subject: Re: [dpdk-dev] [PATCH v2] net/ixgbe: update PMD Tx offload mask
>=20
> On 10/25, Zhirun Yan wrote:
> >Tx offload mask is updated in following commit: commit 1037ed842c37
> >("mbuf: fix Tx offload mask"). Currently, the new added offload flags
> >are not supported in PMD and application will fail to call PMD transmit
> >prepare function.
> >
> >This patch updates IXGBE_TX_OFFFLOAD_MASK.
> >
> >Fixes: 1037ed842c37 ("mbuf: fix Tx offload mask")
> >
> >Signed-off-by: Zhirun Yan <zhirun.yan@intel.com>
> >---
> > drivers/net/ixgbe/ixgbe_rxtx.c | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> >diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c
> >b/drivers/net/ixgbe/ixgbe_rxtx.c index e6f61c900..e462a03d8 100644
> >--- a/drivers/net/ixgbe/ixgbe_rxtx.c
> >+++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> >@@ -58,6 +58,10 @@
> > #endif
> > /* Bit Mask to indicate what bits required for building TX context */
> > #define IXGBE_TX_OFFLOAD_MASK (			 \
> >+		PKT_TX_OUTER_IPV6 |		 \
> >+		PKT_TX_OUTER_IPV4 |		 \
> >+		PKT_TX_IPV6 |			 \
> >+		PKT_TX_IPV4 |			 \
> > 		PKT_TX_VLAN_PKT |		 \
> > 		PKT_TX_IP_CKSUM |		 \
> > 		PKT_TX_L4_MASK |		 \
>=20
> Reviewed-by: Ye Xiaolong <xiaolong.ye@intel.com>

Applied to dpdk-next-net-intel.

Thanks
Qi

>=20
> Thanks,
> Xiaolong