From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
Subject: Re: [PATCH] net/ixgbe: Restore vlan filter/extend for
 ixgbvef
Date: Thu, 7 Mar 2019 13:11:20 +0000
Message-ID: <039ED4275CED7440929022BC67E70611533490C5@SHSMSX103.ccr.corp.intel.com>
References: <20190306152355.1697-1-dharton@cisco.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
To: David Harton <dharton@cisco.com>, "dev@dpdk.org" <dev@dpdk.org>, "Lu,
 Wenzhuo" <wenzhuo.lu@intel.com>, "Ananyev, Konstantin"
 <konstantin.ananyev@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga12.intel.com (mga12.intel.com [192.55.52.136])
 by dpdk.org (Postfix) with ESMTP id 205EB532C
 for <dev@dpdk.org>; Thu,  7 Mar 2019 14:11:24 +0100 (CET)
In-Reply-To: <20190306152355.1697-1-dharton@cisco.com>
Content-Language: en-US
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi

> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of David Harton
> Sent: Wednesday, March 6, 2019 11:24 PM
> To: dev@dpdk.org; Lu, Wenzhuo <wenzhuo.lu@intel.com>; Ananyev, Konstantin
> <konstantin.ananyev@intel.com>
> Cc: David Harton <dharton@cisco.com>
> Subject: [dpdk-dev] [PATCH] net/ixgbe: Restore vlan filter/extend for ixg=
bvef
>=20
> ixgevf vlan strip and extend capabilities were removed when migrating to =
the bit
> flags implementation.
>=20
> Restoring the capbility to enable these offloads at configuration time.
>=20
> Fixes: ec3b1124d14d (\"net/ixgbe: convert to new Rx offloads API\")
> Signed-off-by: David Harton <dharton@cisco.com>
> ---
>  drivers/net/ixgbe/ixgbe_rxtx.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>=20
> diff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxt=
x.c
> index e92a70fb3..95c32257c 100644
> --- a/drivers/net/ixgbe/ixgbe_rxtx.c
> +++ b/drivers/net/ixgbe/ixgbe_rxtx.c
> @@ -2853,15 +2853,13 @@ ixgbe_get_rx_port_offloads(struct rte_eth_dev
> *dev)
>  		   DEV_RX_OFFLOAD_TCP_CKSUM   |
>  		   DEV_RX_OFFLOAD_KEEP_CRC    |
>  		   DEV_RX_OFFLOAD_JUMBO_FRAME |
> +		   DEV_RX_OFFLOAD_VLAN_FILTER |
> +		   DEV_RX_OFFLOAD_VLAN_EXTEND |
>  		   DEV_RX_OFFLOAD_SCATTER;
>=20
>  	if (hw->mac.type =3D=3D ixgbe_mac_82598EB)
>  		offloads |=3D DEV_RX_OFFLOAD_VLAN_STRIP;
>=20
> -	if (ixgbe_is_vf(dev) =3D=3D 0)

Patchwork shows "build patch error" for ci/Performance-Testing.
Seems this is the only place ixgbe_is_vf is used, so it can also be removed

> -		offloads |=3D (DEV_RX_OFFLOAD_VLAN_FILTER |
> -			     DEV_RX_OFFLOAD_VLAN_EXTEND);
> -
>  	/*
>  	 * RSC is only supported by 82599 and x540 PF devices in a non-SR-IOV
>  	 * mode.
> --
> 2.19.1