From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Su, Simei" <simei.su@intel.com>, "Ye, Xiaolong" <xiaolong.ye@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "Cao, Yahui" <yahui.cao@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/ice: support mark only action for FDIR
Date: Tue, 14 Apr 2020 12:50:59 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E70611547F9005@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <BL0PR11MB33807E64A3F1E02BFA67D78A9CDA0@BL0PR11MB3380.namprd11.prod.outlook.com>
> -----Original Message-----
> From: Su, Simei <simei.su@intel.com>
> Sent: Tuesday, April 14, 2020 5:12 PM
> To: Zhang, Qi Z <qi.z.zhang@intel.com>; Ye, Xiaolong <xiaolong.ye@intel.com>
> Cc: dev@dpdk.org; Cao, Yahui <yahui.cao@intel.com>; stable@dpdk.org
> Subject: RE: [PATCH] net/ice: support mark only action for FDIR
>
> Hi, Qi
>
> > -----Original Message-----
> > From: Zhang, Qi Z <qi.z.zhang@intel.com>
> > Sent: Tuesday, April 14, 2020 3:49 PM
> > To: Su, Simei <simei.su@intel.com>; Ye, Xiaolong
> > <xiaolong.ye@intel.com>
> > Cc: dev@dpdk.org; Cao, Yahui <yahui.cao@intel.com>; stable@dpdk.org
> > Subject: RE: [PATCH] net/ice: support mark only action for FDIR
> >
> >
> >
> > > -----Original Message-----
> > > From: Su, Simei <simei.su@intel.com>
> > > Sent: Thursday, April 2, 2020 2:56 PM
> > > To: Zhang, Qi Z <qi.z.zhang@intel.com>; Ye, Xiaolong
> > > <xiaolong.ye@intel.com>
> > > Cc: dev@dpdk.org; Cao, Yahui <yahui.cao@intel.com>; Su, Simei
> > > <simei.su@intel.com>; stable@dpdk.org
> > > Subject: [PATCH] net/ice: support mark only action for FDIR
> > >
> > > This patch fixes issue that doesn't support mark only case.
> > > Mark only action is equal to mark + passthru action.
> > >
> > > Fixes: f5cafa961fae ("net/ice: add flow director create and
> > > destroy")
> > > Cc: stable@dpdk.org
> > >
> > > Signed-off-by: Simei Su <simei.su@intel.com>
> > > ---
> > > drivers/net/ice/ice_fdir_filter.c | 13 ++++++++++++-
> > > 1 file changed, 12 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/net/ice/ice_fdir_filter.c
> > > b/drivers/net/ice/ice_fdir_filter.c
> > > index a082a13..8acdb1a 100644
> > > --- a/drivers/net/ice/ice_fdir_filter.c
> > > +++ b/drivers/net/ice/ice_fdir_filter.c
> > > @@ -1469,6 +1469,10 @@
> > > uint32_t counter_num = 0;
> > > int ret;
> > >
> > > +/* set default action to PASSTHRU mode, in the case of MARK only.
> > > +*/
> > > +filter->input.dest_ctl =
> > > +ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER;
> >
> > Should we also consider the case "Count only", I will suggest move
> > above code to after all the action has been iterated and all criteria
> > check has passed Then only set destination to PASSTHROUGH for no
> destination case.
>
> I don't know whether the case "Count only" should fail or means passthru +
> count.
It is the case that user may just want to count a number of the packets that match a specific pattern and don't care which destination it reached.,
Though I don't know if this could be a real usage, but I didn't think its necessary to reject this configure, and allow "count only" keep it consistent with "mark only" make the code easy to understand.
> In my code, I return error when in the case "count only":
> if (dest_num + mark_num == 0) {
> rte_flow_error_set(error, EINVAL,
> RTE_FLOW_ERROR_TYPE_ACTION, actions,
> "Emtpy action");
> return -rte_errno;
> }
>
> So I want to confirm how to define "count only" case here, your suggestion
> code seems "count only" means "count + passthru" ?
>
> Thanks
> Simei
>
> >
> > If (dest_num == 0)
> > filter->input.dest_ctl =
> > ICE_FLTR_PRGM_DESC_DEST_DIRECT_PKT_OTHER;
> >
> > > +
> > > for (; actions->type != RTE_FLOW_ACTION_TYPE_END; actions++) {
> > > switch (actions->type) { case RTE_FLOW_ACTION_TYPE_VOID:
> > > @@ -1533,7 +1537,7 @@
> > > }
> > > }
> > >
> > > -if (dest_num == 0 || dest_num >= 2) {
> > > +if (dest_num >= 2) {
> > > rte_flow_error_set(error, EINVAL,
> > > RTE_FLOW_ERROR_TYPE_ACTION, actions,
> > > "Unsupported action combination"); @@ -1554,6 +1558,13
> > @@
> > > return -rte_errno;
> > > }
> > >
> > > +if (dest_num + mark_num == 0) {
> > > +rte_flow_error_set(error, EINVAL,
> > > +RTE_FLOW_ERROR_TYPE_ACTION, actions, "Emtpy action"); return
> > > +-rte_errno; }
> > > +
> > > return 0;
> > > }
> > >
> > > --
> > > 1.8.3.1
> >
>
next prev parent reply other threads:[~2020-04-14 12:51 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 6:55 [dpdk-dev] [PATCH] net/ice: support mark only action for FDIR Simei Su
2020-04-14 7:49 ` Zhang, Qi Z
2020-04-14 9:12 ` Su, Simei
2020-04-14 12:50 ` Zhang, Qi Z [this message]
2020-04-14 14:30 ` Su, Simei
2020-04-14 15:11 ` [dpdk-dev] [PATCH v2] " Simei Su
2020-04-30 9:19 ` Zhang, Qi Z
2020-05-06 5:27 ` Ye Xiaolong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E70611547F9005@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=simei.su@intel.com \
--cc=stable@dpdk.org \
--cc=xiaolong.ye@intel.com \
--cc=yahui.cao@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.