From: "Zhang, Qi Z" <qi.z.zhang@intel.com>
To: "Wang, Xiao W" <xiao.w.wang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Yang, Qiming" <qiming.yang@intel.com>,
"Yao, Lei A" <lei.a.yao@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/ice: fix default RSS key configuration
Date: Thu, 23 Jul 2020 10:25:35 +0000 [thread overview]
Message-ID: <039ED4275CED7440929022BC67E7061154864D3C@SHSMSX103.ccr.corp.intel.com> (raw)
In-Reply-To: <039ED4275CED7440929022BC67E7061154863E56@SHSMSX103.ccr.corp.intel.com>
> -----Original Message-----
> From: Zhang, Qi Z
> Sent: Wednesday, July 22, 2020 1:26 PM
> To: Wang, Xiao W <xiao.w.wang@intel.com>
> Cc: dev@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Yao, Lei A
> <lei.a.yao@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; stable@dpdk.org
> Subject: RE: [PATCH] net/ice: fix default RSS key configuration
>
>
>
> > -----Original Message-----
> > From: Wang, Xiao W <xiao.w.wang@intel.com>
> > Sent: Tuesday, July 21, 2020 5:03 PM
> > To: Zhang, Qi Z <qi.z.zhang@intel.com>
> > Cc: dev@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Yao, Lei A
> > <lei.a.yao@intel.com>; Wu, Jingjing <jingjing.wu@intel.com>; Wang,
> > Xiao W <xiao.w.wang@intel.com>; stable@dpdk.org
> > Subject: [PATCH] net/ice: fix default RSS key configuration
> >
> > There's chance that rte_rand() doesn't provision suitable values for
> > RSS hash, an extreme example could be a key with a lot of 0s in it.
> >
> > This patch adds a default RSS key which has been used in ixgbe driver
> > and fm10k driver.
> >
> > Fixes: 50370662b727 ("net/ice: support device and queue ops")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Xiao Wang <xiao.w.wang@intel.com>
>
> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
>
> Applied to dpdk-next-net-intel.
After some internal discussion, we decide to keep the random key as default, and user can use rte_eth_dev_rss_hash_update to update a new key.
So the patch has been removed from dpdk-next-net-intel.
>
> Thanks
> Qi
prev parent reply other threads:[~2020-07-23 10:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-21 9:02 [dpdk-dev] [PATCH] net/ice: fix default RSS key configuration Xiao Wang
2020-07-22 5:25 ` Zhang, Qi Z
2020-07-23 10:25 ` Zhang, Qi Z [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=039ED4275CED7440929022BC67E7061154864D3C@SHSMSX103.ccr.corp.intel.com \
--to=qi.z.zhang@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=lei.a.yao@intel.com \
--cc=qiming.yang@intel.com \
--cc=stable@dpdk.org \
--cc=xiao.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.