All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Niels Dossche <dossche.niels@gmail.com>
Cc: netdev@vger.kernel.org, Johan Hedberg <johan.hedberg@gmail.com>,
	Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Subject: Re: [PATCH] Bluetooth: call hci_le_conn_failed with hdev lock in hci_le_conn_failed
Date: Wed, 16 Mar 2022 16:32:14 +0100	[thread overview]
Message-ID: <03B539EF-D2F4-4345-A6F9-F2F77CAA41C5@holtmann.org> (raw)
In-Reply-To: <20220316152027.9988-1-dossche.niels@gmail.com>

Hi Niels,

> hci_le_conn_failed function's documentation says that the caller must
> hold hdev->lock. The only callsite that does not hold that lock is
> hci_le_conn_failed. The other 3 callsites hold the hdev->lock very
> locally. The solution is to hold the lock during the call to
> hci_le_conn_failed.
> 
> Fixes: 3c857757ef6e ("Bluetooth: Add directed advertising support through connect()")
> Signed-off-by: Niels Dossche <dossche.niels@gmail.com>
> ---
> net/bluetooth/hci_conn.c | 2 ++
> 1 file changed, 2 insertions(+)

please send net/bluetooth/ to linux-bluetooth mailing list.

Regards

Marcel


  reply	other threads:[~2022-03-16 15:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-16 15:20 [PATCH] Bluetooth: call hci_le_conn_failed with hdev lock in hci_le_conn_failed Niels Dossche
2022-03-16 15:32 ` Marcel Holtmann [this message]
2022-03-16 15:33   ` Niels Dossche
2022-03-16 15:33 Niels Dossche
2022-03-16 15:38 ` Marcel Holtmann
2022-03-16 15:40 ` patchwork-bot+bluetooth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=03B539EF-D2F4-4345-A6F9-F2F77CAA41C5@holtmann.org \
    --to=marcel@holtmann.org \
    --cc=dossche.niels@gmail.com \
    --cc=johan.hedberg@gmail.com \
    --cc=luiz.dentz@gmail.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.