From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: Re: [PATCH v2 1/2] treewide: remove unused address argument from pte_alloc functions Date: Fri, 12 Oct 2018 20:51:45 +0200 Message-ID: <03b524f3-5f3a-baa0-2254-9c588103d2d6@users.sourceforge.net> References: <20181012013756.11285-1-joel@joelfernandes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Cc: linux-mips@linux-mips.org, Rich Felker , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Peter Zijlstra , Catalin Marinas , Dave Hansen , Will Deacon , Michal Hocko , linux-mm@kvack.org, Lokesh Gidra , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, kvmarm@lists.cs.columbia.edu, Jonas Bonn , linux-s390@vger.kernel.org, Daniel Colascione , Yoshinori Sato , Max Filippov , linux-hexagon@vger.kernel.org, Helge Deller , "maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" , Hugh Dickins , "James E. J. Bottomley" , kasan-dev@googlegroups.com, Ingo To: Joel Fernandes , kernel-janitors@vger.kernel.org Return-path: In-Reply-To: <20181012013756.11285-1-joel@joelfernandes.org> List-Id: Linux on Synopsys ARC Processors List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-snps-arc-bounces+gla-linux-snps-arc=m.gmane.org@lists.infradead.org PiBUaGUgY2hhbmdlcyB3ZXJlIG9idGFpbmVkIGJ5IGFwcGx5aW5nIHRoZSBmb2xsb3dpbmcgQ29j Y2luZWxsZSBzY3JpcHQuCgpBIGJpdCBvZiBjbGFyaWZpY2F0aW9uIGhhcHBlbmVkIGZvciBpdHMg aW1wbGVtZW50YXRpb24gZGV0YWlscy4KaHR0cHM6Ly9zeXN0ZW1lLmxpcDYuZnIvcGlwZXJtYWls L2NvY2NpLzIwMTgtT2N0b2Jlci8wMDUzNzQuaHRtbAoKSSBoYXZlIHRha2VuIGFsc28gYW5vdGhl ciBsb29rIGF0IHRoZSBmb2xsb3dpbmcgU21QTCBjb2RlLgoKCj4gaWRlbnRpZmllciBmbiA9fgo+ ICJeKF9fcHRlX2FsbG9jfHB0ZV9hbGxvY19vbmV8cHRlX2FsbG9jfF9fcHRlX2FsbG9jX2tlcm5l bHxwdGVfYWxsb2Nfb25lX2tlcm5lbCkkIjsKCkkgc3VnZ2VzdCB0byBhZGp1c3QgdGhlIHJlZ3Vs YXIgZXhwcmVzc2lvbiBmb3IgdGhpcyBjb25zdHJhaW50CmFuZCBpbiBzdWJzZXF1ZW50IFNtUEwg cnVsZXMuCgoiXig/OnB0ZV9hbGxvYyg/Ol9vbmUoPzpfa2VybmVsKT8pP3xfX3B0ZV9hbGxvYyg/ Ol9rZXJuZWwpPykkIjsKCgo+ICgKPiAtIFQzIGZuKFQxIEUxLCBUMiBFMik7Cj4gKyBUMyBmbihU MSBFMSk7Cj4gfAo+IC0gVDMgZm4oVDEgRTEsIFQyIEUyLCBUNCBFNCk7Cj4gKyBUMyBmbihUMSBF MSwgVDIgRTIpOwo+ICkKCkkgcHJvcG9zZSB0byB0YWtlIGFuIG90aGVyIFNtUEwgZGlzanVuY3Rp b24gaW50byBhY2NvdW50IGhlcmUuCgogVDMgZm4oVDEgRTEsCigKLSAgICAgIFQyIEUyCnwgICAg ICBUMiBFMiwKLSAgICAgIFQ0IEU0CikgICAgICApOwoKCj4gKAo+IC0gI2RlZmluZSBmbihhLCBi LCBjKUBwIGUKPiArICNkZWZpbmUgZm4oYSwgYikgZQo+IHwKPiAtICNkZWZpbmUgZm4oYSwgYilA cCBlCj4gKyAjZGVmaW5lIGZuKGEpIGUKPiApCgpIb3cgZG8geW91IHRoaW5rIGFib3V0IHRvIG9t aXQgdGhlIG1ldGF2YXJpYWJsZSDigJxwb3NpdGlvbiBw4oCdIGhlcmU/CgpSZWdhcmRzLApNYXJr dXMKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4 LXNucHMtYXJjIG1haWxpbmcgbGlzdApsaW51eC1zbnBzLWFyY0BsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtc25wcy1h cmM= From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Subject: Re: [PATCH v2 1/2] treewide: remove unused address argument from pte_alloc functions Date: Fri, 12 Oct 2018 20:51:45 +0200 Message-ID: <03b524f3-5f3a-baa0-2254-9c588103d2d6@users.sourceforge.net> References: <20181012013756.11285-1-joel@joelfernandes.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20181012013756.11285-1-joel@joelfernandes.org> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+gla-linux-snps-arc=m.gmane.org@lists.infradead.org List-Archive: List-Post: To: Joel Fernandes , kernel-janitors@vger.kernel.org Cc: linux-mips@linux-mips.org, Rich Felker , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Peter Zijlstra , Catalin Marinas , Dave Hansen , Will Deacon , Michal Hocko , linux-mm@kvack.org, Lokesh Gidra , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, kvmarm@lists.cs.columbia.edu, Jonas Bonn , linux-s390@vger.kernel.org, Daniel Colascione , Yoshinori Sato , Max Filippov , linux-hexagon@vger.kernel.org, Helge Deller , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Hugh Dickins , "James E. J. Bottomley" , kasan-dev@googlegroups.com, Ingo List-ID: PiBUaGUgY2hhbmdlcyB3ZXJlIG9idGFpbmVkIGJ5IGFwcGx5aW5nIHRoZSBmb2xsb3dpbmcgQ29j Y2luZWxsZSBzY3JpcHQuCgpBIGJpdCBvZiBjbGFyaWZpY2F0aW9uIGhhcHBlbmVkIGZvciBpdHMg aW1wbGVtZW50YXRpb24gZGV0YWlscy4KaHR0cHM6Ly9zeXN0ZW1lLmxpcDYuZnIvcGlwZXJtYWls L2NvY2NpLzIwMTgtT2N0b2Jlci8wMDUzNzQuaHRtbAoKSSBoYXZlIHRha2VuIGFsc28gYW5vdGhl ciBsb29rIGF0IHRoZSBmb2xsb3dpbmcgU21QTCBjb2RlLgoKCj4gaWRlbnRpZmllciBmbiA9fgo+ ICJeKF9fcHRlX2FsbG9jfHB0ZV9hbGxvY19vbmV8cHRlX2FsbG9jfF9fcHRlX2FsbG9jX2tlcm5l bHxwdGVfYWxsb2Nfb25lX2tlcm5lbCkkIjsKCkkgc3VnZ2VzdCB0byBhZGp1c3QgdGhlIHJlZ3Vs YXIgZXhwcmVzc2lvbiBmb3IgdGhpcyBjb25zdHJhaW50CmFuZCBpbiBzdWJzZXF1ZW50IFNtUEwg cnVsZXMuCgoiXig/OnB0ZV9hbGxvYyg/Ol9vbmUoPzpfa2VybmVsKT8pP3xfX3B0ZV9hbGxvYyg/ Ol9rZXJuZWwpPykkIjsKCgo+ICgKPiAtIFQzIGZuKFQxIEUxLCBUMiBFMik7Cj4gKyBUMyBmbihU MSBFMSk7Cj4gfAo+IC0gVDMgZm4oVDEgRTEsIFQyIEUyLCBUNCBFNCk7Cj4gKyBUMyBmbihUMSBF MSwgVDIgRTIpOwo+ICkKCkkgcHJvcG9zZSB0byB0YWtlIGFuIG90aGVyIFNtUEwgZGlzanVuY3Rp b24gaW50byBhY2NvdW50IGhlcmUuCgogVDMgZm4oVDEgRTEsCigKLSAgICAgIFQyIEUyCnwgICAg ICBUMiBFMiwKLSAgICAgIFQ0IEU0CikgICAgICApOwoKCj4gKAo+IC0gI2RlZmluZSBmbihhLCBi LCBjKUBwIGUKPiArICNkZWZpbmUgZm4oYSwgYikgZQo+IHwKPiAtICNkZWZpbmUgZm4oYSwgYilA cCBlCj4gKyAjZGVmaW5lIGZuKGEpIGUKPiApCgpIb3cgZG8geW91IHRoaW5rIGFib3V0IHRvIG9t aXQgdGhlIG1ldGF2YXJpYWJsZSDigJxwb3NpdGlvbiBw4oCdIGhlcmU/CgpSZWdhcmRzLApNYXJr dXMKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4 LXNucHMtYXJjIG1haWxpbmcgbGlzdApsaW51eC1zbnBzLWFyY0BsaXN0cy5pbmZyYWRlYWQub3Jn Cmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtc25wcy1h cmM= From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Fri, 12 Oct 2018 20:54:42 +0200 (CEST) Received: from mout.web.de ([217.72.192.78]:53335 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by eddie.linux-mips.org with ESMTP id S23993941AbeJLSyew9hJj (ORCPT ); Fri, 12 Oct 2018 20:54:34 +0200 Received: from [192.168.1.2] ([77.182.238.221]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M6V1T-1fRTIY0mGx-00yNhT; Fri, 12 Oct 2018 20:52:01 +0200 Received: from [192.168.1.2] ([77.182.238.221]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M6V1T-1fRTIY0mGx-00yNhT; Fri, 12 Oct 2018 20:52:01 +0200 Subject: Re: [PATCH v2 1/2] treewide: remove unused address argument from pte_alloc functions To: Joel Fernandes , kernel-janitors@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, Michal Hocko , Julia Lawall , Andrey Ryabinin , Andy Lutomirski , Borislav Petkov , Catalin Marinas , Chris Zankel , Daniel Colascione , Dave Hansen , "David S. Miller" , Fenghua Yu , Geert Uytterhoeven , Guan Xuetao , Helge Deller , Hugh Dickins , Ingo Molnar , "James E. J. Bottomley" , Jeff Dike , Jonas Bonn , kasan-dev@googlegroups.com, kvmarm@lists.cs.columbia.edu, Ley Foon Tan , linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@linux-mips.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, pantin@google.com, Lokesh Gidra , Max Filippov , Minchan Kim , nios2-dev@lists.rocketboards.org, openrisc@lists.librecores.org, Peter Zijlstra , Richard Weinberger , Rich Felker , Sam Creasey , sparclinux@vger.kernel.org, Stafford Horne , Stefan Kristiansson , Thomas Gleixner , Tony Luck , Will Deacon , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Yoshinori Sato , "Kirill A. Shutemov" , Andrew Morton References: <20181012013756.11285-1-joel@joelfernandes.org> From: SF Markus Elfring Message-ID: <03b524f3-5f3a-baa0-2254-9c588103d2d6@users.sourceforge.net> Date: Fri, 12 Oct 2018 20:51:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181012013756.11285-1-joel@joelfernandes.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:kL1jfGghCfX5IqF0iVRDf8mQoouSapQgO45dI9woF05xgJDfw/d AA5sy1osx5PoQoz8e05NX77GNXJPHw9DPR0si3tMAft3cP3Og/UHQyAFEv44VXROloUsniB Y8tHxhnCqGSXk3sDOvyIeh0eyIwAL0z+iO5ZuRU8MJFacaGuv/K0/oO3MnIdqboq2zbaeLx atswja9Z0HU2X9bmK8r2Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:VYhd+82Fahk=:8qKapuTAK9PGC3QZTGFm93 Cv2uqZ6//UeJGJZRMh8t6n/D607bhM1JOv0wjRaxbPn/FW+RXDkMkih/t/gcO0hiGvN00WxSH IUOZ5UtG4kENR0gAMawuKNvB3LYcHHG1grcbSDqQP/BP66NmXdnncdyC/Fje3KSEJqrBsRHgS flHBVB2rkw+Sy4wZAzvjDgK9v1jeeixWlZcCGq1hd6V8ua/ZFailYZ5twLThZPB30GH0alEeN 4BtcuJtue0qkcUIWFRl1hmdRR5yZvHjT9G3LVxNawPDJYbR2E/TSC2W1COIT8+YT5YBMm0Fxv CVCdMWpPV1NaDj8bAFDmchFSwtoFeQlsxVrDtyH0gnZIAcDL1j4j4uaSLVIWcBXN5rhNFjK9H 3NwtAoLBOLVGX9Ls6HdRK6GTJaYuo5EsxJI16AX32mKNB++RlDhqyr7bqfkkb/WqHXKs3eOTu c8F8lqPWVCFAApAGqYnH9taUkWETaXUpGv5nUcYPfjs4TbvOf7jgv4u2azPEp6x+w1COYQJo7 p13QwmpRRaU/KPxmSbvhunzILyYWG1dQCFpQhDnbuYICSC2DtHVit2NMrNANj+BTHJ4SCceSi jTT9dKo7bVCOEQXehz7gqeY5s8xdjd8k+jT4gurpwowY5OZKnVS/YEw7tIuTSEOGTzURUzy9C kgRV9hC2Zaqx2MJYmkpaBJigq+1QkIcVVkao5vfZ7Aku6ztfDwqaN8kp6lTzAFV5YGDmPnfvt BNOLByR2sgQDnjzgmDIlkBLnLlcavYosoSLzlNhWeLW698K8b0Z67v3JhT9bQ9nF9ogTFxMZj +jTqXiDQcHh5AF+SdBNXVw6FkD2x241wRX0cbutTUEyrGYduAY= Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 66791 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: elfring@users.sourceforge.net Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips > The changes were obtained by applying the following Coccinelle script. A bit of clarification happened for its implementation details. https://systeme.lip6.fr/pipermail/cocci/2018-October/005374.html I have taken also another look at the following SmPL code. > identifier fn =~ > "^(__pte_alloc|pte_alloc_one|pte_alloc|__pte_alloc_kernel|pte_alloc_one_kernel)$"; I suggest to adjust the regular expression for this constraint and in subsequent SmPL rules. "^(?:pte_alloc(?:_one(?:_kernel)?)?|__pte_alloc(?:_kernel)?)$"; > ( > - T3 fn(T1 E1, T2 E2); > + T3 fn(T1 E1); > | > - T3 fn(T1 E1, T2 E2, T4 E4); > + T3 fn(T1 E1, T2 E2); > ) I propose to take an other SmPL disjunction into account here. T3 fn(T1 E1, ( - T2 E2 | T2 E2, - T4 E4 ) ); > ( > - #define fn(a, b, c)@p e > + #define fn(a, b) e > | > - #define fn(a, b)@p e > + #define fn(a) e > ) How do you think about to omit the metavariable “position p” here? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: elfring@users.sourceforge.net (SF Markus Elfring) Date: Fri, 12 Oct 2018 20:51:45 +0200 Subject: [PATCH v2 1/2] treewide: remove unused address argument from pte_alloc functions In-Reply-To: <20181012013756.11285-1-joel@joelfernandes.org> References: <20181012013756.11285-1-joel@joelfernandes.org> Message-ID: <03b524f3-5f3a-baa0-2254-9c588103d2d6@users.sourceforge.net> To: linux-riscv@lists.infradead.org List-Id: linux-riscv.lists.infradead.org > The changes were obtained by applying the following Coccinelle script. A bit of clarification happened for its implementation details. https://systeme.lip6.fr/pipermail/cocci/2018-October/005374.html I have taken also another look at the following SmPL code. > identifier fn =~ > "^(__pte_alloc|pte_alloc_one|pte_alloc|__pte_alloc_kernel|pte_alloc_one_kernel)$"; I suggest to adjust the regular expression for this constraint and in subsequent SmPL rules. "^(?:pte_alloc(?:_one(?:_kernel)?)?|__pte_alloc(?:_kernel)?)$"; > ( > - T3 fn(T1 E1, T2 E2); > + T3 fn(T1 E1); > | > - T3 fn(T1 E1, T2 E2, T4 E4); > + T3 fn(T1 E1, T2 E2); > ) I propose to take an other SmPL disjunction into account here. T3 fn(T1 E1, ( - T2 E2 | T2 E2, - T4 E4 ) ); > ( > - #define fn(a, b, c)@p e > + #define fn(a, b) e > | > - #define fn(a, b)@p e > + #define fn(a) e > ) How do you think about to omit the metavariable ?position p? here? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D83CBC71122 for ; Fri, 12 Oct 2018 18:54:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A91A220835 for ; Fri, 12 Oct 2018 18:54:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ZSsOJkgZ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A91A220835 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=users.sourceforge.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Reply-To:Content-ID:Content-Description :Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pkB8zUNwxUo6z3dXZ3XDvjgQTyPxgNE43kTbfOKKlKg=; b=ZSsOJkgZLNqO0y yHjBjycPb59XcqbocGjMUO6WSiUU0zxZATVuGoVmQaz92HnhskBbwPynobNBYRO3xsMVE4d2cvVHU UQpOIuaEVmjgLLTJTdZRQV7tD0EZC/Y+SrzWbYMsnOHf5Zqt2Sqju2xCYQ7xT6pjodx2rXWlo1r2V UfiIyLEggIfzq/SnedbILEyJ0mzTvlvrl1SwFwTQIUDWGuHx9estfWpXiU5ROKrA9M5+GC3CE+BaS YpI4fwT7N1//jWqyHugpXCD3XEXGttZfC9JTlReKG0v398mxoHqrVVSWHV+5zfgSvD+78ECxaUL0f 3xrKMcWI/kdYfW9R48lA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1gB2Za-0000BR-2J; Fri, 12 Oct 2018 18:54:06 +0000 Received: from mout.web.de ([217.72.192.78]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gB2ZU-0008QG-8B; Fri, 12 Oct 2018 18:54:02 +0000 Received: from [192.168.1.2] ([77.182.238.221]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M6V1T-1fRTIY0mGx-00yNhT; Fri, 12 Oct 2018 20:52:01 +0200 Received: from [192.168.1.2] ([77.182.238.221]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M6V1T-1fRTIY0mGx-00yNhT; Fri, 12 Oct 2018 20:52:01 +0200 Subject: Re: [PATCH v2 1/2] treewide: remove unused address argument from pte_alloc functions To: Joel Fernandes , kernel-janitors@vger.kernel.org References: <20181012013756.11285-1-joel@joelfernandes.org> From: SF Markus Elfring Message-ID: <03b524f3-5f3a-baa0-2254-9c588103d2d6@users.sourceforge.net> Date: Fri, 12 Oct 2018 20:51:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181012013756.11285-1-joel@joelfernandes.org> Content-Language: en-GB X-Provags-ID: V03:K1:kL1jfGghCfX5IqF0iVRDf8mQoouSapQgO45dI9woF05xgJDfw/d AA5sy1osx5PoQoz8e05NX77GNXJPHw9DPR0si3tMAft3cP3Og/UHQyAFEv44VXROloUsniB Y8tHxhnCqGSXk3sDOvyIeh0eyIwAL0z+iO5ZuRU8MJFacaGuv/K0/oO3MnIdqboq2zbaeLx atswja9Z0HU2X9bmK8r2Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:VYhd+82Fahk=:8qKapuTAK9PGC3QZTGFm93 Cv2uqZ6//UeJGJZRMh8t6n/D607bhM1JOv0wjRaxbPn/FW+RXDkMkih/t/gcO0hiGvN00WxSH IUOZ5UtG4kENR0gAMawuKNvB3LYcHHG1grcbSDqQP/BP66NmXdnncdyC/Fje3KSEJqrBsRHgS flHBVB2rkw+Sy4wZAzvjDgK9v1jeeixWlZcCGq1hd6V8ua/ZFailYZ5twLThZPB30GH0alEeN 4BtcuJtue0qkcUIWFRl1hmdRR5yZvHjT9G3LVxNawPDJYbR2E/TSC2W1COIT8+YT5YBMm0Fxv CVCdMWpPV1NaDj8bAFDmchFSwtoFeQlsxVrDtyH0gnZIAcDL1j4j4uaSLVIWcBXN5rhNFjK9H 3NwtAoLBOLVGX9Ls6HdRK6GTJaYuo5EsxJI16AX32mKNB++RlDhqyr7bqfkkb/WqHXKs3eOTu c8F8lqPWVCFAApAGqYnH9taUkWETaXUpGv5nUcYPfjs4TbvOf7jgv4u2azPEp6x+w1COYQJo7 p13QwmpRRaU/KPxmSbvhunzILyYWG1dQCFpQhDnbuYICSC2DtHVit2NMrNANj+BTHJ4SCceSi jTT9dKo7bVCOEQXehz7gqeY5s8xdjd8k+jT4gurpwowY5OZKnVS/YEw7tIuTSEOGTzURUzy9C kgRV9hC2Zaqx2MJYmkpaBJigq+1QkIcVVkao5vfZ7Aku6ztfDwqaN8kp6lTzAFV5YGDmPnfvt BNOLByR2sgQDnjzgmDIlkBLnLlcavYosoSLzlNhWeLW698K8b0Z67v3JhT9bQ9nF9ogTFxMZj +jTqXiDQcHh5AF+SdBNXVw6FkD2x241wRX0cbutTUEyrGYduAY= X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20181012_115400_634434_21839213 X-CRM114-Status: UNSURE ( 8.63 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mips@linux-mips.org, Rich Felker , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Peter Zijlstra , Catalin Marinas , Dave Hansen , Will Deacon , Michal Hocko , linux-mm@kvack.org, Lokesh Gidra , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, kvmarm@lists.cs.columbia.edu, Jonas Bonn , linux-s390@vger.kernel.org, Daniel Colascione , Yoshinori Sato , Max Filippov , linux-hexagon@vger.kernel.org, Helge Deller , "maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" , Hugh Dickins , "James E. J. Bottomley" , kasan-dev@googlegroups.com, Ingo Molnar , Geert Uytterhoeven , Andrey Ryabinin , linux-snps-arc@lists.infradead.org, kernel-team@android.com, Sam Creasey , Fenghua Yu , Jeff Dike , linux-um@lists.infradead.org, Stefan Kristiansson , Julia Lawall , linux-m68k@lists.linux-m68k.org, openrisc@lists.librecores.org, Borislav Petkov , Andy Lutomirski , nios2-dev@lists.rocketboards.org, "Kirill A. Shutemov" , Stafford Horne , Guan Xuetao , linux-arm-kernel@lists.infradead.org, Chris Zankel , Tony Luck , Richard Weinberger , linux-parisc@vger.kernel.org, pantin@google.com, linux-kernel@vger.kernel.org, Minchan Kim , Thomas Gleixner , linux-alpha@vger.kernel.org, Ley Foon Tan , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+infradead-linux-riscv=archiver.kernel.org@lists.infradead.org Message-ID: <20181012185145.ynJ0Wfne32FHI0mS-xap6pLGYapzF5esiNNi1no_oho@z> PiBUaGUgY2hhbmdlcyB3ZXJlIG9idGFpbmVkIGJ5IGFwcGx5aW5nIHRoZSBmb2xsb3dpbmcgQ29j Y2luZWxsZSBzY3JpcHQuCgpBIGJpdCBvZiBjbGFyaWZpY2F0aW9uIGhhcHBlbmVkIGZvciBpdHMg aW1wbGVtZW50YXRpb24gZGV0YWlscy4KaHR0cHM6Ly9zeXN0ZW1lLmxpcDYuZnIvcGlwZXJtYWls L2NvY2NpLzIwMTgtT2N0b2Jlci8wMDUzNzQuaHRtbAoKSSBoYXZlIHRha2VuIGFsc28gYW5vdGhl ciBsb29rIGF0IHRoZSBmb2xsb3dpbmcgU21QTCBjb2RlLgoKCj4gaWRlbnRpZmllciBmbiA9fgo+ ICJeKF9fcHRlX2FsbG9jfHB0ZV9hbGxvY19vbmV8cHRlX2FsbG9jfF9fcHRlX2FsbG9jX2tlcm5l bHxwdGVfYWxsb2Nfb25lX2tlcm5lbCkkIjsKCkkgc3VnZ2VzdCB0byBhZGp1c3QgdGhlIHJlZ3Vs YXIgZXhwcmVzc2lvbiBmb3IgdGhpcyBjb25zdHJhaW50CmFuZCBpbiBzdWJzZXF1ZW50IFNtUEwg cnVsZXMuCgoiXig/OnB0ZV9hbGxvYyg/Ol9vbmUoPzpfa2VybmVsKT8pP3xfX3B0ZV9hbGxvYyg/ Ol9rZXJuZWwpPykkIjsKCgo+ICgKPiAtIFQzIGZuKFQxIEUxLCBUMiBFMik7Cj4gKyBUMyBmbihU MSBFMSk7Cj4gfAo+IC0gVDMgZm4oVDEgRTEsIFQyIEUyLCBUNCBFNCk7Cj4gKyBUMyBmbihUMSBF MSwgVDIgRTIpOwo+ICkKCkkgcHJvcG9zZSB0byB0YWtlIGFuIG90aGVyIFNtUEwgZGlzanVuY3Rp b24gaW50byBhY2NvdW50IGhlcmUuCgogVDMgZm4oVDEgRTEsCigKLSAgICAgIFQyIEUyCnwgICAg ICBUMiBFMiwKLSAgICAgIFQ0IEU0CikgICAgICApOwoKCj4gKAo+IC0gI2RlZmluZSBmbihhLCBi LCBjKUBwIGUKPiArICNkZWZpbmUgZm4oYSwgYikgZQo+IHwKPiAtICNkZWZpbmUgZm4oYSwgYilA cCBlCj4gKyAjZGVmaW5lIGZuKGEpIGUKPiApCgpIb3cgZG8geW91IHRoaW5rIGFib3V0IHRvIG9t aXQgdGhlIG1ldGF2YXJpYWJsZSDigJxwb3NpdGlvbiBw4oCdIGhlcmU/CgpSZWdhcmRzLApNYXJr dXMKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4 LXJpc2N2IG1haWxpbmcgbGlzdApsaW51eC1yaXNjdkBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtcmlzY3YK From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by kanga.kvack.org (Postfix) with ESMTP id 152B86B0003 for ; Fri, 12 Oct 2018 15:11:50 -0400 (EDT) Received: by mail-wm1-f72.google.com with SMTP id j124-v6so7687168wmd.4 for ; Fri, 12 Oct 2018 12:11:50 -0700 (PDT) Received: from mout.web.de (mout.web.de. [212.227.17.11]) by mx.google.com with ESMTPS id l127-v6si1748328wmf.75.2018.10.12.12.11.48 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 12 Oct 2018 12:11:48 -0700 (PDT) Subject: Re: [PATCH v2 1/2] treewide: remove unused address argument from pte_alloc functions References: <20181012013756.11285-1-joel@joelfernandes.org> From: SF Markus Elfring Message-ID: <03b524f3-5f3a-baa0-2254-9c588103d2d6@users.sourceforge.net> Date: Fri, 12 Oct 2018 20:51:45 +0200 MIME-Version: 1.0 In-Reply-To: <20181012013756.11285-1-joel@joelfernandes.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit Sender: owner-linux-mm@kvack.org List-ID: To: Joel Fernandes , kernel-janitors@vger.kernel.org Cc: linux-kernel@vger.kernel.org, kernel-team@android.com, Michal Hocko , Julia Lawall , Andrey Ryabinin , Andy Lutomirski , Borislav Petkov , Catalin Marinas , Chris Zankel , Daniel Colascione , Dave Hansen , "David S. Miller" , Fenghua Yu , Geert Uytterhoeven , Guan Xuetao , Helge Deller , Hugh Dickins , Ingo Molnar , "James E. J. Bottomley" , Jeff Dike , Jonas Bonn , kasan-dev@googlegroups.com, kvmarm@lists.cs.columbia.edu, Ley Foon Tan , linux-alpha@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hexagon@vger.kernel.org, linux-ia64@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linux-mips@linux-mips.org, linux-mm@kvack.org, linux-parisc@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-snps-arc@lists.infradead.org, linux-um@lists.infradead.org, pantin@google.com, Lokesh Gidra , Max Filippov , Minchan Kim , nios2-dev@lists.rocketboards.org, openrisc@lists.librecores.org, Peter Zijlstra , Richard Weinberger , Rich Felker , Sam Creasey , sparclinux@vger.kernel.org, Stafford Horne , Stefan Kristiansson , Thomas Gleixner , Tony Luck , Will Deacon , "maintainer:X86 ARCHITECTURE (32-BIT AND 64-BIT)" , Yoshinori Sato , "Kirill A. Shutemov" , Andrew Morton > The changes were obtained by applying the following Coccinelle script. A bit of clarification happened for its implementation details. https://systeme.lip6.fr/pipermail/cocci/2018-October/005374.html I have taken also another look at the following SmPL code. > identifier fn =~ > "^(__pte_alloc|pte_alloc_one|pte_alloc|__pte_alloc_kernel|pte_alloc_one_kernel)$"; I suggest to adjust the regular expression for this constraint and in subsequent SmPL rules. "^(?:pte_alloc(?:_one(?:_kernel)?)?|__pte_alloc(?:_kernel)?)$"; > ( > - T3 fn(T1 E1, T2 E2); > + T3 fn(T1 E1); > | > - T3 fn(T1 E1, T2 E2, T4 E4); > + T3 fn(T1 E1, T2 E2); > ) I propose to take an other SmPL disjunction into account here. T3 fn(T1 E1, ( - T2 E2 | T2 E2, - T4 E4 ) ); > ( > - #define fn(a, b, c)@p e > + #define fn(a, b) e > | > - #define fn(a, b)@p e > + #define fn(a) e > ) How do you think about to omit the metavariable a??position pa?? here? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5573C6787C for ; Fri, 12 Oct 2018 22:32:05 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 17D352098A for ; Fri, 12 Oct 2018 22:32:05 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 17D352098A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=users.sourceforge.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 42X2dH0p7mzDqdw for ; Sat, 13 Oct 2018 09:32:03 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=users.sourceforge.net Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=users.sourceforge.net (client-ip=212.227.17.11; helo=mout.web.de; envelope-from=elfring@users.sourceforge.net; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=none (p=none dis=none) header.from=users.sourceforge.net X-Greylist: delayed 607 seconds by postgrey-1.36 at bilbo; Sat, 13 Oct 2018 06:11:56 AEDT Received: from mout.web.de (mout.web.de [212.227.17.11]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 42WyBN0X7FzF3M7 for ; Sat, 13 Oct 2018 06:11:54 +1100 (AEDT) Received: from [192.168.1.2] ([77.182.238.221]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M6V1T-1fRTIY0mGx-00yNhT; Fri, 12 Oct 2018 20:52:01 +0200 Received: from [192.168.1.2] ([77.182.238.221]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0M6V1T-1fRTIY0mGx-00yNhT; Fri, 12 Oct 2018 20:52:01 +0200 Subject: Re: [PATCH v2 1/2] treewide: remove unused address argument from pte_alloc functions To: Joel Fernandes , kernel-janitors@vger.kernel.org References: <20181012013756.11285-1-joel@joelfernandes.org> From: SF Markus Elfring Message-ID: <03b524f3-5f3a-baa0-2254-9c588103d2d6@users.sourceforge.net> Date: Fri, 12 Oct 2018 20:51:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20181012013756.11285-1-joel@joelfernandes.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 8bit X-Provags-ID: V03:K1:kL1jfGghCfX5IqF0iVRDf8mQoouSapQgO45dI9woF05xgJDfw/d AA5sy1osx5PoQoz8e05NX77GNXJPHw9DPR0si3tMAft3cP3Og/UHQyAFEv44VXROloUsniB Y8tHxhnCqGSXk3sDOvyIeh0eyIwAL0z+iO5ZuRU8MJFacaGuv/K0/oO3MnIdqboq2zbaeLx atswja9Z0HU2X9bmK8r2Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:3Bmprhxpdt4=:Bxy18Bonkv4GGZtZHkRtdh RznFT050WPU5ac/yiDhi4GvzmHK2nKJPe0JU8W43EQUAwghOUFdXYoDPhXbQxo1+rkWi3inGc IxG8jn0JdUHfPGS7Wj8g7yPD2N3YK5D26FejpxHRejZUwfVp3V1s0BqC2Du3n5WN/sK8hH43g A873o3xo3ve9JvROgL2IM2NiVSMZkWz8XRMK9IL1Is86VxCbNcQ3aIqFTo3ZHQ7utxos5xAKp wY5LLH5CUg+vgPWpHwg6QmUUjK9wxjKkxhI59xavlHW7KBjYc1n9ANMb86FxF0jEq97FpJFab lv61bWDVOQpzKslNrWhEoFQ4BxLky9gQZMAO5zbRFusGjl0yN82bbY3FzOeE9P7aR7L9s0tCT XyoLz5u6VnnTwRxBdAObGYCTLjUGXe5cMprAw76qDkIyiYkF94Mn54a2AGKix9t9Rw2sNvcwh l1VTTGY1wDfM73caOBdesxcdRLWLzT9T3KEzYju5kJQqxWmnCauzdTB/hJsNlVGObw1iErWmJ e1WVeKKMK1tnIJN0+v2OuWFpIE0rY+swV5DZIqA2IYcUD8J1fn7Jtb4PqwBfCTqpRphExliy/ ixAeu4ydfdfVH9u8q3srgmS+M2zMoNBx3zt4oEp2JPST2bBiSTj8zTtV/lWohtRJIb9HI7SNm dt1nYOdFizxVtn9/nWKMdWruLoUnyQ8bNwC4TUkGssMT9S4Ct+nBAxXR5IGmDIMV1xVDm1CRL GyTOIhSFtiSqioti/yQeNXGNHeGaLcQXyX4FcN6WgklzhBpay81VK1RBixXopJioQuSE+vtrd kz8PnbOsMLdcvFf5l9kygJAjqAx31Pp1MeaRZfgHNi3SB1gNkg= X-Mailman-Approved-At: Sat, 13 Oct 2018 08:58:21 +1100 X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-mips@linux-mips.org, Rich Felker , linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Peter Zijlstra , Catalin Marinas , Dave Hansen , Will Deacon , Michal Hocko , linux-mm@kvack.org, Lokesh Gidra , sparclinux@vger.kernel.org, linux-riscv@lists.infradead.org, kvmarm@lists.cs.columbia.edu, Jonas Bonn , linux-s390@vger.kernel.org, Daniel Colascione , Yoshinori Sato , Max Filippov , linux-hexagon@vger.kernel.org, Helge Deller , "maintainer:X86 ARCHITECTURE \(32-BIT AND 64-BIT\)" , Hugh Dickins , "James E. J. Bottomley" , kasan-dev@googlegroups.com, Ingo Molnar , Geert Uytterhoeven , Andrey Ryabinin , linux-snps-arc@lists.infradead.org, kernel-team@android.com, Sam Creasey , Fenghua Yu , Jeff Dike , linux-um@lists.infradead.org, Stefan Kristiansson , Julia Lawall , linux-m68k@lists.linux-m68k.org, openrisc@lists.librecores.org, Borislav Petkov , Andy Lutomirski , nios2-dev@lists.rocketboards.org, "Kirill A. Shutemov" , Stafford Horne , Guan Xuetao , linux-arm-kernel@lists.infradead.org, Chris Zankel , Tony Luck , Richard Weinberger , linux-parisc@vger.kernel.org, pantin@google.com, linux-kernel@vger.kernel.org, Minchan Kim , Thomas Gleixner , linux-alpha@vger.kernel.org, Ley Foon Tan , Andrew Morton , linuxppc-dev@lists.ozlabs.org, "David S. Miller" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" > The changes were obtained by applying the following Coccinelle script. A bit of clarification happened for its implementation details. https://systeme.lip6.fr/pipermail/cocci/2018-October/005374.html I have taken also another look at the following SmPL code. > identifier fn =~ > "^(__pte_alloc|pte_alloc_one|pte_alloc|__pte_alloc_kernel|pte_alloc_one_kernel)$"; I suggest to adjust the regular expression for this constraint and in subsequent SmPL rules. "^(?:pte_alloc(?:_one(?:_kernel)?)?|__pte_alloc(?:_kernel)?)$"; > ( > - T3 fn(T1 E1, T2 E2); > + T3 fn(T1 E1); > | > - T3 fn(T1 E1, T2 E2, T4 E4); > + T3 fn(T1 E1, T2 E2); > ) I propose to take an other SmPL disjunction into account here. T3 fn(T1 E1, ( - T2 E2 | T2 E2, - T4 E4 ) ); > ( > - #define fn(a, b, c)@p e > + #define fn(a, b) e > | > - #define fn(a, b)@p e > + #define fn(a) e > ) How do you think about to omit the metavariable “position p” here? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: elfring@users.sourceforge.net (SF Markus Elfring) Date: Fri, 12 Oct 2018 20:51:45 +0200 Subject: [PATCH v2 1/2] treewide: remove unused address argument from pte_alloc functions In-Reply-To: <20181012013756.11285-1-joel@joelfernandes.org> References: <20181012013756.11285-1-joel@joelfernandes.org> List-ID: Message-ID: <03b524f3-5f3a-baa0-2254-9c588103d2d6@users.sourceforge.net> To: linux-snps-arc@lists.infradead.org > The changes were obtained by applying the following Coccinelle script. A bit of clarification happened for its implementation details. https://systeme.lip6.fr/pipermail/cocci/2018-October/005374.html I have taken also another look at the following SmPL code. > identifier fn =~ > "^(__pte_alloc|pte_alloc_one|pte_alloc|__pte_alloc_kernel|pte_alloc_one_kernel)$"; I suggest to adjust the regular expression for this constraint and in subsequent SmPL rules. "^(?:pte_alloc(?:_one(?:_kernel)?)?|__pte_alloc(?:_kernel)?)$"; > ( > - T3 fn(T1 E1, T2 E2); > + T3 fn(T1 E1); > | > - T3 fn(T1 E1, T2 E2, T4 E4); > + T3 fn(T1 E1, T2 E2); > ) I propose to take an other SmPL disjunction into account here. T3 fn(T1 E1, ( - T2 E2 | T2 E2, - T4 E4 ) ); > ( > - #define fn(a, b, c)@p e > + #define fn(a, b) e > | > - #define fn(a, b)@p e > + #define fn(a) e > ) How do you think about to omit the metavariable ?position p? here? Regards, Markus From mboxrd@z Thu Jan 1 00:00:00 1970 From: SF Markus Elfring Date: Fri, 12 Oct 2018 20:51:45 +0200 Subject: [OpenRISC] [PATCH v2 1/2] treewide: remove unused address argument from pte_alloc functions In-Reply-To: <20181012013756.11285-1-joel@joelfernandes.org> References: <20181012013756.11285-1-joel@joelfernandes.org> Message-ID: <03b524f3-5f3a-baa0-2254-9c588103d2d6@users.sourceforge.net> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: openrisc@lists.librecores.org > The changes were obtained by applying the following Coccinelle script. A bit of clarification happened for its implementation details. https://systeme.lip6.fr/pipermail/cocci/2018-October/005374.html I have taken also another look at the following SmPL code. > identifier fn =~ > "^(__pte_alloc|pte_alloc_one|pte_alloc|__pte_alloc_kernel|pte_alloc_one_kernel)$"; I suggest to adjust the regular expression for this constraint and in subsequent SmPL rules. "^(?:pte_alloc(?:_one(?:_kernel)?)?|__pte_alloc(?:_kernel)?)$"; > ( > - T3 fn(T1 E1, T2 E2); > + T3 fn(T1 E1); > | > - T3 fn(T1 E1, T2 E2, T4 E4); > + T3 fn(T1 E1, T2 E2); > ) I propose to take an other SmPL disjunction into account here. T3 fn(T1 E1, ( - T2 E2 | T2 E2, - T4 E4 ) ); > ( > - #define fn(a, b, c)@p e > + #define fn(a, b) e > | > - #define fn(a, b)@p e > + #define fn(a) e > ) How do you think about to omit the metavariable “position p” here? Regards, Markus